From a859c104a51af5c2302c7a2fd4e5a6bd91e7720c Mon Sep 17 00:00:00 2001 From: samyou-softwire Date: Tue, 17 Mar 2026 17:05:28 +0000 Subject: [PATCH] CLDC-4270: Add ? to boolean method --- app/services/bulk_upload/lettings/year2025/csv_parser.rb | 4 ++-- app/services/bulk_upload/lettings/year2026/csv_parser.rb | 4 ++-- app/services/bulk_upload/sales/year2025/csv_parser.rb | 4 ++-- app/services/bulk_upload/sales/year2026/csv_parser.rb | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/services/bulk_upload/lettings/year2025/csv_parser.rb b/app/services/bulk_upload/lettings/year2025/csv_parser.rb index 21750b352..fd71e2644 100644 --- a/app/services/bulk_upload/lettings/year2025/csv_parser.rb +++ b/app/services/bulk_upload/lettings/year2025/csv_parser.rb @@ -41,7 +41,7 @@ class BulkUpload::Lettings::Year2025::CsvParser hash_rows = field_numbers .zip(stripped_row) .map do |field, value| - field_is_valid = value_is_valid_for_field(field, value) + field_is_valid = value_is_valid_for_field?(field, value) correct_value = field_is_valid ? value : nil @@ -133,7 +133,7 @@ private # this is needed as a string passed to an int attribute is by default mapped to '0'. # this is bad as some questions will accept a '0'. so you could enter something invalid and not be told about it - def value_is_valid_for_field(field, value) + def value_is_valid_for_field?(field, value) field_type = ROW_PARSER_CLASS.attribute_types[field] if field_type.is_a?(ActiveModel::Type::Integer) diff --git a/app/services/bulk_upload/lettings/year2026/csv_parser.rb b/app/services/bulk_upload/lettings/year2026/csv_parser.rb index 14116fc93..c1a570f3e 100644 --- a/app/services/bulk_upload/lettings/year2026/csv_parser.rb +++ b/app/services/bulk_upload/lettings/year2026/csv_parser.rb @@ -40,7 +40,7 @@ class BulkUpload::Lettings::Year2026::CsvParser hash_rows = field_numbers .zip(stripped_row) .map do |field, value| - field_is_valid = value_is_valid_for_field(field, value) + field_is_valid = value_is_valid_for_field?(field, value) correct_value = field_is_valid ? value : nil @@ -142,7 +142,7 @@ private # this is needed as a string passed to an int attribute is by default mapped to '0'. # this is bad as some questions will accept a '0'. so you could enter something invalid and not be told about it - def value_is_valid_for_field(field, value) + def value_is_valid_for_field?(field, value) field_type = ROW_PARSER_CLASS.attribute_types[field] if field_type.is_a?(ActiveModel::Type::Integer) diff --git a/app/services/bulk_upload/sales/year2025/csv_parser.rb b/app/services/bulk_upload/sales/year2025/csv_parser.rb index 0bdb756d7..9e60bb04f 100644 --- a/app/services/bulk_upload/sales/year2025/csv_parser.rb +++ b/app/services/bulk_upload/sales/year2025/csv_parser.rb @@ -41,7 +41,7 @@ class BulkUpload::Sales::Year2025::CsvParser hash_rows = field_numbers .zip(stripped_row) .map do |field, value| - field_is_valid = value_is_valid_for_field(field, value) + field_is_valid = value_is_valid_for_field?(field, value) correct_value = field_is_valid ? value : nil @@ -136,7 +136,7 @@ private # this is needed as a string passed to an int attribute is by default mapped to '0'. # this is bad as some questions will accept a '0'. so you could enter something invalid and not be told about it - def value_is_valid_for_field(field, value) + def value_is_valid_for_field?(field, value) field_type = ROW_PARSER_CLASS.attribute_types[field] if field_type.is_a?(ActiveModel::Type::Integer) diff --git a/app/services/bulk_upload/sales/year2026/csv_parser.rb b/app/services/bulk_upload/sales/year2026/csv_parser.rb index 044d8271d..a5d8c77ac 100644 --- a/app/services/bulk_upload/sales/year2026/csv_parser.rb +++ b/app/services/bulk_upload/sales/year2026/csv_parser.rb @@ -40,7 +40,7 @@ class BulkUpload::Sales::Year2026::CsvParser hash_rows = field_numbers .zip(stripped_row) .map do |field, value| - field_is_valid = value_is_valid_for_field(field, value) + field_is_valid = value_is_valid_for_field?(field, value) correct_value = field_is_valid ? value : nil @@ -135,7 +135,7 @@ private # this is needed as a string passed to an int attribute is by default mapped to '0'. # this is bad as some questions will accept a '0'. so you could enter something invalid and not be told about it - def value_is_valid_for_field(field, value) + def value_is_valid_for_field?(field, value) field_type = ROW_PARSER_CLASS.attribute_types[field] if field_type.is_a?(ActiveModel::Type::Integer)