From a594d942aaf299e32dc1fce2c62c98fc5799831b Mon Sep 17 00:00:00 2001 From: Arthur Campbell Date: Sat, 1 Apr 2023 21:24:05 +0100 Subject: [PATCH] add back an "end" deleted by mistake and fix a linting issue --- app/models/form.rb | 2 +- spec/models/lettings_log_spec.rb | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/models/form.rb b/app/models/form.rb index 97d4b0f07..e862a9c85 100644 --- a/app/models/form.rb +++ b/app/models/form.rb @@ -192,7 +192,7 @@ class Form valid_options = checkbox_questions[:valid] .select { |q| q.id == invalidated_question.id } .flat_map { |q| q.answer_options.keys } - invalidated_question.answer_options.keys.each do |invalid_option| + invalidated_question.answer_options.each_key do |invalid_option| if !log.respond_to?(invalid_option) || valid_options.include?(invalid_option) next else diff --git a/spec/models/lettings_log_spec.rb b/spec/models/lettings_log_spec.rb index 169058252..fb0f01be2 100644 --- a/spec/models/lettings_log_spec.rb +++ b/spec/models/lettings_log_spec.rb @@ -2620,6 +2620,7 @@ RSpec.describe LettingsLog do end end end + end describe "tshortfall_unknown?" do context "when tshortfall is nil" do