2 changed files with 134 additions and 0 deletions
@ -0,0 +1,17 @@ |
|||||||
|
desc "Update lettings logs renewal previous postcode and la data to be the same as current postcode/la" |
||||||
|
task correct_renewal_postcodes: :environment do |
||||||
|
LettingsLog.filter_by_year(2023).where(renewal: 1).where("(ppostcode_full != postcode_full) OR (ppostcode_full IS NULL AND postcode_full IS NOT NULL) OR (postcode_full IS NULL AND ppostcode_full IS NOT NULL)").each do |log| |
||||||
|
log.ppostcode_full = log.postcode_full |
||||||
|
log.ppcodenk = case log.postcode_known |
||||||
|
when 0 |
||||||
|
1 |
||||||
|
when 1 |
||||||
|
0 |
||||||
|
end |
||||||
|
log.is_previous_la_inferred = log.is_la_inferred |
||||||
|
log.previous_la_known = 1 if log.la.present? |
||||||
|
log.prevloc = log.la |
||||||
|
log.values_updated_at = Time.zone.now |
||||||
|
log.save! |
||||||
|
end |
||||||
|
end |
||||||
@ -0,0 +1,117 @@ |
|||||||
|
require "rails_helper" |
||||||
|
require "rake" |
||||||
|
|
||||||
|
RSpec.describe "correct_renewal_postcodes" do |
||||||
|
describe ":correct_renewal_postcodes", type: :task do |
||||||
|
subject(:task) { Rake::Task["correct_renewal_postcodes"] } |
||||||
|
|
||||||
|
before do |
||||||
|
Rake.application.rake_require("tasks/correct_renewal_postcodes") |
||||||
|
Rake::Task.define_task(:environment) |
||||||
|
task.reenable |
||||||
|
end |
||||||
|
|
||||||
|
context "when the rake task is run" do |
||||||
|
context "and there there is a renewal lettings log with different previous postcode" do |
||||||
|
let(:log) { create(:lettings_log, :completed, postcode_full: "SW1A 1AA", ppostcode_full: "AA1 1AA") } |
||||||
|
|
||||||
|
before do |
||||||
|
log.renewal = 1 |
||||||
|
log.values_updated_at = nil |
||||||
|
log.save!(validate: false) |
||||||
|
end |
||||||
|
|
||||||
|
it "updates the previous postcode and reexports the log" do |
||||||
|
expect(log.ppostcode_full).to eq("AA1 1AA") |
||||||
|
|
||||||
|
task.invoke |
||||||
|
log.reload |
||||||
|
|
||||||
|
expect(log.ppostcode_full).to eq("SW1A 1AA") |
||||||
|
expect(log.values_updated_at).not_to eq(nil) |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
context "and there there is a renewal lettings log with missing previous postcode" do |
||||||
|
let(:log) { create(:lettings_log, :completed, postcode_full: "SW1A 1AA", ppostcode_full: nil) } |
||||||
|
|
||||||
|
before do |
||||||
|
log.renewal = 1 |
||||||
|
log.values_updated_at = nil |
||||||
|
log.save!(validate: false) |
||||||
|
end |
||||||
|
|
||||||
|
it "updates the previous postcode and reexports the log" do |
||||||
|
expect(log.ppostcode_full).to eq(nil) |
||||||
|
|
||||||
|
task.invoke |
||||||
|
log.reload |
||||||
|
|
||||||
|
expect(log.ppostcode_full).to eq("SW1A 1AA") |
||||||
|
expect(log.values_updated_at).not_to eq(nil) |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
context "and there there is a renewal lettings log without postcode" do |
||||||
|
let(:log) { create(:lettings_log, :completed, postcode_known: 0, postcode_full: nil, ppostcode_full: "AA1 1AA") } |
||||||
|
|
||||||
|
before do |
||||||
|
log.renewal = 1 |
||||||
|
log.values_updated_at = nil |
||||||
|
log.save!(validate: false) |
||||||
|
end |
||||||
|
|
||||||
|
it "clears the previous postcode and reexports the log" do |
||||||
|
expect(log.ppostcode_full).to eq("AA1 1AA") |
||||||
|
|
||||||
|
task.invoke |
||||||
|
log.reload |
||||||
|
|
||||||
|
expect(log.ppostcode_full).to eq(nil) |
||||||
|
expect(log.values_updated_at).not_to eq(nil) |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
context "and there is a renewal lettings log with same postcodes" do |
||||||
|
let(:log) { create(:lettings_log, :completed, postcode_full: "AA1 1AA", ppostcode_full: "AA1 1AA") } |
||||||
|
|
||||||
|
before do |
||||||
|
log.renewal = 1 |
||||||
|
log.values_updated_at = nil |
||||||
|
log.save!(validate: false) |
||||||
|
end |
||||||
|
|
||||||
|
it "does not update the previous postcode and does not re-export" do |
||||||
|
expect(log.ppostcode_full).to eq("AA1 1AA") |
||||||
|
|
||||||
|
task.invoke |
||||||
|
log.reload |
||||||
|
|
||||||
|
expect(log.ppostcode_full).to eq("AA1 1AA") |
||||||
|
expect(log.values_updated_at).to eq(nil) |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
context "and there is a renewal lettings log from closed collection year" do |
||||||
|
let(:log) { create(:lettings_log, :completed, postcode_full: "AA1 1AA", ppostcode_full: nil) } |
||||||
|
|
||||||
|
before do |
||||||
|
log.renewal = 1 |
||||||
|
log.values_updated_at = nil |
||||||
|
log.startdate = Time.zone.local(2022, 4, 4) |
||||||
|
log.save!(validate: false) |
||||||
|
end |
||||||
|
|
||||||
|
it "does not update the previous postcode and does not re-export" do |
||||||
|
expect(log.ppostcode_full).to eq(nil) |
||||||
|
|
||||||
|
task.invoke |
||||||
|
log.reload |
||||||
|
|
||||||
|
expect(log.ppostcode_full).to eq(nil) |
||||||
|
expect(log.values_updated_at).to eq(nil) |
||||||
|
end |
||||||
|
end |
||||||
|
end |
||||||
|
end |
||||||
|
end |
||||||
Loading…
Reference in new issue