Browse Source

Remove hbrentshortfall because we want to set the log back in progress

pull/1472/head
Kat 3 years ago
parent
commit
a51036fbef
  1. 1
      app/services/imports/lettings_logs_import_service.rb
  2. 2
      spec/services/imports/lettings_logs_import_service_spec.rb

1
app/services/imports/lettings_logs_import_service.rb

@ -336,6 +336,7 @@ module Imports
@logger.warn("Log #{lettings_log.old_id}: Removing tshortfall as there are no outstanding charges")
@logs_overridden << lettings_log.old_id
attributes.delete("tshortfall")
attributes.delete("hbrentshortfall")
save_lettings_log(attributes, previous_status)
else
@logger.error("Log #{lettings_log.old_id}: Failed to import")

2
spec/services/imports/lettings_logs_import_service_spec.rb

@ -710,7 +710,7 @@ RSpec.describe Imports::LettingsLogsImportService do
expect(lettings_log).not_to be_nil
expect(lettings_log.tshortfall).to be_nil
expect(lettings_log.hbrentshortfall).to eq(2)
expect(lettings_log.hbrentshortfall).to be_nil
end
end
end

Loading…
Cancel
Save