From a2e7bb08c2a9814f4ad6b627c6332d05df6a147d Mon Sep 17 00:00:00 2001 From: Arthur Campbell Date: Tue, 25 Jun 2024 11:57:06 +0100 Subject: [PATCH] remove sale and start dates from logs in tests where that should not be important build rather than create to reduce db interactions in order that the setup is complete, build the necessary user and organisation with ids --- spec/models/log_spec.rb | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/spec/models/log_spec.rb b/spec/models/log_spec.rb index 21ff2849d..76fadad6b 100644 --- a/spec/models/log_spec.rb +++ b/spec/models/log_spec.rb @@ -7,23 +7,26 @@ RSpec.describe Log, type: :model do end describe "#calculate_status" do + let(:organisation) { build(:organisation, id: 1) } + let(:user) { build(:user, id: 1, organisation:) } + it "returns the correct status for a completed sales log" do - complete_sales_log = create(:sales_log, :completed, saledate: Time.zone.local(2023, 12, 12), status: nil) + complete_sales_log = build(:sales_log, :completed, assigned_to: user) expect(complete_sales_log.calculate_status).to eq "completed" end it "returns the correct status for an in progress sales log" do - in_progress_sales_log = create(:sales_log, :in_progress, saledate: Time.zone.local(2023, 12, 12), status: nil) + in_progress_sales_log = build(:sales_log, :in_progress, assigned_to: user) expect(in_progress_sales_log.calculate_status).to eq "in_progress" end it "returns the correct status for a completed lettings log" do - complete_lettings_log = create(:lettings_log, :completed, startdate: Time.zone.local(2023, 12, 12), voiddate: Time.zone.local(2023, 12, 11), mrcdate: Time.zone.local(2023, 12, 11), status: nil) + complete_lettings_log = build(:lettings_log, :completed, assigned_to: user) expect(complete_lettings_log.calculate_status).to eq "completed" end it "returns the correct status for an in progress lettings log" do - in_progress_lettings_log = create(:lettings_log, :in_progress, startdate: Time.zone.local(2023, 12, 12), status: nil) + in_progress_lettings_log = build(:lettings_log, :in_progress, assigned_to: user) expect(in_progress_lettings_log.calculate_status).to eq "in_progress" end end