From a136a7013976986df480fd0c2cc34bf42ea5c810 Mon Sep 17 00:00:00 2001 From: James Rose Date: Wed, 5 Oct 2022 15:24:35 +0100 Subject: [PATCH] Check that we have an inferred check answers value before extracting its value (#933) It's possible that this method returns true despite not having an `inferred_check_answers_value` set. This is an obvious smell that we will return to fix. --- app/models/form/question.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/form/question.rb b/app/models/form/question.rb index 7449d6932..227e6079e 100644 --- a/app/models/form/question.rb +++ b/app/models/form/question.rb @@ -51,7 +51,7 @@ class Form::Question answer = label_from_value(log[id]) if log[id].present? answer_label = [prefix, format_value(answer), suffix_label(log)].join("") if answer - inferred = inferred_check_answers_value["value"] if has_inferred_check_answers_value?(log) + inferred = inferred_check_answers_value["value"] if inferred_check_answers_value && has_inferred_check_answers_value?(log) return inferred if inferred.present? answer_label