From a09a941abe46537ea2851fb4d0d4a3b1193bfa0b Mon Sep 17 00:00:00 2001 From: Kat Date: Wed, 6 Sep 2023 14:22:26 +0100 Subject: [PATCH] Refactor postcode_known --- app/services/imports/lettings_logs_field_import_service.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/services/imports/lettings_logs_field_import_service.rb b/app/services/imports/lettings_logs_field_import_service.rb index c59986717..38111a214 100644 --- a/app/services/imports/lettings_logs_field_import_service.rb +++ b/app/services/imports/lettings_logs_field_import_service.rb @@ -170,10 +170,8 @@ module Imports end def postcode_known(record) - if record.postcode_full.nil? && record.la.nil? - nil - elsif record.postcode_full.nil? - 0 # Assumes we selected No in the form since the LA is present + if record.postcode_full.nil? + record.la.nil? ? nil : 0 # Assumes we selected No in the form since the LA is present else 1 end