From a031315ecc5d1abc4a42ca2f3783259da16b7d2f Mon Sep 17 00:00:00 2001
From: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
Date: Thu, 29 Sep 2022 16:52:10 +0100
Subject: [PATCH] feat: add depends_on and tests

---
 app/models/form/sales/pages/buyer2_relationship_to_buyer1.rb  | 4 ++++
 spec/factories/sales_log.rb                                   | 1 +
 .../form/sales/subsections/household_characteristics_spec.rb  | 2 +-
 spec/models/form_handler_spec.rb                              | 4 ++--
 4 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/app/models/form/sales/pages/buyer2_relationship_to_buyer1.rb b/app/models/form/sales/pages/buyer2_relationship_to_buyer1.rb
index d78199381..0f217bf4a 100644
--- a/app/models/form/sales/pages/buyer2_relationship_to_buyer1.rb
+++ b/app/models/form/sales/pages/buyer2_relationship_to_buyer1.rb
@@ -5,6 +5,10 @@ class Form::Sales::Pages::Buyer2RelationshipToBuyer1 < ::Form::Page
     @header = ""
     @description = ""
     @subsection = subsection
+    @depends_on = [{
+      "jointpur" => 1,
+    }]
+
   end
 
   def questions
diff --git a/spec/factories/sales_log.rb b/spec/factories/sales_log.rb
index f565772cb..d4b9943dd 100644
--- a/spec/factories/sales_log.rb
+++ b/spec/factories/sales_log.rb
@@ -23,6 +23,7 @@ FactoryBot.define do
       age1 { 30 }
       sex1 { "X" }
       buy1livein { 1 }
+      relat2 { "P" }
       proptype { 1 }
       age2_known { 0 }
       age2 { 35 }
diff --git a/spec/models/form/sales/subsections/household_characteristics_spec.rb b/spec/models/form/sales/subsections/household_characteristics_spec.rb
index 1be1ae79c..71a8e898d 100644
--- a/spec/models/form/sales/subsections/household_characteristics_spec.rb
+++ b/spec/models/form/sales/subsections/household_characteristics_spec.rb
@@ -13,7 +13,7 @@ RSpec.describe Form::Sales::Subsections::HouseholdCharacteristics, type: :model
 
   it "has correct pages" do
     expect(household_characteristics.pages.map(&:id)).to eq(
-      %w[buyer_1_age buyer_1_gender_identity buyer_1_live_in_property buyer_2_age],
+      %w[buyer_1_age buyer_1_gender_identity buyer_1_live_in_property buyer_2_relationship_to_buyer_1 buyer_2_age],
     )
   end
 
diff --git a/spec/models/form_handler_spec.rb b/spec/models/form_handler_spec.rb
index c9199af9b..51dcc3d0e 100644
--- a/spec/models/form_handler_spec.rb
+++ b/spec/models/form_handler_spec.rb
@@ -61,14 +61,14 @@ RSpec.describe FormHandler do
     it "is able to load a current sales form" do
       form = form_handler.get_form("current_sales")
       expect(form).to be_a(Form)
-      expect(form.pages.count).to eq(17)
+      expect(form.pages.count).to eq(18)
       expect(form.name).to eq("2022_2023_sales")
     end
 
     it "is able to load a previous sales form" do
       form = form_handler.get_form("previous_sales")
       expect(form).to be_a(Form)
-      expect(form.pages.count).to eq(17)
+      expect(form.pages.count).to eq(18)
       expect(form.name).to eq("2021_2022_sales")
     end
   end