From 9e36fe7d34723405323791e9ebd1028c5e7f0f56 Mon Sep 17 00:00:00 2001
From: Nat Dean-Lewis <94526761+natdeanlewissoftwire@users.noreply.github.com>
Date: Mon, 23 Mar 2026 11:28:44 +0000
Subject: [PATCH] CLDC-4314: Monthly service charge soft validation redirect
 bug (#3249)

* CLDC-4314: set unique urls for shared ownership soft validations

* CLDC-4314: update specs
---
 .../sales/subsections/shared_ownership_initial_purchase.rb  | 2 +-
 .../subsections/shared_ownership_staircasing_transaction.rb | 2 +-
 .../subsections/shared_ownership_initial_purchase_spec.rb   | 6 +++---
 .../shared_ownership_staircasing_transaction_spec.rb        | 4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/app/models/form/sales/subsections/shared_ownership_initial_purchase.rb b/app/models/form/sales/subsections/shared_ownership_initial_purchase.rb
index 7ac9c0543..462f4b14c 100644
--- a/app/models/form/sales/subsections/shared_ownership_initial_purchase.rb
+++ b/app/models/form/sales/subsections/shared_ownership_initial_purchase.rb
@@ -40,7 +40,7 @@ class Form::Sales::Subsections::SharedOwnershipInitialPurchase < ::Form::Subsect
       Form::Sales::Pages::SharedOwnershipDepositValueCheck.new("shared_ownership_deposit_value_check", nil, self),
       Form::Sales::Pages::MonthlyRent.new(nil, nil, self),
       Form::Sales::Pages::ServiceCharge.new("service_charge", nil, self),
-      Form::Sales::Pages::MonthlyChargesValueCheck.new("monthly_charges_shared_ownership_value_check", nil, self),
+      Form::Sales::Pages::MonthlyChargesValueCheck.new("monthly_charges_initial_purchase_value_check", nil, self),
       Form::Sales::Pages::EstateManagementFee.new("estate_management_fee", nil, self),
     ].compact
   end
diff --git a/app/models/form/sales/subsections/shared_ownership_staircasing_transaction.rb b/app/models/form/sales/subsections/shared_ownership_staircasing_transaction.rb
index 1af25a140..0ff054f18 100644
--- a/app/models/form/sales/subsections/shared_ownership_staircasing_transaction.rb
+++ b/app/models/form/sales/subsections/shared_ownership_staircasing_transaction.rb
@@ -27,7 +27,7 @@ class Form::Sales::Subsections::SharedOwnershipStaircasingTransaction < ::Form::
       Form::Sales::Pages::MonthlyRentStaircasing.new(nil, nil, self),
       (Form::Sales::Pages::ServiceChargeStaircasing.new("service_charge_staircasing", nil, self) if form.start_year_2026_or_later?),
       (Form::Sales::Pages::ServiceChargeChanged.new(nil, nil, self) if form.start_year_2026_or_later?),
-      Form::Sales::Pages::MonthlyChargesValueCheck.new("monthly_charges_shared_ownership_value_check", nil, self),
+      Form::Sales::Pages::MonthlyChargesValueCheck.new("monthly_charges_staircasing_value_check", nil, self),
     ].compact
   end
 
diff --git a/spec/models/form/sales/subsections/shared_ownership_initial_purchase_spec.rb b/spec/models/form/sales/subsections/shared_ownership_initial_purchase_spec.rb
index 984247af6..ce154af3d 100644
--- a/spec/models/form/sales/subsections/shared_ownership_initial_purchase_spec.rb
+++ b/spec/models/form/sales/subsections/shared_ownership_initial_purchase_spec.rb
@@ -59,7 +59,7 @@ RSpec.describe Form::Sales::Subsections::SharedOwnershipInitialPurchase, type: :
           shared_ownership_deposit_value_check
           monthly_rent
           service_charge
-          monthly_charges_shared_ownership_value_check
+          monthly_charges_initial_purchase_value_check
           estate_management_fee
         ],
       )
@@ -102,7 +102,7 @@ RSpec.describe Form::Sales::Subsections::SharedOwnershipInitialPurchase, type: :
           shared_ownership_deposit_value_check
           monthly_rent
           service_charge
-          monthly_charges_shared_ownership_value_check
+          monthly_charges_initial_purchase_value_check
           estate_management_fee
         ],
       )
@@ -145,7 +145,7 @@ RSpec.describe Form::Sales::Subsections::SharedOwnershipInitialPurchase, type: :
           shared_ownership_deposit_value_check
           monthly_rent
           service_charge
-          monthly_charges_shared_ownership_value_check
+          monthly_charges_initial_purchase_value_check
           estate_management_fee
         ],
       )
diff --git a/spec/models/form/sales/subsections/shared_ownership_staircasing_transaction_spec.rb b/spec/models/form/sales/subsections/shared_ownership_staircasing_transaction_spec.rb
index cc811682b..e70e4b613 100644
--- a/spec/models/form/sales/subsections/shared_ownership_staircasing_transaction_spec.rb
+++ b/spec/models/form/sales/subsections/shared_ownership_staircasing_transaction_spec.rb
@@ -48,7 +48,7 @@ RSpec.describe Form::Sales::Subsections::SharedOwnershipStaircasingTransaction,
           staircase_mortgage_used_shared_ownership
           monthly_rent_staircasing_owned
           monthly_rent_staircasing
-          monthly_charges_shared_ownership_value_check
+          monthly_charges_staircasing_value_check
         ],
       )
     end
@@ -78,7 +78,7 @@ RSpec.describe Form::Sales::Subsections::SharedOwnershipStaircasingTransaction,
           monthly_rent_staircasing
           service_charge_staircasing
           service_charge_changed
-          monthly_charges_shared_ownership_value_check
+          monthly_charges_staircasing_value_check
         ],
       )
     end