Browse Source

add error count to bulk upload results

remotes/origin/bulk-upload-errors-integration
Phil Lee 4 years ago
parent
commit
9e1be87813
  1. 2
      app/views/bulk_upload_lettings_results/show.html.erb
  2. 27
      spec/requests/bulk_upload_lettings_results_controller_spec.rb

2
app/views/bulk_upload_lettings_results/show.html.erb

@ -1,7 +1,7 @@
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<span class="govuk-caption-l">Bulk Upload for lettings (<%= @bulk_upload.year_combo %>)</span>
<h1 class="govuk-heading-l">We found X errors in your file</h1>
<h1 class="govuk-heading-l">We found <%= pluralize(@bulk_upload.bulk_upload_errors.count, "error") %> in your file</h1>
<div class="govuk-body">
Here’s a list of everything that you need to fix your spreadsheet. You can download the specification to help you fix the cells in your CSV file.

27
spec/requests/bulk_upload_lettings_results_controller_spec.rb

@ -0,0 +1,27 @@
require "rails_helper"
RSpec.describe BulkUploadLettingsResultsController, type: :request do
let(:user) { create(:user) }
let(:bulk_upload) { create(:bulk_upload, user:, bulk_upload_errors:) }
let(:bulk_upload_errors) { create_list(:bulk_upload_error, 2) }
before do
sign_in user
end
describe "GET /lettings-logs/bulk-upload-results/:ID" do
it "renders correct year" do
get "/lettings-logs/bulk-upload-results/#{bulk_upload.id}"
expect(response).to be_successful
expect(response.body).to include("Bulk Upload for lettings (2022/23)")
end
it "renders correct number of errors" do
get "/lettings-logs/bulk-upload-results/#{bulk_upload.id}"
expect(response).to be_successful
expect(response.body).to include("We found 2 errors in your file")
end
end
end
Loading…
Cancel
Save