From 9dfa2d8311d6f46ed0ba0a3dfe954252dd40c5e8 Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Mon, 20 Mar 2023 13:50:33 +0000 Subject: [PATCH] feat: add tests --- .../sales/household_validations.rb | 2 +- .../sales/household_validations_spec.rb | 23 +++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/app/models/validations/sales/household_validations.rb b/app/models/validations/sales/household_validations.rb index 666886865..c987e336c 100644 --- a/app/models/validations/sales/household_validations.rb +++ b/app/models/validations/sales/household_validations.rb @@ -89,7 +89,7 @@ private if person_age > buyer_1_age - 12 && person_is_child?(relationship) record.errors.add "age1", I18n.t("validations.household.age.child_12_years_younger") record.errors.add "age#{person_num}", I18n.t("validations.household.age.child_12_years_younger") - record.errors.add "relat#{person_num}", I18n.t("validations.household.relat.child_12_years_younger") + record.errors.add "relat#{person_num}", I18n.t("validations.household.age.child_12_years_younger") end end diff --git a/spec/models/validations/sales/household_validations_spec.rb b/spec/models/validations/sales/household_validations_spec.rb index 10367390e..16e629141 100644 --- a/spec/models/validations/sales/household_validations_spec.rb +++ b/spec/models/validations/sales/household_validations_spec.rb @@ -72,6 +72,29 @@ RSpec.describe Validations::Sales::HouseholdValidations do expect(record.errors["age2"]) .to include(match I18n.t("validations.household.age.child_over_16", person_num: 2)) end + + it "validates the child is at least 12 years younger than buyer 1" do + record.age1 = 30 + record.age2 = 19 + record.relat2 = "C" + household_validator.validate_household_number_of_other_members(record) + expect(record.errors["age1"]) + .to include(match I18n.t("validations.household.age.child_12_years_younger", person_num: 2)) + expect(record.errors["age2"]) + .to include(match I18n.t("validations.household.age.child_12_years_younger", person_num: 2)) + expect(record.errors["relat2"]) + .to include(match I18n.t("validations.household.age.child_12_years_younger", person_num: 2)) + end + + it "expects the child is at least 12 years younger than buyer 1" do + record.age1 = 30 + record.age2 = 18 + record.relat2 = "C" + household_validator.validate_household_number_of_other_members(record) + expect(record.errors["age1"]).to be_empty + expect(record.errors["age2"]).to be_empty + expect(record.errors["relate2"]).to be_empty + end end it "validates that a person over 20 must not be a child of the buyer" do