Browse Source

style: lint code

pull/987/head
Sam Seed 4 years ago
parent
commit
9b79f971ee
  1. 4
      app/helpers/schemes_helper.rb
  2. 40
      spec/helpers/schemes_helper_spec.rb

4
app/helpers/schemes_helper.rb

@ -22,11 +22,11 @@ module SchemesHelper
end end
if user.data_coordinator? if user.data_coordinator?
base_attributes.delete_if {|item| item[:name] == "Housing stock owned by"} base_attributes.delete_if { |item| item[:name] == "Housing stock owned by" }
end end
if scheme.arrangement_type_same? if scheme.arrangement_type_same?
base_attributes.delete_if {|item| item[:name] == "Organisation providing support"} base_attributes.delete_if { |item| item[:name] == "Organisation providing support" }
end end
base_attributes base_attributes
end end

40
spec/helpers/schemes_helper_spec.rb

@ -1,7 +1,5 @@
require "rails_helper" require "rails_helper"
include TagHelper
RSpec.describe SchemesHelper do RSpec.describe SchemesHelper do
describe "Active periods" do describe "Active periods" do
let(:scheme) { FactoryBot.create(:scheme, created_at: Time.zone.today) } let(:scheme) { FactoryBot.create(:scheme, created_at: Time.zone.today) }
@ -89,25 +87,27 @@ RSpec.describe SchemesHelper do
end end
end end
include TagHelper
describe "display_scheme_attributes" do describe "display_scheme_attributes" do
let(:owning_organisation) {FactoryBot.create(:organisation, name: "Acme LTD Owning")} let(:owning_organisation) { FactoryBot.create(:organisation, name: "Acme LTD Owning") }
let(:managing_organisation) {FactoryBot.create(:organisation, name: "Acme LTD Managing")} let(:managing_organisation) { FactoryBot.create(:organisation, name: "Acme LTD Managing") }
let!(:scheme) { FactoryBot.create(:scheme, let!(:scheme) do
id: 19, FactoryBot.create(:scheme,
service_name: "Test service_name", id: 19,
sensitive: 0, service_name: "Test service_name",
scheme_type: 7, sensitive: 0,
registered_under_care_act: 3, scheme_type: 7,
owning_organisation: owning_organisation, registered_under_care_act: 3,
managing_organisation: managing_organisation, owning_organisation:,
arrangement_type: "V", managing_organisation:,
primary_client_group: "S", arrangement_type: "V",
has_other_client_group: 1, primary_client_group: "S",
secondary_client_group: "I", has_other_client_group: 1,
support_type: 4, secondary_client_group: "I",
intended_stay: "P", support_type: 4,
created_at: Time.zone.local(2022, 4, 1), intended_stay: "P",
) } created_at: Time.zone.local(2022, 4, 1))
end
let!(:scheme_where_managing_organisation_is_owning_organisation) { FactoryBot.create(:scheme, arrangement_type: "D") } let!(:scheme_where_managing_organisation_is_owning_organisation) { FactoryBot.create(:scheme, arrangement_type: "D") }
let(:support_user) { FactoryBot.create(:user, :support) } let(:support_user) { FactoryBot.create(:user, :support) }
let(:coordinator_user) { FactoryBot.create(:user, :data_coordinator) } let(:coordinator_user) { FactoryBot.create(:user, :data_coordinator) }

Loading…
Cancel
Save