Stub form start date in question tests

spec/models/form/lettings/questions/address_line1_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::AddressLine1, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/age1_known_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe Form::Lettings::Questions::Age1Known, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/beds_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::Beds, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/county_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::County, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/created_by_id_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::CreatedById, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/declaration_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::Declaration, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?)

spec/models/form/lettings/questions/ethnic_white_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::EthnicWhite, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/first_time_property_let_as_social_housing_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::FirstTimePropertyLetAsSocialHousing, t
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/gender_identity1_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe Form::Lettings::Questions::GenderIdentity1, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(page).to receive(:subsection).and_return(subsection)

spec/models/form/lettings/questions/hb_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::Hb, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/housingneeds_other_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::HousingneedsOther, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/irproduct_other_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::IrproductOther, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/is_carehome_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::IsCarehome, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/joint_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::Joint, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/layear_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::Layear, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/letting_allocation_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::LettingAllocation, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/location_id_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::LocationId, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_date).and_return(Time.zone.local(2022, 4, 1))

spec/models/form/lettings/questions/managing_organisation_spec.rb

@@ -5,9 +5,7 @@ RSpec.describe Form::Lettings::Questions::ManagingOrganisation, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
-  let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/nationality_all_group_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 RSpec.describe Form::Lettings::Questions::NationalityAllGroup, type: :model do
   subject(:question) { described_class.new(nil, nil, page) }
 
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/nationality_all_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 RSpec.describe Form::Lettings::Questions::NationalityAll, type: :model do
   subject(:question) { described_class.new(nil, nil, page) }
 
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/nationality_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 RSpec.describe Form::Lettings::Questions::Nationality, type: :model do
   subject(:question) { described_class.new(nil, nil, page) }
 
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/needs_type_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::NeedsType, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/net_income_known_spec.rb

@@ -1,7 +1,9 @@
 require "rails_helper"
 
 RSpec.describe Form::Lettings::Questions::NetIncomeKnown do
-  subject(:question) { described_class.new(nil, {}, nil) }
+  subject(:question) { described_class.new(nil, {}, page) }
+
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   describe "#id" do
     it "is net_income_known" do

spec/models/form/lettings/questions/offered_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 RSpec.describe Form::Lettings::Questions::Offered, type: :model do
   subject(:question) { described_class.new(nil, nil, page) }
 
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to be page

spec/models/form/lettings/questions/period_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 RSpec.describe Form::Lettings::Questions::Period, type: :model do
   subject(:question) { described_class.new(nil, nil, page) }
 
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has the correct hint" do
     expect(question.hint_text).to eq("Select how often the household is charged. This may be different to how often they pay.")

spec/models/form/lettings/questions/person_gender_identity_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::PersonGenderIdentity, type: :model do
   let(:page) { instance_double(Form::Page) }
   let(:person_index) { 2 }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(page).to receive(:subsection).and_return(subsection)

spec/models/form/lettings/questions/postcode_for_full_address_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::PostcodeForFullAddress, type: :model d
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/ppcodenk_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe Form::Lettings::Questions::Ppcodenk, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/previous_la_known_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe Form::Lettings::Questions::PreviousLaKnown, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/previous_let_type_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::PreviousLetType, type: :model do
 
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/previous_tenure_renewal_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 RSpec.describe Form::Lettings::Questions::PreviousTenureRenewal, type: :model do
   subject(:question) { described_class.new(nil, nil, page) }
 
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has the correct id" do
     expect(question.id).to eq("prevten")

spec/models/form/lettings/questions/previous_tenure_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 RSpec.describe Form::Lettings::Questions::PreviousTenure, type: :model do
   subject(:question) { described_class.new(nil, nil, page) }
 
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has the correct id" do
     expect(question.id).to eq("prevten")

spec/models/form/lettings/questions/property_reference_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::PropertyReference, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
   let(:lettings_log) { FactoryBot.create(:lettings_log) }
 
   it "has correct page" do

spec/models/form/lettings/questions/reason_renewal_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::ReasonRenewal, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/reason_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::Reason, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/reasonpref_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe Form::Lettings::Questions::Reasonpref, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/renewal_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::Renewal, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/rent_type_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::RentType, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/rsnvac_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::Rsnvac, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/scheme_id_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::SchemeId, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/sheltered_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::Sheltered, type: :model do
 
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/starter_tenancy_type_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::StarterTenancyType, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(page).to receive(:subsection).and_return(subsection)

spec/models/form/lettings/questions/startertenancy_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::Startertenancy, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(page).to receive(:subsection).and_return(subsection)

spec/models/form/lettings/questions/stock_owner_spec.rb

@@ -5,9 +5,7 @@ RSpec.describe Form::Lettings::Questions::StockOwner, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
-  let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/tenancy_length_affordable_rent_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::TenancyLengthAffordableRent, type: :mo
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/tenancy_length_intermediate_rent_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Form::Lettings::Questions::TenancyLengthIntermediateRent, type: :
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/tenancy_length_periodic_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::TenancyLengthPeriodic, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/tenancy_length_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 RSpec.describe Form::Lettings::Questions::TenancyLength, type: :model do
   subject(:question) { described_class.new(nil, nil, page) }
 
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/tenancy_other_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 RSpec.describe Form::Lettings::Questions::TenancyOther, type: :model do
   subject(:question) { described_class.new(nil, nil, page) }
 
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/tenancy_start_date_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::TenancyStartDate, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/tenancy_type_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::TenancyType, type: :model do
 
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/tenant_code_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::TenantCode, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/town_or_city_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::TownOrCity, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/uprn_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::Uprn, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/voiddate_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Form::Lettings::Questions::Voiddate, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)

spec/models/form/lettings/questions/waityear_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe Form::Lettings::Questions::Waityear, type: :model do
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
-  let(:form) { instance_double(Form) }
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) }
 
   before do
     allow(form).to receive(:start_year_after_2024?).and_return(false)

spec/models/form/lettings/questions/wheelchair_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe Form::Lettings::Questions::Wheelchair, type: :model do
 
   before do
     allow(page).to receive(:subsection).and_return(subsection)
-    allow(subsection).to receive(:form).and_return(instance_double(Form, start_year_after_2024?: false))
+    allow(subsection).to receive(:form).and_return(instance_double(Form, start_year_after_2024?: false, start_date: Time.zone.local(2023, 4, 1)))
   end
 
   it "has correct page" do
@@ -48,7 +48,7 @@ RSpec.describe Form::Lettings::Questions::Wheelchair, type: :model do
 
   context "with 2024 form" do
     before do
-      allow(subsection).to receive(:form).and_return(instance_double(Form, start_year_after_2024?: true))
+      allow(subsection).to receive(:form).and_return(instance_double(Form, start_year_after_2024?: true, start_date: Time.zone.local(2024, 4, 1)))
     end
 
     it "has the correct hint_text" do