Browse Source

feat: respond to PR comments

pull/1225/head
natdeanlewissoftwire 3 years ago
parent
commit
97f9e5a86c
  1. 4
      app/helpers/interruption_screen_helper.rb
  2. 2
      app/models/form/sales/questions/about_price_shared_ownership_value_check.rb

4
app/helpers/interruption_screen_helper.rb

@ -8,7 +8,7 @@ module InterruptionScreenHelper
pre_casing_value = lettings_log.form.get_question(argument["key"], lettings_log).answer_label(lettings_log)
pre_casing_value.downcase
elsif argument["currency"]
["£", ActionController::Base.helpers.number_to_currency(lettings_log.public_send(argument["key"]), delimiter: ",", format: "%n")].join("")
["£", number_to_currency(lettings_log.public_send(argument["key"]), delimiter: ",", format: "%n")].join("")
else
lettings_log.public_send(argument["key"])
end
@ -33,7 +33,7 @@ module InterruptionScreenHelper
value = if argument["label"]
lettings_log.form.get_question(argument["key"], lettings_log).answer_label(lettings_log).downcase
elsif argument["currency"]
["£", ActionController::Base.helpers.number_to_currency(lettings_log.public_send(argument["key"]), delimiter: ",", format: "%n")].join("")
["£", number_to_currency(lettings_log.public_send(argument["key"]), delimiter: ",", format: "%n")].join("")
else
lettings_log.public_send(argument["key"])
end

2
app/models/form/sales/questions/about_price_shared_ownership_value_check.rb

@ -3,7 +3,7 @@ class Form::Sales::Questions::AboutPriceSharedOwnershipValueCheck < ::Form::Ques
super
@id = "value_value_check"
@check_answer_label = "Purchase price confirmation"
@header = "Are you sure this is correct?"
@header = "Are you sure?"
@type = "interruption_screen"
@answer_options = {
"0" => { "value" => "Yes" },

Loading…
Cancel
Save