From 97cc0e1700cc64ac96a88fa1053898ea28bf5d3b Mon Sep 17 00:00:00 2001 From: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> Date: Thu, 5 Jan 2023 11:51:53 +0000 Subject: [PATCH] move hint text (#1146) --- app/models/form/sales/questions/previous_la_known.rb | 2 +- app/models/form/sales/questions/previous_postcode.rb | 2 +- app/models/form/sales/questions/previous_postcode_known.rb | 1 + app/models/form/sales/questions/prevloc.rb | 2 +- spec/models/form/sales/questions/previous_la_known_spec.rb | 4 ++++ .../form/sales/questions/previous_postcode_known_spec.rb | 4 ++++ spec/models/form/sales/questions/previous_postcode_spec.rb | 2 +- 7 files changed, 13 insertions(+), 4 deletions(-) diff --git a/app/models/form/sales/questions/previous_la_known.rb b/app/models/form/sales/questions/previous_la_known.rb index ffa9744aa..686a60e58 100644 --- a/app/models/form/sales/questions/previous_la_known.rb +++ b/app/models/form/sales/questions/previous_la_known.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::PreviousLaKnown < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @page = page - @hint_text = "" + @hint_text = "This is also known as the household’s 'last settled home'" @hidden_in_check_answers = { "depends_on" => [ { diff --git a/app/models/form/sales/questions/previous_postcode.rb b/app/models/form/sales/questions/previous_postcode.rb index ea4cb82ed..a5bb7c54a 100644 --- a/app/models/form/sales/questions/previous_postcode.rb +++ b/app/models/form/sales/questions/previous_postcode.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::PreviousPostcode < ::Form::Question @page = page @type = "text" @width = 5 - @hint_text = "This is also known as the household’s 'last settled home'" + @hint_text = "" @inferred_check_answers_value = { "condition" => { "ppcodenk" => 1, diff --git a/app/models/form/sales/questions/previous_postcode_known.rb b/app/models/form/sales/questions/previous_postcode_known.rb index 77da10446..7c85aabe5 100644 --- a/app/models/form/sales/questions/previous_postcode_known.rb +++ b/app/models/form/sales/questions/previous_postcode_known.rb @@ -10,6 +10,7 @@ class Form::Sales::Questions::PreviousPostcodeKnown < ::Form::Question @conditional_for = { "ppostcode_full" => [0], } + @hint_text = "This is also known as the household’s 'last settled home'" end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/prevloc.rb b/app/models/form/sales/questions/prevloc.rb index 0c7970ff6..ea7b9cf3b 100644 --- a/app/models/form/sales/questions/prevloc.rb +++ b/app/models/form/sales/questions/prevloc.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Prevloc < ::Form::Question @type = "select" @answer_options = ANSWER_OPTIONS @page = page - @hint_text = "This is also known as the household’s 'last settled home'" + @hint_text = "" @inferred_check_answers_value = { "condition" => { "previous_la_known" => 0, diff --git a/spec/models/form/sales/questions/previous_la_known_spec.rb b/spec/models/form/sales/questions/previous_la_known_spec.rb index 00ada47b2..9e369af0a 100644 --- a/spec/models/form/sales/questions/previous_la_known_spec.rb +++ b/spec/models/form/sales/questions/previous_la_known_spec.rb @@ -58,4 +58,8 @@ RSpec.describe Form::Sales::Questions::PreviousLaKnown, type: :model do "prevloc" => [1], }) end + + it "has the correct hint" do + expect(question.hint_text).to eq("This is also known as the household’s 'last settled home'") + end end diff --git a/spec/models/form/sales/questions/previous_postcode_known_spec.rb b/spec/models/form/sales/questions/previous_postcode_known_spec.rb index 887aa9abe..6febe027f 100644 --- a/spec/models/form/sales/questions/previous_postcode_known_spec.rb +++ b/spec/models/form/sales/questions/previous_postcode_known_spec.rb @@ -43,4 +43,8 @@ RSpec.describe Form::Sales::Questions::PreviousPostcodeKnown, type: :model do "ppostcode_full" => [0], }) end + + it "has the correct hint" do + expect(question.hint_text).to eq("This is also known as the household’s 'last settled home'") + end end diff --git a/spec/models/form/sales/questions/previous_postcode_spec.rb b/spec/models/form/sales/questions/previous_postcode_spec.rb index 73435ed11..cb763dc81 100644 --- a/spec/models/form/sales/questions/previous_postcode_spec.rb +++ b/spec/models/form/sales/questions/previous_postcode_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::PreviousPostcode, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("This is also known as the household’s 'last settled home'") + expect(question.hint_text).to eq("") end it "has the correct width" do