From 976d0f6e732caeea7b5ac3d55f3fc92f95258455 Mon Sep 17 00:00:00 2001 From: Robert Sullivan Date: Thu, 21 Mar 2024 09:47:33 +0000 Subject: [PATCH] CLDC-3329: Update hint text for schemes question (#2336) --- .../form/lettings/questions/scheme_id.rb | 10 +++++- .../form/lettings/questions/scheme_id_spec.rb | 31 +++++++++++++++++-- 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/app/models/form/lettings/questions/scheme_id.rb b/app/models/form/lettings/questions/scheme_id.rb index cc849bab9..4c533f43a 100644 --- a/app/models/form/lettings/questions/scheme_id.rb +++ b/app/models/form/lettings/questions/scheme_id.rb @@ -3,7 +3,6 @@ class Form::Lettings::Questions::SchemeId < ::Form::Question super("scheme_id", hsh, page) @check_answer_label = "Scheme name" @header = "What scheme is this log for?" - @hint_text = "Enter postcode or scheme name" @type = "select" @answer_options = answer_options @top_guidance_partial = "finding_scheme" @@ -49,6 +48,15 @@ class Form::Lettings::Questions::SchemeId < ::Form::Question lettings_log.form.get_question("postcode_full", nil).label_from_value(lettings_log.postcode_full) unless lettings_log.scheme_has_multiple_locations? end + def hint_text + if form.start_year_after_2024? + "Enter postcode or scheme name.

+ A supported housing scheme provides shared or self-contained housing for a particular client group, for example younger or vulnerable people." + else + "Enter postcode or scheme name" + end + end + private def supported_housing_selected?(lettings_log) diff --git a/spec/models/form/lettings/questions/scheme_id_spec.rb b/spec/models/form/lettings/questions/scheme_id_spec.rb index a9a7887be..c0cf6fa3b 100644 --- a/spec/models/form/lettings/questions/scheme_id_spec.rb +++ b/spec/models/form/lettings/questions/scheme_id_spec.rb @@ -5,7 +5,15 @@ RSpec.describe Form::Lettings::Questions::SchemeId, type: :model do let(:question_id) { nil } let(:question_definition) { nil } - let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) } + let(:page) { instance_double(Form::Page) } + let(:subsection) { instance_double(Form::Subsection) } + let(:form) { instance_double(Form, start_date: Time.zone.local(2023, 4, 1)) } + + before do + allow(page).to receive(:subsection).and_return(subsection) + allow(subsection).to receive(:form).and_return(form) + allow(form).to receive(:start_year_after_2024?).and_return(false) + end it "has correct page" do expect(question.page).to eq(page) @@ -27,8 +35,25 @@ RSpec.describe Form::Lettings::Questions::SchemeId, type: :model do expect(question.type).to eq("select") end - it "has the correct hint_text" do - expect(question.hint_text).to eq("Enter postcode or scheme name") + context "when 2023" do + before do + allow(form).to receive(:start_year_after_2024?).and_return(false) + end + + it "has the correct hint_text" do + expect(question.hint_text).to eq("Enter postcode or scheme name") + end + end + + context "when 2024" do + before do + allow(form).to receive(:start_year_after_2024?).and_return(true) + end + + it "has the correct hint_text" do + expect(question.hint_text).to eq("Enter postcode or scheme name.

+ A supported housing scheme provides shared or self-contained housing for a particular client group, for example younger or vulnerable people.") + end end it "has the correct conditional_for" do