From 9730eea1c59b56e1706a766ed3e7579668d9f5c3 Mon Sep 17 00:00:00 2001 From: Kat Date: Mon, 29 Jan 2024 14:09:57 +0000 Subject: [PATCH] Do not trigger soft validation for 2024 --- app/models/validations/sales/soft_validations.rb | 1 + .../validations/sales/soft_validations_spec.rb | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/app/models/validations/sales/soft_validations.rb b/app/models/validations/sales/soft_validations.rb index d8d957988..fce544754 100644 --- a/app/models/validations/sales/soft_validations.rb +++ b/app/models/validations/sales/soft_validations.rb @@ -84,6 +84,7 @@ module Validations::Sales::SoftValidations end def shared_ownership_deposit_invalid? + return unless saledate && collection_start_year <= 2023 return unless mortgage || mortgageused == 2 || mortgageused == 3 return unless cashdis || !is_type_discount? return unless deposit && value && equity diff --git a/spec/models/validations/sales/soft_validations_spec.rb b/spec/models/validations/sales/soft_validations_spec.rb index 4d0c1024a..6b9817277 100644 --- a/spec/models/validations/sales/soft_validations_spec.rb +++ b/spec/models/validations/sales/soft_validations_spec.rb @@ -400,6 +400,10 @@ RSpec.describe Validations::Sales::SoftValidations do end context "when validating shared ownership deposit" do + before do + record.saledate = Time.zone.local(2023, 4, 3) + end + it "returns false if MORTGAGE + DEPOSIT + CASHDIS are equal VALUE * EQUITY/100" do record.mortgage = 1000 record.deposit = 1000 @@ -501,6 +505,18 @@ RSpec.describe Validations::Sales::SoftValidations do expect(record) .to be_shared_ownership_deposit_invalid end + + it "returns false if startyear is after 2024" do + record.saledate = Time.zone.local(2025, 1, 1) + record.mortgage = 1000 + record.deposit = 1000 + record.cashdis = 1000 + record.value = 4323 + record.equity = 100 + + expect(record) + .not_to be_shared_ownership_deposit_invalid + end end end