From 96b93c427c46a21e58037a855638ff5d9f63e650 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Thu, 20 Feb 2025 21:33:51 +0000
Subject: [PATCH] separate out tests

---
 ...culate_invalid_reasonpref_dontknow_spec.rb | 30 ++++++++++++-------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/spec/lib/tasks/recalculate_invalid_reasonpref_dontknow_spec.rb b/spec/lib/tasks/recalculate_invalid_reasonpref_dontknow_spec.rb
index 50350bc94..f947a08d1 100644
--- a/spec/lib/tasks/recalculate_invalid_reasonpref_dontknow_spec.rb
+++ b/spec/lib/tasks/recalculate_invalid_reasonpref_dontknow_spec.rb
@@ -19,36 +19,44 @@ RSpec.describe "recalculate_invalid_reasonpref_dontknow" do
   end
   let(:valid_logs) { create_list(:lettings_log, 3, :completed, reasonpref: 1, rp_dontknow: 0, rp_homeless: 1, rp_insan_unsat: 1, rp_medwel: rand(2), rp_hardship: rand(2)) }
 
-  it "updates the right logs from 2024/25 with invalid rp_dontknow values" do
+  it "updates the logs from 2024/25 with invalid rp_dontknow values" do
     invalid_logs.each do |log|
       expect(log.reasonpref).to eq(1)
       expect(log.rp_dontknow).to eq(1)
       expect(log.rp_homeless).to eq(1)
     end
-    pre_2024_invalid_logs.each do |log|
+    task.invoke
+    invalid_logs.each do |log|
+      log.reload
       expect(log.reasonpref).to eq(1)
-      expect(log.rp_dontknow).to eq(1)
+      expect(log.rp_dontknow).to eq(0)
       expect(log.rp_homeless).to eq(1)
     end
-    valid_logs.each do |log|
+  end
+
+  it "does not update the logs pre 2024 with invalid rp_dontknow values" do
+    pre_2024_invalid_logs.each do |log|
       expect(log.reasonpref).to eq(1)
-      expect(log.rp_dontknow).to eq(0)
+      expect(log.rp_dontknow).to eq(1)
       expect(log.rp_homeless).to eq(1)
-      expect(log.rp_insan_unsat).to eq(1)
     end
     task.invoke
-    invalid_logs.each do |log|
+    pre_2024_invalid_logs.each do |log|
       log.reload
       expect(log.reasonpref).to eq(1)
-      expect(log.rp_dontknow).to eq(0)
+      expect(log.rp_dontknow).to eq(1)
       expect(log.rp_homeless).to eq(1)
     end
-    pre_2024_invalid_logs.each do |log|
-      log.reload
+  end
+
+  it "does not update the logs with valid rp_dontknow values" do
+    valid_logs.each do |log|
       expect(log.reasonpref).to eq(1)
-      expect(log.rp_dontknow).to eq(1)
+      expect(log.rp_dontknow).to eq(0)
       expect(log.rp_homeless).to eq(1)
+      expect(log.rp_insan_unsat).to eq(1)
     end
+    task.invoke
     valid_logs.each do |log|
       log.reload
       expect(log.reasonpref).to eq(1)