Browse Source

validate null for startdate

remotes/origin/bulk-upload-errors-integration
Phil Lee 3 years ago
parent
commit
969d60db6e
  1. 3
      app/services/bulk_upload/lettings/row_parser.rb
  2. 12
      spec/services/bulk_upload/lettings/row_parser_spec.rb

3
app/services/bulk_upload/lettings/row_parser.rb

@ -139,6 +139,9 @@ class BulkUpload::Lettings::RowParser
validates :field_1, presence: true, inclusion: { in: (1..12).to_a }
validates :field_4, presence: { if: proc { [1, 3, 5, 7, 9, 11].include?(field_1) } }
validates :field_96, presence: true
validates :field_97, presence: true
validates :field_98, presence: true
def attribute_set
@attribute_set ||= instance_variable_get(:@attributes)

12
spec/services/bulk_upload/lettings/row_parser_spec.rb

@ -98,6 +98,18 @@ RSpec.describe BulkUpload::Lettings::RowParser do
end
end
describe "fields 96, 97, 98 => startdate" do
context "when any one of these fields is blank" do
let(:attributes) { { field_96: nil, field_97: nil, field_98: nil } }
it "returns an error" do
expect(parser.errors[:field_96]).to be_present
expect(parser.errors[:field_97]).to be_present
expect(parser.errors[:field_98]).to be_present
end
end
end
describe "#field_134" do
context "when an unpermitted value" do
let(:attributes) { { field_134: 3 } }

Loading…
Cancel
Save