From 9463410c03195488a6aff4406945df947bf60ff8 Mon Sep 17 00:00:00 2001 From: Kat Date: Wed, 3 May 2023 11:38:47 +0100 Subject: [PATCH] Update which field we add the errors to --- app/controllers/merge_requests_controller.rb | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/controllers/merge_requests_controller.rb b/app/controllers/merge_requests_controller.rb index 4319d561d..17959e264 100644 --- a/app/controllers/merge_requests_controller.rb +++ b/app/controllers/merge_requests_controller.rb @@ -138,11 +138,8 @@ private end when "confirm_telephone_number" if merge_request_params[:telephone_number_correct].blank? - if @merge_request.absorbing_organisation.phone.present? - @merge_request.errors.add(:telephone_number_correct, :blank) - else - @merge_request.errors.add(:telephone_number_correct, :invalid) - end + @merge_request.errors.add(:telephone_number_correct, :blank) if @merge_request.absorbing_organisation.phone.present? + @merge_request.errors.add(:new_telephone_number, :blank) if @merge_request.absorbing_organisation.phone.blank? end when "new_organisation_name" @merge_request.errors.add(:new_organisation_name, :blank) if merge_request_params[:new_organisation_name].blank?