From 942ffc0a35b94abda67c4dc89d359bc90a151b11 Mon Sep 17 00:00:00 2001 From: Kat Date: Wed, 25 Oct 2023 12:38:31 +0100 Subject: [PATCH] Add recalculate lar values task --- lib/tasks/recalculate_lar_values.rake | 13 +++ spec/lib/tasks/recalculate_lar_values_spec.rb | 100 ++++++++++++++++++ 2 files changed, 113 insertions(+) create mode 100644 lib/tasks/recalculate_lar_values.rake create mode 100644 spec/lib/tasks/recalculate_lar_values_spec.rb diff --git a/lib/tasks/recalculate_lar_values.rake b/lib/tasks/recalculate_lar_values.rake new file mode 100644 index 000000000..f08a38726 --- /dev/null +++ b/lib/tasks/recalculate_lar_values.rake @@ -0,0 +1,13 @@ +desc "Forces to recalculate lar values for affordable rent types and clears irrelevant lar values" +task recalculate_lar_values: :environment do + LettingsLog.exportable.where(rent_type: [1, 2], lar: nil).each do |log| # lar was never set + Rails.logger.info("Could not update lar for LettingsLog #{log.id}") unless log.update(values_updated_at: Time.zone.now) + end + LettingsLog.exportable.where(rent_type: 1).where.not(lar: 2).each do |log| # lar was set wrong + Rails.logger.info("Could not update lar for LettingsLog #{log.id}") unless log.update(values_updated_at: Time.zone.now) + end + LettingsLog.exportable.where(rent_type: 2).where.not(lar: 1).each do |log| # lar was set wrong + Rails.logger.info("Could not update lar for LettingsLog #{log.id}") unless log.update(values_updated_at: Time.zone.now) + end + LettingsLog.exportable.where.not(rent_type: [1, 2]).where.not(lar: nil).update_all(lar: nil) # lar was set to 2 but should never have been set +end diff --git a/spec/lib/tasks/recalculate_lar_values_spec.rb b/spec/lib/tasks/recalculate_lar_values_spec.rb new file mode 100644 index 000000000..7831e34d2 --- /dev/null +++ b/spec/lib/tasks/recalculate_lar_values_spec.rb @@ -0,0 +1,100 @@ +require "rails_helper" +require "rake" + +RSpec.describe "recalculate_lar_values" do + describe ":recalculate_lar_values", type: :task do + subject(:task) { Rake::Task["recalculate_lar_values"] } + + before do + Rake.application.rake_require("tasks/recalculate_lar_values") + Rake::Task.define_task(:environment) + task.reenable + end + + context "when the rake task is run" do + let!(:lettings_log) { create(:lettings_log, :completed, values_updated_at: nil) } + + it "updates lar to nil if it's not afordable rent or london afordable rent and lar is 1 but does not set it to export" do + lettings_log.lar = 1 + lettings_log.rent_type = 3 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.lar).to eq(nil) + expect(lettings_log.values_updated_at).to be_nil + end + + it "updates lar to nil if it's not afordable rent or london afordable rent and lar is 2 but does not set it to export" do + lettings_log.lar = 2 + lettings_log.rent_type = 4 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.lar).to eq(nil) + expect(lettings_log.values_updated_at).to be_nil + end + + it "does not update lar if it's not london afordable rent or affordable rent and lar is nil" do + lettings_log.lar = nil + lettings_log.rent_type = 3 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.lar).to eq(nil) + expect(lettings_log.values_updated_at).to be_nil + end + + it "updates lar to 1 if it's london afordable rent and lar is currently nil" do + lettings_log.lar = nil + lettings_log.rent_type = 2 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.lar).to eq(1) + expect(lettings_log.values_updated_at).not_to be_nil + end + + it "updates lar to 1 if it's london afordable rent and lar is currently 2" do + lettings_log.lar = 2 + lettings_log.rent_type = 2 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.lar).to eq(1) + expect(lettings_log.values_updated_at).not_to be_nil + end + + it "updates lar to 2 if it's afordable rent and lar is currently nil" do + lettings_log.lar = nil + lettings_log.rent_type = 1 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.lar).to eq(2) + expect(lettings_log.values_updated_at).not_to be_nil + end + + it "updates lar to 2 if it's afordable rent and lar is currently 1" do + lettings_log.lar = 1 + lettings_log.rent_type = 1 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.lar).to eq(2) + expect(lettings_log.values_updated_at).not_to be_nil + end + + it "does not update lar if a different validation is triggering" do + lettings_log.lar = 1 + lettings_log.rent_type = 1 + lettings_log.postcode_full = "invalid" + lettings_log.save!(validate: false) + expect(Rails.logger).to receive(:info).with("Could not update lar for LettingsLog #{lettings_log.id}") + task.invoke + lettings_log.reload + expect(lettings_log.lar).to eq(1) + expect(lettings_log.values_updated_at).to be_nil + end + end + end +end