Browse Source

remove duplicate method and use existing version

pull/1235/head
Arthur Campbell 3 years ago
parent
commit
8b5533bc00
  1. 4
      app/models/sales_log.rb
  2. 2
      app/models/validations/sales/financial_validations.rb

4
app/models/sales_log.rb

@ -136,10 +136,6 @@ class SalesLog < Log
type == 18 type == 18
end end
def is_older_persons_shared_ownership?
type == 24
end
def ppostcode_full=(postcode) def ppostcode_full=(postcode)
if postcode if postcode
super UKPostcode.parse(postcode).to_s super UKPostcode.parse(postcode).to_s

2
app/models/validations/sales/financial_validations.rb

@ -37,7 +37,7 @@ module Validations::Sales::FinancialValidations
end end
def validate_percentage_owned_not_too_much_if_older_person(record) def validate_percentage_owned_not_too_much_if_older_person(record)
return unless record.is_older_persons_shared_ownership? && record.stairowned return unless record.old_persons_shared_ownership? && record.stairowned
if record.stairowned > 75 if record.stairowned > 75
record.errors.add :stairowned, I18n.t("validations.financial.staircasing.older_person_percentage_owned_maximum_75") record.errors.add :stairowned, I18n.t("validations.financial.staircasing.older_person_percentage_owned_maximum_75")

Loading…
Cancel
Save