From 8ab5b5dec3498d0565b22d3e2b5ca885c567ce84 Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Tue, 7 Nov 2023 09:22:03 +0000 Subject: [PATCH] feat: skip over logs that fail validations --- lib/tasks/import_address_from_csv.rake | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/lib/tasks/import_address_from_csv.rake b/lib/tasks/import_address_from_csv.rake index 8d0c1de9e..400b8ccde 100644 --- a/lib/tasks/import_address_from_csv.rake +++ b/lib/tasks/import_address_from_csv.rake @@ -55,8 +55,11 @@ namespace :data_import do lettings_log.send("process_postcode_changes!") lettings_log.values_updated_at = Time.zone.now - lettings_log.save! - Rails.logger.info("Updated lettings log #{lettings_log_id}, with address: #{[lettings_log.address_line1, lettings_log.address_line2, lettings_log.town_or_city, lettings_log.county, lettings_log.postcode_full].join(', ')}") + if lettings_log.save + Rails.logger.info("Updated lettings log #{lettings_log_id}, with address: #{[lettings_log.address_line1, lettings_log.address_line2, lettings_log.town_or_city, lettings_log.county, lettings_log.postcode_full].join(', ')}") + else + Rails.logger.error("Validation failed for lettings log with ID #{lettings_log.id}: #{lettings_log.errors.full_messages.join(', ')}}") + end end end @@ -116,8 +119,11 @@ namespace :data_import do sales_log.send("process_postcode_changes!") sales_log.values_updated_at = Time.zone.now - sales_log.save! - Rails.logger.info("Updated sales log #{sales_log_id}, with address: #{[sales_log.address_line1, sales_log.address_line2, sales_log.town_or_city, sales_log.county, sales_log.postcode_full].join(', ')}") + if sales_log.save + Rails.logger.info("Updated sales log #{sales_log_id}, with address: #{[sales_log.address_line1, sales_log.address_line2, sales_log.town_or_city, sales_log.county, sales_log.postcode_full].join(', ')}") + else + Rails.logger.error("Validation failed for sales log with ID #{sales_log_id.id}: #{lettings_log.errors.full_messages.join(', ')}}") + end end end end