CLDC-4173: test date updates

spec/models/form/sales/pages/building_height_class_spec.rb

@@ -7,9 +7,8 @@ RSpec.describe Form::Sales::Pages::BuildingHeightClass, type: :model do
 
   let(:page_id) { nil }
   let(:page_definition) { nil }
-  let(:start_date) { collection_start_date_for_year(2026) }
-  let(:form) { instance_double(Form, start_date:) }
-  let(:subsection) { instance_double(Form::Subsection, form:) }
+  let(:subsection) { instance_double(Form::Subsection, form: instance_double(Form, start_date: current_collection_start_date)) }
+  let(:sales_log) { FactoryBot.create(:sales_log, :completed) }
 
   it "has correct subsection" do
     expect(page.subsection).to eq(subsection)

spec/models/form/sales/questions/building_height_class_spec.rb

@@ -7,10 +7,7 @@ RSpec.describe Form::Sales::Questions::BuildingHeightClass, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:start_date) { collection_start_date_for_year(2026) }
-  let(:form) { instance_double(Form, start_date:) }
-  let(:subsection) { instance_double(Form::Subsection, form:) }
-  let(:page) { instance_double(Form::Page, subsection:) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: current_collection_start_date))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)