From 890b2c07da1685534f01e16a74f6162331ac56cb Mon Sep 17 00:00:00 2001 From: Kat Date: Wed, 22 Mar 2023 09:07:48 +0000 Subject: [PATCH] Do not backfill information about people indexed 7 and higher --- app/services/imports/sales_logs_import_service.rb | 2 +- .../imports/sales_logs_import_service_spec.rb | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/app/services/imports/sales_logs_import_service.rb b/app/services/imports/sales_logs_import_service.rb index cf0cf416d..e6f735b3e 100644 --- a/app/services/imports/sales_logs_import_service.rb +++ b/app/services/imports/sales_logs_import_service.rb @@ -555,7 +555,7 @@ module Imports end # other household members characteristics - (2..attributes["hhmemb"]).each do |index| + (2..[attributes["hhmemb"], 6].min).each do |index| attributes["age#{index}_known"] ||= 1 attributes["sex#{index}"] ||= "R" attributes["ecstat#{index}"] ||= 10 diff --git a/spec/services/imports/sales_logs_import_service_spec.rb b/spec/services/imports/sales_logs_import_service_spec.rb index 5ce2d561a..7d33ee538 100644 --- a/spec/services/imports/sales_logs_import_service_spec.rb +++ b/spec/services/imports/sales_logs_import_service_spec.rb @@ -593,6 +593,20 @@ RSpec.describe Imports::SalesLogsImportService do end end + xcontext "when there is information about 7 people" do + let(:sales_log_id) { "shared_ownership_sales_log" } + + before do + sales_log_xml.at_xpath("//xmlns:P7Age").content = "22" + sales_log_xml.at_xpath("//xmlns:LiveInOther").content = "10" + end + + it "does not try to save information about person 7" do + expect { sales_log_service.send(:create_log, sales_log_xml) } + .not_to raise_error + end + end + context "and it has an invalid record with invalid contracts exchange date" do let(:sales_log_id) { "shared_ownership_sales_log" }