From 87d3d2acaf7cad5ce2456ed5569af11cd83316a6 Mon Sep 17 00:00:00 2001 From: Kat Date: Thu, 29 Feb 2024 14:58:20 +0000 Subject: [PATCH] Display managing org for sales correctly in CYA --- .../sales/questions/managing_organisation.rb | 2 +- .../questions/managing_organisation_spec.rb | 16 ---------------- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/app/models/form/sales/questions/managing_organisation.rb b/app/models/form/sales/questions/managing_organisation.rb index b05ba88db..a0e8f2c28 100644 --- a/app/models/form/sales/questions/managing_organisation.rb +++ b/app/models/form/sales/questions/managing_organisation.rb @@ -59,7 +59,7 @@ class Form::Sales::Questions::ManagingOrganisation < ::Form::Question end def hidden_in_check_answers?(log, user = nil) - user.nil? || !user.support? || !@page.routed_to?(log, user) + user.nil? || !@page.routed_to?(log, user) end def enabled diff --git a/spec/models/form/sales/questions/managing_organisation_spec.rb b/spec/models/form/sales/questions/managing_organisation_spec.rb index f708d7d74..69bdab4af 100644 --- a/spec/models/form/sales/questions/managing_organisation_spec.rb +++ b/spec/models/form/sales/questions/managing_organisation_spec.rb @@ -185,22 +185,6 @@ RSpec.describe Form::Sales::Questions::ManagingOrganisation, type: :model do allow(page).to receive(:routed_to?).and_return(true) end - context "when user is non support" do - let(:user) { create(:user) } - - it "is hidden in check answers" do - expect(question.hidden_in_check_answers?(nil, user)).to be true - end - end - - context "when user is support" do - let(:user) { create(:user, :support) } - - it "is not hidden in check answers" do - expect(question.hidden_in_check_answers?(nil, user)).to be false - end - end - context "when user not provided" do it "is hidden in check answers" do expect(question.hidden_in_check_answers?(nil)).to be true