From 87a1b037b38aceb2bf3a11cd00033bf596a88c40 Mon Sep 17 00:00:00 2001
From: oscar-richardson-softwire <oscar.richardson@softwire.com>
Date: Fri, 27 Feb 2026 14:32:20 +0000
Subject: [PATCH] Add details_known to tests

---
 spec/factories/lettings_log.rb                  | 11 -----------
 spec/models/lettings_log_derived_fields_spec.rb | 14 ++++++--------
 2 files changed, 6 insertions(+), 19 deletions(-)

diff --git a/spec/factories/lettings_log.rb b/spec/factories/lettings_log.rb
index a8ff9576d..38f066bda 100644
--- a/spec/factories/lettings_log.rb
+++ b/spec/factories/lettings_log.rb
@@ -14,17 +14,6 @@ FactoryBot.define do
       end
     end
 
-    after(:build) do |log|
-      if log.hhmemb
-        (2..log.hhmemb).each do |i|
-          setter = "details_known_#{i}="
-          getter = "details_known_#{i}"
-
-          log.public_send(setter, 0) if log.public_send(getter).nil?
-        end
-      end
-    end
-
     trait :setup_completed do
       startdate_today
       renewal { 0 }
diff --git a/spec/models/lettings_log_derived_fields_spec.rb b/spec/models/lettings_log_derived_fields_spec.rb
index 8cce67d85..42793df26 100644
--- a/spec/models/lettings_log_derived_fields_spec.rb
+++ b/spec/models/lettings_log_derived_fields_spec.rb
@@ -1602,8 +1602,7 @@ RSpec.describe LettingsLog, type: :model do
       end
 
       context "when there are no existing relationships" do
-        # `relat2` is "P" by default when creating a lettings log from the factory, so we explicitly set it to `nil`.
-        let(:log) { create(:lettings_log, :completed, hhmemb: 6, relat2: nil, relat3: "X", relat4: "X", relat5: "R") }
+        let(:log) { create(:lettings_log, :in_progress, hhmemb: 6, details_known_2: 0, details_known_3: 0, details_known_4: 0, details_known_5: 0, details_known_6: 0, relat2: nil, relat3: "X", relat4: "X", relat5: "R") }
 
         context "when a new relationship is added" do
           before do
@@ -1624,7 +1623,7 @@ RSpec.describe LettingsLog, type: :model do
       end
 
       context "when there is an existing relationship" do
-        let(:log) { create(:lettings_log, :completed, hhmemb: 6, relat2: "X", relat3: "P", relat4: "R", relat5: "X") }
+        let(:log) { create(:lettings_log, :in_progress, hhmemb: 6, details_known_2: 0, details_known_3: 0, details_known_4: 0, details_known_5: 0, details_known_6: 0, relat2: "X", relat3: "P", relat4: "R", relat5: "X") }
 
         context "when a new relationship is added" do
           before do
@@ -1662,7 +1661,7 @@ RSpec.describe LettingsLog, type: :model do
       end
 
       context "when more than one relationship is set" do
-        let(:log) { create(:lettings_log, :completed, relat2: "X", relat3: "X", relat4: "R", relat5: "X") }
+        let(:log) { create(:lettings_log, :in_progress, hhmemb: 6, details_known_2: 0, details_known_3: 0, details_known_4: 0, details_known_5: 0, details_known_6: 0, relat2: "X", relat3: "X", relat4: "R", relat5: "X") }
 
         before do
           log.relat2 = "P"
@@ -1694,8 +1693,7 @@ RSpec.describe LettingsLog, type: :model do
       end
 
       context "when there are no existing relationships" do
-        # `relat2` is "P" by default when creating a lettings log from the factory, so we explicitly set it to `nil`.
-        let(:log) { create(:lettings_log, :completed, hhmemb: 6, relat2: nil, relat3: "X", relat4: "X", relat5: "R") }
+        let(:log) { create(:lettings_log, :in_progress, hhmemb: 6, details_known_2: 0, details_known_3: 0, details_known_4: 0, details_known_5: 0, details_known_6: 0, relat3: "X", relat4: "X", relat5: "R") }
 
         context "when a new relationship is added" do
           before do
@@ -1761,7 +1759,7 @@ RSpec.describe LettingsLog, type: :model do
       end
 
       context "when there is an existing relationship" do
-        let(:log) { create(:lettings_log, :completed, hhmemb: 6, relat2: "X", relat3: "P", relat4: "R", relat5: "X") }
+        let(:log) { create(:lettings_log, :completed, hhmemb: 6, details_known_2: 0, details_known_3: 0, details_known_4: 0, details_known_5: 0, details_known_6: 0, relat2: "X", relat3: "P", relat4: "R", relat5: "X") }
 
         context "and a new relationship is added to an earlier person than the existing one" do
           before do
@@ -1878,7 +1876,7 @@ RSpec.describe LettingsLog, type: :model do
       end
 
       context "when more than one relationship is set" do
-        let(:log) { create(:lettings_log, :completed, hhmemb: 6, relat2: "X", relat3: "X", relat4: "R", relat5: "X") }
+        let(:log) { create(:lettings_log, :completed, hhmemb: 6, details_known_2: 0, details_known_3: 0, details_known_4: 0, details_known_5: 0, details_known_6: 0, relat2: "X", relat3: "X", relat4: "R", relat5: "X") }
 
         before do
           log.relat2 = "P"