From 879c9d0e8259ff1ee7fa405dd7b2aca8402e49f2 Mon Sep 17 00:00:00 2001
From: Phil Lee <asmega@users.noreply.github.com>
Date: Mon, 6 Feb 2023 12:54:22 +0000
Subject: [PATCH] bulk upload validate start date for given window

---
 app/models/bulk_upload.rb                     |  8 +++++
 app/models/form.rb                            |  4 +++
 app/models/form_handler.rb                    |  8 +++++
 .../bulk_upload/lettings/row_parser.rb        | 18 ++++++++++
 .../bulk_upload/lettings/row_parser_spec.rb   | 36 +++++++++++++++++++
 5 files changed, 74 insertions(+)

diff --git a/app/models/bulk_upload.rb b/app/models/bulk_upload.rb
index 56e10f399..89c13ee7b 100644
--- a/app/models/bulk_upload.rb
+++ b/app/models/bulk_upload.rb
@@ -22,6 +22,14 @@ class BulkUpload < ApplicationRecord
     end
   end
 
+  def form
+    @form ||= if lettings?
+                FormHandler.instance.lettings_form_for_start_year(year)
+              else
+                FormHandler.instance.sales_form_for_start_year(year)
+              end
+  end
+
 private
 
   def generate_identifier
diff --git a/app/models/form.rb b/app/models/form.rb
index 179c56526..32e7ec7de 100644
--- a/app/models/form.rb
+++ b/app/models/form.rb
@@ -236,4 +236,8 @@ class Form
   def inspect
     "#<#{self.class} @type=#{type} @name=#{name}>"
   end
+
+  def valid_start_date_for_form?(start_date)
+    start_date >= self.start_date && start_date <= end_date
+  end
 end
diff --git a/app/models/form_handler.rb b/app/models/form_handler.rb
index 098a7b429..f4e4acff9 100644
--- a/app/models/form_handler.rb
+++ b/app/models/form_handler.rb
@@ -45,6 +45,14 @@ class FormHandler
     forms
   end
 
+  def lettings_form_for_start_year(year)
+    lettings_forms.values.find { |form| form.start_date.year == year }
+  end
+
+  def sales_form_for_start_year(year)
+    sales_forms.values.find { |form| form.start_date.year == year }
+  end
+
   def form_name_from_start_year(year, type)
     form_mappings = { 0 => "current_#{type}", 1 => "previous_#{type}", -1 => "next_#{type}" }
     form_mappings[current_collection_start_year - year]
diff --git a/app/services/bulk_upload/lettings/row_parser.rb b/app/services/bulk_upload/lettings/row_parser.rb
index 1182f4b85..e63bba268 100644
--- a/app/services/bulk_upload/lettings/row_parser.rb
+++ b/app/services/bulk_upload/lettings/row_parser.rb
@@ -150,6 +150,7 @@ class BulkUpload::Lettings::RowParser
 
     validate_data_types
     validate_nulls
+    validate_relevant_collection_window
 
     log.valid?
 
@@ -167,6 +168,23 @@ class BulkUpload::Lettings::RowParser
 
 private
 
+  def validate_relevant_collection_window
+    return unless start_date
+    return unless bulk_upload.form
+
+    unless bulk_upload.form.valid_start_date_for_form?(start_date)
+      errors.add(:field_96, I18n.t("validations.date.outside_collection_window"))
+      errors.add(:field_97, I18n.t("validations.date.outside_collection_window"))
+      errors.add(:field_98, I18n.t("validations.date.outside_collection_window"))
+    end
+  end
+
+  def start_date
+    Date.parse("20#{field_98}-#{field_97}-#{field_96}")
+  rescue StandardError
+    nil
+  end
+
   def attribute_set
     @attribute_set ||= instance_variable_get(:@attributes)
   end
diff --git a/spec/services/bulk_upload/lettings/row_parser_spec.rb b/spec/services/bulk_upload/lettings/row_parser_spec.rb
index 8b9ff5102..2673a4cbd 100644
--- a/spec/services/bulk_upload/lettings/row_parser_spec.rb
+++ b/spec/services/bulk_upload/lettings/row_parser_spec.rb
@@ -255,6 +255,42 @@ RSpec.describe BulkUpload::Lettings::RowParser do
         let(:attributes) { { bulk_upload:, field_96: nil, field_97: nil, field_98: nil } }
 
         it "returns an error" do
+          parser.valid?
+
+          expect(parser.errors[:field_96]).to be_present
+          expect(parser.errors[:field_97]).to be_present
+          expect(parser.errors[:field_98]).to be_present
+        end
+      end
+
+      context "when inside of collection year" do
+        let(:attributes) { { bulk_upload:, field_96: "1", field_97: "10", field_98: "22" } }
+
+        let(:bulk_upload) { create(:bulk_upload, :lettings, user:, year: 2022) }
+
+        it "does not return errors" do
+          parser.valid?
+
+          expect(parser.errors[:field_96]).not_to be_present
+          expect(parser.errors[:field_97]).not_to be_present
+          expect(parser.errors[:field_98]).not_to be_present
+        end
+      end
+
+      context "when outside of collection year" do
+        around do |example|
+          Timecop.freeze(Date.new(2022, 4, 2)) do
+            example.run
+          end
+        end
+
+        let(:attributes) { { bulk_upload:, field_96: "1", field_97: "1", field_98: "22" } }
+
+        let(:bulk_upload) { create(:bulk_upload, :lettings, user:, year: 2022) }
+
+        it "returns errors" do
+          parser.valid?
+
           expect(parser.errors[:field_96]).to be_present
           expect(parser.errors[:field_97]).to be_present
           expect(parser.errors[:field_98]).to be_present