From 81f5c7f6337ec4e85e96975ac85f4e086d8cb42a Mon Sep 17 00:00:00 2001 From: Kat Date: Wed, 30 Nov 2022 09:38:50 +0000 Subject: [PATCH] Fix tests --- spec/features/form/accessible_autocomplete_spec.rb | 1 + spec/features/form/check_answers_page_spec.rb | 2 ++ spec/features/form/checkboxes_spec.rb | 1 + spec/features/form/conditional_questions_spec.rb | 2 ++ spec/features/form/form_navigation_spec.rb | 2 ++ spec/features/form/page_routing_spec.rb | 1 + spec/features/form/progressive_total_field_spec.rb | 1 + spec/features/form/saving_data_spec.rb | 1 + spec/features/form/tasklist_page_spec.rb | 1 + spec/features/form/validations_spec.rb | 2 ++ spec/requests/form_controller_spec.rb | 5 +++++ 11 files changed, 19 insertions(+) diff --git a/spec/features/form/accessible_autocomplete_spec.rb b/spec/features/form/accessible_autocomplete_spec.rb index 52317107a..9c7c1b9ea 100644 --- a/spec/features/form/accessible_autocomplete_spec.rb +++ b/spec/features/form/accessible_autocomplete_spec.rb @@ -19,6 +19,7 @@ RSpec.describe "Accessible Automcomplete" do end before do + allow(lettings_log.form).to receive(:end_date).and_return(Time.zone.today + 1.day) sign_in user end diff --git a/spec/features/form/check_answers_page_spec.rb b/spec/features/form/check_answers_page_spec.rb index 03d237dd2..ad971ae2a 100644 --- a/spec/features/form/check_answers_page_spec.rb +++ b/spec/features/form/check_answers_page_spec.rb @@ -42,6 +42,8 @@ RSpec.describe "Form Check Answers Page" do let(:fake_2021_2022_form) { Form.new("spec/fixtures/forms/2021_2022.json") } before do + allow(lettings_log.form).to receive(:end_date).and_return(Time.zone.today + 1.day) + allow(fake_2021_2022_form).to receive(:end_date).and_return(Time.zone.today + 1.day) sign_in user allow(FormHandler.instance).to receive(:current_lettings_form).and_return(fake_2021_2022_form) end diff --git a/spec/features/form/checkboxes_spec.rb b/spec/features/form/checkboxes_spec.rb index f7a3df152..d3e3671eb 100644 --- a/spec/features/form/checkboxes_spec.rb +++ b/spec/features/form/checkboxes_spec.rb @@ -16,6 +16,7 @@ RSpec.describe "Checkboxes" do let(:id) { lettings_log.id } before do + allow(lettings_log.form).to receive(:end_date).and_return(Time.zone.today + 1.day) RequestHelper.stub_http_requests sign_in user end diff --git a/spec/features/form/conditional_questions_spec.rb b/spec/features/form/conditional_questions_spec.rb index 33d99955e..07a660321 100644 --- a/spec/features/form/conditional_questions_spec.rb +++ b/spec/features/form/conditional_questions_spec.rb @@ -25,6 +25,8 @@ RSpec.describe "Form Conditional Questions" do before do sign_in user + allow(sales_log.form).to receive(:end_date).and_return(Time.zone.today + 1.day) + allow(lettings_log.form).to receive(:end_date).and_return(Time.zone.today + 1.day) allow(FormHandler.instance).to receive(:current_lettings_form).and_return(fake_2021_2022_form) end diff --git a/spec/features/form/form_navigation_spec.rb b/spec/features/form/form_navigation_spec.rb index ffa9bdd88..351675804 100644 --- a/spec/features/form/form_navigation_spec.rb +++ b/spec/features/form/form_navigation_spec.rb @@ -35,6 +35,8 @@ RSpec.describe "Form Navigation" do let(:fake_2021_2022_form) { Form.new("spec/fixtures/forms/2021_2022.json") } before do + allow(lettings_log.form).to receive(:end_date).and_return(Time.zone.today + 1.day) + allow(fake_2021_2022_form).to receive(:end_date).and_return(Time.zone.today + 1.day) sign_in user allow(FormHandler.instance).to receive(:current_lettings_form).and_return(fake_2021_2022_form) end diff --git a/spec/features/form/page_routing_spec.rb b/spec/features/form/page_routing_spec.rb index 27f4feaf5..b60c2dd03 100644 --- a/spec/features/form/page_routing_spec.rb +++ b/spec/features/form/page_routing_spec.rb @@ -16,6 +16,7 @@ RSpec.describe "Form Page Routing" do let(:validator) { lettings_log._validators[nil].first } before do + allow(lettings_log.form).to receive(:end_date).and_return(Time.zone.today + 1.day) allow(validator).to receive(:validate_pregnancy).and_return(true) sign_in user end diff --git a/spec/features/form/progressive_total_field_spec.rb b/spec/features/form/progressive_total_field_spec.rb index 5080de08c..77edfbedd 100644 --- a/spec/features/form/progressive_total_field_spec.rb +++ b/spec/features/form/progressive_total_field_spec.rb @@ -14,6 +14,7 @@ RSpec.describe "Accessible Automcomplete" do end before do + allow(lettings_log.form).to receive(:end_date).and_return(Time.zone.today + 1.day) sign_in user end diff --git a/spec/features/form/saving_data_spec.rb b/spec/features/form/saving_data_spec.rb index 8312cfad9..a0889e9a4 100644 --- a/spec/features/form/saving_data_spec.rb +++ b/spec/features/form/saving_data_spec.rb @@ -30,6 +30,7 @@ RSpec.describe "Form Saving Data" do end before do + allow(lettings_log.form).to receive(:end_date).and_return(Time.zone.today + 1.day) sign_in user end diff --git a/spec/features/form/tasklist_page_spec.rb b/spec/features/form/tasklist_page_spec.rb index 3f7ba6f1e..09d332583 100644 --- a/spec/features/form/tasklist_page_spec.rb +++ b/spec/features/form/tasklist_page_spec.rb @@ -44,6 +44,7 @@ RSpec.describe "Task List" do let(:status) { lettings_log.status } before do + allow(lettings_log.form).to receive(:end_date).and_return(Time.zone.today + 1.day) sign_in user end diff --git a/spec/features/form/validations_spec.rb b/spec/features/form/validations_spec.rb index 54d4f1a48..adf0a9cb4 100644 --- a/spec/features/form/validations_spec.rb +++ b/spec/features/form/validations_spec.rb @@ -33,6 +33,8 @@ RSpec.describe "validations" do let(:id) { lettings_log.id } before do + allow(fake_2021_2022_form).to receive(:end_date).and_return(Time.zone.today + 1.day) + allow(lettings_log.form).to receive(:end_date).and_return(Time.zone.today + 1.day) sign_in user allow(FormHandler.instance).to receive(:current_lettings_form).and_return(fake_2021_2022_form) end diff --git a/spec/requests/form_controller_spec.rb b/spec/requests/form_controller_spec.rb index 1bb73f399..4975d3304 100644 --- a/spec/requests/form_controller_spec.rb +++ b/spec/requests/form_controller_spec.rb @@ -34,6 +34,7 @@ RSpec.describe FormController, type: :request do let(:fake_2021_2022_form) { Form.new("spec/fixtures/forms/2021_2022.json") } before do + allow(fake_2021_2022_form).to receive(:end_date).and_return(Time.zone.today + 1.day) allow(FormHandler.instance).to receive(:current_lettings_form).and_return(fake_2021_2022_form) end @@ -86,6 +87,10 @@ RSpec.describe FormController, type: :request do let(:lettings_log_year_1) { create(:lettings_log, startdate: Time.zone.local(2021, 5, 1), owning_organisation: organisation, created_by: user) } let(:lettings_log_year_2) { create(:lettings_log, :about_completed, startdate: Time.zone.local(2022, 5, 1), owning_organisation: organisation, created_by: user) } + before do + allow(lettings_log_year_1.form).to receive(:end_date).and_return(Time.zone.today + 1.day) + end + it "displays the correct question details for each lettings log based on form year" do get "/lettings-logs/#{lettings_log_year_1.id}/tenant-code-test", headers: headers, params: {} expect(response.body).to include("What is the tenant code?")