From 810793d53fffed6bb113545ed3fd5a7eab88fffd Mon Sep 17 00:00:00 2001 From: Kat Date: Fri, 22 Sep 2023 11:12:13 +0100 Subject: [PATCH] Recalculate refused values for lettings logs with unknown person details --- lib/tasks/correct_refused_values.rake | 12 +++ spec/lib/tasks/correct_refused_values_spec.rb | 84 +++++++++++++++++++ 2 files changed, 96 insertions(+) create mode 100644 lib/tasks/correct_refused_values.rake create mode 100644 spec/lib/tasks/correct_refused_values_spec.rb diff --git a/lib/tasks/correct_refused_values.rake b/lib/tasks/correct_refused_values.rake new file mode 100644 index 000000000..fed2a641c --- /dev/null +++ b/lib/tasks/correct_refused_values.rake @@ -0,0 +1,12 @@ +desc "Forces to recalculate refused values for lettings logs with unknown person details" +task recalculate_refused_values: :environment do + LettingsLog.exportable.where('details_known_2 = 1 + OR details_known_3 = 1 + OR details_known_4 = 1 + OR details_known_5 = 1 + OR details_known_6 = 1 + OR details_known_7 = 1 + OR details_known_8 = 1').each do |log| + log.update!(values_updated_at: Time.zone.now) + end +end diff --git a/spec/lib/tasks/correct_refused_values_spec.rb b/spec/lib/tasks/correct_refused_values_spec.rb new file mode 100644 index 000000000..1f8ce37bf --- /dev/null +++ b/spec/lib/tasks/correct_refused_values_spec.rb @@ -0,0 +1,84 @@ +require "rails_helper" +require "rake" + +RSpec.describe "recalculate_refused_values" do + describe ":recalculate_refused_values", type: :task do + subject(:task) { Rake::Task["recalculate_refused_values"] } + + before do + Rake.application.rake_require("tasks/recalculate_refused_values") + Rake::Task.define_task(:environment) + task.reenable + end + + context "when the rake task is run" do + let!(:lettings_log) { create(:lettings_log, :completed, values_updated_at: nil) } + + it "updates refused value to 1 if details for person are not known" do + lettings_log.refused = 0 + lettings_log.details_known_2 = 1 + lettings_log.hhmemb = 2 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.refused).to eq(1) + expect(lettings_log.values_updated_at).not_to be_nil + end + + it "does not update refused value if details known is nil" do + lettings_log.update!(details_known_2: nil, hhmemb: 2) + lettings_log.refused = 0 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.refused).to eq(0) + expect(lettings_log.values_updated_at).to be_nil + end + + it "does not update refused value if details are known" do + lettings_log.refused = 0 + lettings_log.details_known_2 = 0 + lettings_log.hhmemb = 2 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.refused).to eq(0) + expect(lettings_log.values_updated_at).to be_nil + end + + it "updates refused value to 1 if details for any person are not known" do + lettings_log.refused = 0 + lettings_log.details_known_2 = 0 + lettings_log.details_known_3 = 0 + lettings_log.details_known_4 = 0 + lettings_log.details_known_5 = 0 + lettings_log.details_known_6 = 1 + lettings_log.details_known_7 = 0 + lettings_log.details_known_8 = 0 + lettings_log.hhmemb = 8 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.refused).to eq(1) + expect(lettings_log.values_updated_at).not_to be_nil + end + + it "updates values updated at if refused is already set to 1 but some details are unknown" do + lettings_log.refused = 1 + lettings_log.details_known_2 = 0 + lettings_log.details_known_3 = 0 + lettings_log.details_known_4 = 0 + lettings_log.details_known_5 = 0 + lettings_log.details_known_6 = 1 + lettings_log.details_known_7 = 0 + lettings_log.details_known_8 = 0 + lettings_log.hhmemb = 8 + lettings_log.save!(validate: false) + task.invoke + lettings_log.reload + expect(lettings_log.refused).to eq(1) + expect(lettings_log.values_updated_at).not_to be_nil + end + end + end +end