From 7aacbbc624a3b4634110d2662b0a56466ad4c69b Mon Sep 17 00:00:00 2001 From: James Rose Date: Fri, 23 Sep 2022 12:27:29 +0100 Subject: [PATCH] Add better logging if we can't find a user while importing logs --- app/services/imports/lettings_logs_import_service.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/services/imports/lettings_logs_import_service.rb b/app/services/imports/lettings_logs_import_service.rb index e9d44a87c..911da4ac3 100644 --- a/app/services/imports/lettings_logs_import_service.rb +++ b/app/services/imports/lettings_logs_import_service.rb @@ -226,7 +226,10 @@ module Imports # Sets the log creator owner_id = field_value(xml_doc, "meta", "owner-user-id").strip if owner_id.present? - attributes["created_by"] = LegacyUser.find_by(old_user_id: owner_id)&.user + user = LegacyUser.find_by(old_user_id: owner_id)&.user + @logger.warn "Missing user! We expected to find a legacy user with old_user_id #{owner_id}" unless user + + attributes["created_by"] = user end apply_date_consistency!(attributes)