From 79f1d1e5fddd1464587034829a00819271118e9a Mon Sep 17 00:00:00 2001 From: Kat Date: Tue, 22 Aug 2023 11:43:38 +0100 Subject: [PATCH] Update row parsers --- app/services/bulk_upload/lettings/year2022/row_parser.rb | 7 ++++++- app/services/bulk_upload/lettings/year2023/row_parser.rb | 4 ++-- .../bulk_upload/lettings/year2022/row_parser_spec.rb | 2 +- .../bulk_upload/lettings/year2023/row_parser_spec.rb | 2 +- 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/app/services/bulk_upload/lettings/year2022/row_parser.rb b/app/services/bulk_upload/lettings/year2022/row_parser.rb index 2b9bee7c3..a5c598d5a 100644 --- a/app/services/bulk_upload/lettings/year2022/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2022/row_parser.rb @@ -1283,7 +1283,12 @@ private end def ppcodenk - field_65 == 1 ? 0 : 1 + case field_65 + when 1 + 0 + when 2 + 1 + end end def earnings diff --git a/app/services/bulk_upload/lettings/year2023/row_parser.rb b/app/services/bulk_upload/lettings/year2023/row_parser.rb index 8d023792c..4abfdac17 100644 --- a/app/services/bulk_upload/lettings/year2023/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2023/row_parser.rb @@ -1424,9 +1424,9 @@ private def ppcodenk case field_106 when 1 - 1 - when 2 0 + when 2 + 1 end end diff --git a/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb index 6b5eaa2ae..7380ca550 100644 --- a/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb @@ -1562,7 +1562,7 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do let(:attributes) { { bulk_upload:, field_65: "2" } } it "sets correct value from mapping" do - expect(parser.log.ppcodenk).to eq(0) + expect(parser.log.ppcodenk).to eq(1) end end diff --git a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb index cac166f46..c2f816ab6 100644 --- a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb @@ -1642,7 +1642,7 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do let(:attributes) { { bulk_upload:, field_106: "2" } } it "sets correct value from mapping" do - expect(parser.log.ppcodenk).to eq(0) + expect(parser.log.ppcodenk).to eq(1) end end