diff --git a/app/models/form/question.rb b/app/models/form/question.rb index 838d7d365..cb012e22a 100644 --- a/app/models/form/question.rb +++ b/app/models/form/question.rb @@ -41,7 +41,7 @@ class Form::Question @check_answers_card_number = hsh["check_answers_card_number"] || 0 @unresolved_hint_text = hsh["unresolved_hint_text"] @question_number = hsh["question_number"] - @hide_question_number_on_page = hsh["hide_question_number_on_page"] + @hide_question_number_on_page = hsh["hide_question_number_on_page"] || false @plain_label = hsh["plain_label"] @error_label = hsh["error_label"] @disable_clearing_if_not_routed_or_dynamic_answer_options = hsh["disable_clearing_if_not_routed_or_dynamic_answer_options"] diff --git a/app/models/form/sales/questions/town_or_city.rb b/app/models/form/sales/questions/town_or_city.rb index 4c23c0671..b136d186c 100644 --- a/app/models/form/sales/questions/town_or_city.rb +++ b/app/models/form/sales/questions/town_or_city.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::TownOrCity < ::Form::Question @plain_label = true @check_answer_label = "Town or city" @disable_clearing_if_not_routed_or_dynamic_answer_options = true - @question_number = 12 + @question_number = 15 @hide_question_number_on_page = true end end diff --git a/app/services/bulk_upload/lettings/year2022/row_parser.rb b/app/services/bulk_upload/lettings/year2022/row_parser.rb index b79447b67..40cceac45 100644 --- a/app/services/bulk_upload/lettings/year2022/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2022/row_parser.rb @@ -774,13 +774,13 @@ private if setup_question?(question) fields.each do |field| if errors.select { |e| fields.include?(e.attribute) }.none? - errors.add(field, I18n.t("validations.not_answered", question: question.check_answer_label&.downcase), category: :setup) + errors.add(field, I18n.t("validations.not_answered", question: question.display_label&.downcase), category: :setup) end end else fields.each do |field| unless errors.any? { |e| fields.include?(e.attribute) } - errors.add(field, I18n.t("validations.not_answered", question: question.check_answer_label&.downcase)) + errors.add(field, I18n.t("validations.not_answered", question: question.display_label&.downcase)) end end end diff --git a/app/services/bulk_upload/lettings/year2023/row_parser.rb b/app/services/bulk_upload/lettings/year2023/row_parser.rb index 225c45b4f..b8c903d22 100644 --- a/app/services/bulk_upload/lettings/year2023/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2023/row_parser.rb @@ -681,14 +681,14 @@ private if setup_question?(question) fields.each do |field| if errors.select { |e| fields.include?(e.attribute) }.none? - question_text = question.check_answer_label.presence || question.header.presence || "this question" + question_text = question.display_label.presence || "this question" errors.add(field, I18n.t("validations.not_answered", question: question_text.downcase), category: :setup) end end else fields.each do |field| unless errors.any? { |e| fields.include?(e.attribute) } - question_text = question.check_answer_label.presence || question.header.presence || "this question" + question_text = question.display_label.presence || "this question" errors.add(field, I18n.t("validations.not_answered", question: question_text.downcase)) end end diff --git a/app/services/bulk_upload/sales/year2022/row_parser.rb b/app/services/bulk_upload/sales/year2022/row_parser.rb index ed51a0601..09002905c 100644 --- a/app/services/bulk_upload/sales/year2022/row_parser.rb +++ b/app/services/bulk_upload/sales/year2022/row_parser.rb @@ -1057,9 +1057,9 @@ private fields.each do |field| unless errors.any? { |e| fields.include?(e.attribute) } if setup_question?(question) - errors.add(field, I18n.t("validations.not_answered", question: question.check_answer_label&.downcase), category: :setup) + errors.add(field, I18n.t("validations.not_answered", question: question.display_label&.downcase), category: :setup) else - errors.add(field, I18n.t("validations.not_answered", question: question.check_answer_label&.downcase)) + errors.add(field, I18n.t("validations.not_answered", question: question.display_label&.downcase)) end end end diff --git a/app/services/bulk_upload/sales/year2023/row_parser.rb b/app/services/bulk_upload/sales/year2023/row_parser.rb index e0f2b727f..80b1b6cf0 100644 --- a/app/services/bulk_upload/sales/year2023/row_parser.rb +++ b/app/services/bulk_upload/sales/year2023/row_parser.rb @@ -1210,13 +1210,13 @@ private if setup_question?(question) fields.each do |field| unless errors.any? { |e| fields.include?(e.attribute) } - errors.add(field, I18n.t("validations.not_answered", question: question.check_answer_label&.downcase), category: :setup) + errors.add(field, I18n.t("validations.not_answered", question: question.display_label&.downcase), category: :setup) end end else fields.each do |field| unless errors.any? { |e| fields.include?(e.attribute) } - errors.add(field, I18n.t("validations.not_answered", question: question.check_answer_label&.downcase)) + errors.add(field, I18n.t("validations.not_answered", question: question.display_label&.downcase)) end end end