From 773a12a9dde6f296bc0322afcc47d9c4c3c6d39c Mon Sep 17 00:00:00 2001 From: Arthur Campbell Date: Fri, 14 Jun 2024 14:31:04 +0100 Subject: [PATCH] update bulk upload specs to reflect error message updates --- .../bulk_upload/sales/year2023/row_parser_spec.rb | 8 ++++---- .../bulk_upload/sales/year2024/row_parser_spec.rb | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/spec/services/bulk_upload/sales/year2023/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2023/row_parser_spec.rb index 1a4f0375e..7a936adf7 100644 --- a/spec/services/bulk_upload/sales/year2023/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2023/row_parser_spec.rb @@ -1075,7 +1075,7 @@ RSpec.describe BulkUpload::Sales::Year2023::RowParser do let(:attributes) { setup_section_params.merge(field_105: "3", field_87: "2", field_88: "50", field_89: nil, field_111: nil) } it "returns correct errors" do - expect(parser.errors[:field_105]).to include("Enter a valid value for Was a mortgage used for the purchase of this property?") + expect(parser.errors[:field_105]).to include("Enter a valid value for was a mortgage used for the purchase of this property?") parser.log.blank_invalid_non_setup_fields! parser.log.save! expect(parser.log.mortgageused).to be_nil @@ -1086,7 +1086,7 @@ RSpec.describe BulkUpload::Sales::Year2023::RowParser do let(:attributes) { setup_section_params.merge(field_105: "3", field_87: "2", field_88: "50", field_89: "100", field_111: nil) } it "returns correct errors" do - expect(parser.errors[:field_105]).to include("Enter a valid value for Was a mortgage used for the purchase of this property?") + expect(parser.errors[:field_105]).to include("Enter a valid value for was a mortgage used for the purchase of this property?") parser.log.blank_invalid_non_setup_fields! parser.log.save! expect(parser.log.mortgageused).to be_nil @@ -1099,7 +1099,7 @@ RSpec.describe BulkUpload::Sales::Year2023::RowParser do let(:attributes) { valid_attributes.merge({ field_7: "2", field_9: "8", field_119: "3" }) } it "does not allow 3 (don't know) as an option for discounted ownership" do - expect(parser.errors[:field_119]).to include("Enter a valid value for Was a mortgage used for the purchase of this property?") + expect(parser.errors[:field_119]).to include("Enter a valid value for was a mortgage used for the purchase of this property?") parser.log.blank_invalid_non_setup_fields! parser.log.save! expect(parser.log.mortgageused).to be_nil @@ -1120,7 +1120,7 @@ RSpec.describe BulkUpload::Sales::Year2023::RowParser do let(:attributes) { valid_attributes.merge({ field_7: "3", field_10: "10", field_128: "3", field_12: "2" }) } it "does not allow 3 (don't know) as an option for outright sale" do - expect(parser.errors[:field_128]).to include("Enter a valid value for Was a mortgage used for the purchase of this property?") + expect(parser.errors[:field_128]).to include("Enter a valid value for was a mortgage used for the purchase of this property?") parser.log.blank_invalid_non_setup_fields! parser.log.save! expect(parser.log.mortgageused).to be_nil diff --git a/spec/services/bulk_upload/sales/year2024/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2024/row_parser_spec.rb index fa2e1cdc9..0af4d5962 100644 --- a/spec/services/bulk_upload/sales/year2024/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2024/row_parser_spec.rb @@ -1156,8 +1156,8 @@ RSpec.describe BulkUpload::Sales::Year2024::RowParser do let(:attributes) { setup_section_params.merge(field_103: "3", field_86: "1", field_87: "50", field_88: nil, field_109: nil) } it "does not add errors" do - expect(parser.errors[:field_103]).not_to include("The percentage owned has to be 100% if the mortgage used is 'Don’t know'") - expect(parser.errors[:field_103]).not_to include("Enter a valid value for Was a mortgage used for the purchase of this property?") + expect(parser.errors[:field_103]).to be_empty + expect(parser.errors[:field_103]).to be_empty end end @@ -1166,7 +1166,7 @@ RSpec.describe BulkUpload::Sales::Year2024::RowParser do let(:attributes) { setup_section_params.merge(field_103: "3", field_86: "2", field_87: "50", field_88: nil, field_109: nil) } it "returns correct errors" do - expect(parser.errors[:field_103]).to include("Enter a valid value for Was a mortgage used for the purchase of this property?") + expect(parser.errors[:field_103]).to include("Enter a valid value for was a mortgage used for the purchase of this property?") parser.log.blank_invalid_non_setup_fields! parser.log.save! expect(parser.log.mortgageused).to be_nil @@ -1177,7 +1177,7 @@ RSpec.describe BulkUpload::Sales::Year2024::RowParser do let(:attributes) { setup_section_params.merge(field_103: "3", field_86: "2", field_87: "50", field_88: "100", field_109: nil) } it "returns correct errors" do - expect(parser.errors[:field_103]).to include("Enter a valid value for Was a mortgage used for the purchase of this property?") + expect(parser.errors[:field_103]).to include("Enter a valid value for was a mortgage used for the purchase of this property?") parser.log.blank_invalid_non_setup_fields! parser.log.save! expect(parser.log.mortgageused).to be_nil @@ -1228,7 +1228,7 @@ RSpec.describe BulkUpload::Sales::Year2024::RowParser do let(:attributes) { valid_attributes.merge({ field_8: "2", field_10: "9", field_117: "3" }) } it "does not allow 3 (don't know) as an option for discounted ownership" do - expect(parser.errors[:field_117]).to include("Enter a valid value for Was a mortgage used for the purchase of this property?") + expect(parser.errors[:field_117]).to include("Enter a valid value for was a mortgage used for the purchase of this property?") parser.log.blank_invalid_non_setup_fields! parser.log.save! expect(parser.log.mortgageused).to be_nil