From 746c3ffa34b3446fbf8b0ce09b9fbffe865ebb1c Mon Sep 17 00:00:00 2001 From: Kat Date: Wed, 1 Mar 2023 08:45:59 +0000 Subject: [PATCH] Display fewer answer options --- app/models/form/sales/questions/buyer1_mortgage.rb | 7 +++++++ .../form/sales/questions/buyer1_previous_tenure.rb | 13 +++++++++++++ app/models/form/sales/questions/buyer2_mortgage.rb | 7 +++++++ .../form/sales/questions/buyer1_mortgage_spec.rb | 8 ++++++++ .../sales/questions/buyer1_previous_tenure_spec.rb | 14 ++++++++++++++ .../form/sales/questions/buyer2_mortgage_spec.rb | 8 ++++++++ 6 files changed, 57 insertions(+) diff --git a/app/models/form/sales/questions/buyer1_mortgage.rb b/app/models/form/sales/questions/buyer1_mortgage.rb index 33fb45c43..baaf00d4c 100644 --- a/app/models/form/sales/questions/buyer1_mortgage.rb +++ b/app/models/form/sales/questions/buyer1_mortgage.rb @@ -14,4 +14,11 @@ class Form::Sales::Questions::Buyer1Mortgage < ::Form::Question "2" => { "value" => "No" }, "3" => { "value" => "Don’t know" }, }.freeze + + def displayed_answer_options(_log, _user = nil) + { + "1" => { "value" => "Yes" }, + "2" => { "value" => "No" }, + } + end end diff --git a/app/models/form/sales/questions/buyer1_previous_tenure.rb b/app/models/form/sales/questions/buyer1_previous_tenure.rb index a99f12bea..d13c952cd 100644 --- a/app/models/form/sales/questions/buyer1_previous_tenure.rb +++ b/app/models/form/sales/questions/buyer1_previous_tenure.rb @@ -19,4 +19,17 @@ class Form::Sales::Questions::Buyer1PreviousTenure < ::Form::Question "9" => { "value" => "Other" }, "0" => { "value" => "Don’t know" }, }.freeze + + def displayed_answer_options(_log, _user = nil) + { + "1" => { "value" => "Local Authority" }, + "2" => { "value" => "Private registered provider or housing association tenant" }, + "3" => { "value" => "Private tenant" }, + "5" => { "value" => "Owner occupier" }, + "4" => { "value" => "Tied home or renting with job" }, + "6" => { "value" => "Living with family or friends" }, + "7" => { "value" => "Temporary accomodation" }, + "9" => { "value" => "Other" }, + } + end end diff --git a/app/models/form/sales/questions/buyer2_mortgage.rb b/app/models/form/sales/questions/buyer2_mortgage.rb index 9d5f6d986..884137df1 100644 --- a/app/models/form/sales/questions/buyer2_mortgage.rb +++ b/app/models/form/sales/questions/buyer2_mortgage.rb @@ -14,4 +14,11 @@ class Form::Sales::Questions::Buyer2Mortgage < ::Form::Question "2" => { "value" => "No" }, "3" => { "value" => "Don’t know" }, }.freeze + + def displayed_answer_options(_log, _user = nil) + { + "1" => { "value" => "Yes" }, + "2" => { "value" => "No" }, + } + end end diff --git a/spec/models/form/sales/questions/buyer1_mortgage_spec.rb b/spec/models/form/sales/questions/buyer1_mortgage_spec.rb index 8c7ea725e..df47cd1ce 100644 --- a/spec/models/form/sales/questions/buyer1_mortgage_spec.rb +++ b/spec/models/form/sales/questions/buyer1_mortgage_spec.rb @@ -6,6 +6,7 @@ RSpec.describe Form::Sales::Questions::Buyer1Mortgage, type: :model do let(:question_id) { nil } let(:question_definition) { nil } let(:page) { instance_double(Form::Page) } + let(:log) { create(:sales_log) } it "has correct page" do expect(question.page).to eq(page) @@ -39,6 +40,13 @@ RSpec.describe Form::Sales::Questions::Buyer1Mortgage, type: :model do }) end + it "has the correct displayed_answer_options" do + expect(question.displayed_answer_options(log)).to eq({ + "1" => { "value" => "Yes" }, + "2" => { "value" => "No" }, + }) + end + it "has the correct check_answers_card_number" do expect(question.check_answers_card_number).to eq(1) end diff --git a/spec/models/form/sales/questions/buyer1_previous_tenure_spec.rb b/spec/models/form/sales/questions/buyer1_previous_tenure_spec.rb index 44c7a26af..4a0a86dba 100644 --- a/spec/models/form/sales/questions/buyer1_previous_tenure_spec.rb +++ b/spec/models/form/sales/questions/buyer1_previous_tenure_spec.rb @@ -6,6 +6,7 @@ RSpec.describe Form::Sales::Questions::Buyer1PreviousTenure, type: :model do let(:question_id) { nil } let(:question_definition) { nil } let(:page) { instance_double(Form::Page) } + let(:log) { create(:sales_log) } it "has correct page" do expect(question.page).to eq(page) @@ -44,4 +45,17 @@ RSpec.describe Form::Sales::Questions::Buyer1PreviousTenure, type: :model do "0" => { "value" => "Don’t know" }, }) end + + it "has the correct displayed_answer_options" do + expect(question.displayed_answer_options(log)).to eq({ + "1" => { "value" => "Local Authority" }, + "2" => { "value" => "Private registered provider or housing association tenant" }, + "3" => { "value" => "Private tenant" }, + "4" => { "value" => "Tied home or renting with job" }, + "5" => { "value" => "Owner occupier" }, + "6" => { "value" => "Living with family or friends" }, + "7" => { "value" => "Temporary accomodation" }, + "9" => { "value" => "Other" }, + }) + end end diff --git a/spec/models/form/sales/questions/buyer2_mortgage_spec.rb b/spec/models/form/sales/questions/buyer2_mortgage_spec.rb index 2eeb6782f..5bf83a2d0 100644 --- a/spec/models/form/sales/questions/buyer2_mortgage_spec.rb +++ b/spec/models/form/sales/questions/buyer2_mortgage_spec.rb @@ -6,6 +6,7 @@ RSpec.describe Form::Sales::Questions::Buyer2Mortgage, type: :model do let(:question_id) { nil } let(:question_definition) { nil } let(:page) { instance_double(Form::Page) } + let(:log) { create(:sales_log) } it "has correct page" do expect(question.page).to eq(page) @@ -39,6 +40,13 @@ RSpec.describe Form::Sales::Questions::Buyer2Mortgage, type: :model do }) end + it "has the correct displayed_answer_options" do + expect(question.displayed_answer_options(log)).to eq({ + "1" => { "value" => "Yes" }, + "2" => { "value" => "No" }, + }) + end + it "has the correct check_answers_card_number" do expect(question.check_answers_card_number).to eq(2) end