test: add and update tests

spec/factories/sales_log.rb

@@ -72,6 +72,7 @@ FactoryBot.define do
       cashdis { 1_000 }
       value { 110_000 }
       grant { 1_000 }
+      proplen { 10 }
     end
   end
 end

spec/models/form/sales/pages/living_before_purchase_spec.rb

@@ -0,0 +1,33 @@
+require "rails_helper"
+
+RSpec.describe Form::Sales::Pages::LivingBeforePurchase, type: :model do
+  subject(:page) { described_class.new(page_id, page_definition, subsection) }
+
+  let(:page_id) { nil }
+  let(:page_definition) { nil }
+  let(:subsection) { instance_double(Form::Subsection) }
+
+  it "has correct subsection" do
+    expect(page.subsection).to eq(subsection)
+  end
+
+  it "has correct questions" do
+    expect(page.questions.map(&:id)).to eq(%w[proplen])
+  end
+
+  it "has the correct id" do
+    expect(page.id).to eq(nil)
+  end
+
+  it "has the correct header" do
+    expect(page.header).to eq("")
+  end
+
+  it "has the correct description" do
+    expect(page.description).to eq("")
+  end
+
+  it "has correct depends_on" do
+    expect(page.depends_on).to be_nil
+  end
+end

spec/models/form/sales/questions/living_before_purchase_spec.rb

@@ -0,0 +1,57 @@
+require "rails_helper"
+
+RSpec.describe Form::Sales::Questions::LivingBeforePurchase, type: :model do
+  subject(:question) { described_class.new(question_id, question_definition, page) }
+
+  let(:question_id) { nil }
+  let(:question_definition) { nil }
+  let(:page) { instance_double(Form::Page) }
+
+  it "has correct page" do
+    expect(question.page).to eq(page)
+  end
+
+  it "has the correct id" do
+    expect(question.id).to eq("proplen")
+  end
+
+  it "has the correct header" do
+    expect(question.header).to eq("How long did the buyer(s) live in the property before purchase?")
+  end
+
+  it "has the correct check_answer_label" do
+    expect(question.check_answer_label).to eq("Number of years buyers living in the property before purchase")
+  end
+
+  it "has the correct type" do
+    expect(question.type).to eq("numeric")
+  end
+
+  it "is not marked as derived" do
+    expect(question.derived?).to be false
+  end
+
+  it "has the correct hint" do
+    expect(question.hint_text).to eq("You should round this up to the nearest year. If the buyers haven't been living in the property, enter '0'")
+  end
+
+  it "has correct width" do
+    expect(question.width).to eq(5)
+  end
+
+  it "has correct step" do
+    expect(question.step).to eq(1)
+  end
+
+  it "has correct suffix" do
+    expect(question.suffix).to eq(" years")
+  end
+
+  it "has correct min" do
+    expect(question.min).to eq(0)
+  end
+
+  it "has correct max" do
+    expect(question.max).to eq(80)
+  end
+end

spec/models/form/sales/subsections/discounted_ownership_scheme_spec.rb

@@ -13,7 +13,8 @@ RSpec.describe Form::Sales::Subsections::DiscountedOwnershipScheme, type: :model
 
   it "has correct pages" do
     expect(discounted_ownership_scheme.pages.map(&:id)).to eq(
-      %w[about_deposit_discounted_ownership
+      %w[living_before_purchase_discounted_ownership
+         about_deposit_discounted_ownership
          about_price_rtb
          about_price_not_rtb],
     )

spec/models/form/sales/subsections/shared_ownership_scheme_spec.rb

@@ -14,6 +14,7 @@ RSpec.describe Form::Sales::Subsections::SharedOwnershipScheme, type: :model do
   it "has correct pages" do
     expect(shared_ownership_scheme.pages.map(&:id)).to eq(
       %w[
+        living_before_purchase_shared_ownership
         staircasing
         about_staircasing
         resale

spec/models/form_handler_spec.rb

@@ -52,14 +52,14 @@ RSpec.describe FormHandler do
     it "is able to load a current sales form" do
       form = form_handler.get_form("current_sales")
       expect(form).to be_a(Form)
-      expect(form.pages.count).to eq(84)
+      expect(form.pages.count).to eq(86)
       expect(form.name).to eq("2022_2023_sales")
     end
 
     it "is able to load a previous sales form" do
       form = form_handler.get_form("previous_sales")
       expect(form).to be_a(Form)
-      expect(form.pages.count).to eq(84)
+      expect(form.pages.count).to eq(86)
       expect(form.name).to eq("2021_2022_sales")
     end
   end