diff --git a/Gemfile b/Gemfile
index 332359f98..4dc93aaf7 100644
--- a/Gemfile
+++ b/Gemfile
@@ -23,6 +23,7 @@ gem "govuk-components", "~> 5.1"
gem "govuk_design_system_formbuilder", "~> 5.0"
# Convert Markdown into GOV.UK frontend-styled HTML
gem "govuk_markdown"
+gem "redcarpet", "~> 3.6"
# GOV UK Notify
gem "notifications-ruby-client"
# A modest javascript framework for the html you already have
diff --git a/Gemfile.lock b/Gemfile.lock
index 086491321..7cc2addda 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -559,6 +559,7 @@ DEPENDENCIES
rack-mini-profiler (~> 2.0)
rails (~> 7.0.8.3)
rails_admin (~> 3.1)
+ redcarpet (~> 3.6)
redis (~> 4.8)
roo
rspec-rails
diff --git a/app/controllers/notifications_controller.rb b/app/controllers/notifications_controller.rb
index e3aff82e6..d0181ead6 100644
--- a/app/controllers/notifications_controller.rb
+++ b/app/controllers/notifications_controller.rb
@@ -1,19 +1,93 @@
class NotificationsController < ApplicationController
+ before_action :authenticate_user!, except: %i[show]
+ before_action :authenticate_scope!, except: %i[show dismiss]
+ before_action :find_notification, except: %i[new create]
+
+ rescue_from ActiveRecord::RecordNotFound, with: :render_not_found
+
def dismiss
- if current_user.blank?
- redirect_to root_path
- else
- current_user.newest_active_unread_notification.mark_as_read! for: current_user if current_user.newest_active_unread_notification.present?
- redirect_back(fallback_location: root_path)
- end
+ @notification.mark_as_read! for: current_user
+ redirect_back(fallback_location: root_path)
end
def show
- @notification = current_user&.newest_active_unread_notification || Notification.newest_active_unauthenticated_notification
- if @notification&.page_content
+ if !@notification.show_on_unauthenticated_pages && !current_user
+ render_not_found and return
+ end
+
+ if @notification.show_additional_page
render "show"
else
redirect_back(fallback_location: root_path)
end
end
+
+ def new
+ @notification = Notification.new
+ end
+
+ def create
+ @notification = Notification.new(notification_model_params)
+
+ if @notification.errors.empty? && @notification.save
+ redirect_to notification_check_answers_path(@notification)
+ else
+ render :new, status: :unprocessable_entity
+ end
+ end
+
+ def update
+ start_now = params[:notification][:start_now]
+
+ if @notification.errors.empty? && @notification.update(notification_model_params)
+ if start_now
+ flash[:notice] = "The notification has been created"
+ redirect_to root_path
+ else
+ redirect_to notification_check_answers_path(@notification)
+ end
+ elsif start_now
+ render :check_answers, status: :unprocessable_entity
+ else
+ render :edit, status: :unprocessable_entity
+ end
+ end
+
+ def delete
+ @notification.update!(end_date: Time.zone.now)
+ flash[:notice] = "The notification has been deleted"
+ redirect_to root_path
+ end
+
+private
+
+ def notification_params
+ params.require(:notification).permit(:title, :show_on_unauthenticated_pages, :show_additional_page, :link_text, :page_content, :start_now)
+ end
+
+ def authenticate_scope!
+ render_not_found unless current_user.support?
+ end
+
+ def notification_model_params
+ model_params = notification_params.except(:start_now)
+
+ if notification_params[:show_additional_page] == "0"
+ model_params[:link_text] = nil
+ model_params[:page_content] = nil
+ end
+
+ model_params[:start_date] = Time.zone.now if notification_params[:start_now]
+
+ model_params
+ end
+
+ def find_notification
+ id = params[:id] || params[:notification_id]
+ @notification = current_user&.support? ? Notification.find_by(id:) : Notification.active.find_by(id:)
+
+ raise ActiveRecord::RecordNotFound unless @notification
+
+ @notification
+ end
end
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 01f7734c2..bb119b29e 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -12,7 +12,7 @@ module ApplicationHelper
def govuk_header_classes(current_user)
if current_user&.support?
"app-header app-header--orange"
- elsif ((current_user.blank? && Notification.active_unauthenticated_notifications.present?) || current_user&.active_unread_notifications.present?) && !current_page?(notifications_path)
+ elsif notifications_to_display?
"app-header app-header__no-border-bottom"
else
"app-header"
@@ -28,7 +28,7 @@ module ApplicationHelper
end
def notifications_to_display?
- !current_page?(notifications_path) && (authenticated_user_has_notifications? || unauthenticated_user_has_notifications?)
+ !request.path.match?(/\/notifications\/\d+$/) && (authenticated_user_has_notifications? || unauthenticated_user_has_notifications?)
end
private
diff --git a/app/helpers/navigation_items_helper.rb b/app/helpers/navigation_items_helper.rb
index 1cecb97ec..b1a0c6a4c 100644
--- a/app/helpers/navigation_items_helper.rb
+++ b/app/helpers/navigation_items_helper.rb
@@ -47,7 +47,7 @@ module NavigationItemsHelper
private
def home_current?(path)
- path == root_path || path == notifications_path
+ path == root_path || path.match?(/\/notifications\/\d+$/)
end
def lettings_logs_current?(path)
diff --git a/app/helpers/notifications_helper.rb b/app/helpers/notifications_helper.rb
index ab4c8ec21..318918134 100644
--- a/app/helpers/notifications_helper.rb
+++ b/app/helpers/notifications_helper.rb
@@ -14,4 +14,86 @@ module NotificationsHelper
Notification.newest_active_unauthenticated_notification
end
end
+
+ def render_for_banner(title)
+ # rubocop:disable Rails/HelperInstanceVariable
+ @banner_renderer ||= NotificationRenderer.new({ invert_link_colour: true, bold_all_text: true })
+ @banner_markdown ||= Redcarpet::Markdown.new(@banner_renderer, no_intra_emphasis: true)
+ @banner_markdown.render(title)
+ # rubocop:enable Rails/HelperInstanceVariable
+ end
+
+ def render_for_summary(title)
+ render_normal_markdown(title)
+ end
+
+ def render_for_page(notification)
+ content_includes_own_title = /\A\s*#[^#]/.match?(notification.page_content)
+ return render_normal_markdown(notification.page_content) if content_includes_own_title
+
+ content = "# #{notification.title}\n#{notification.page_content}"
+ render_normal_markdown(content)
+ end
+
+ def render_for_home(notification)
+ return render_normal_markdown(notification.title) unless notification.show_additional_page
+
+ content = "#{notification.title} \n[#{notification.link_text}](#{notification_path(notification)})"
+ render_normal_markdown(content)
+ end
+
+private
+
+ def render_normal_markdown(content)
+ # rubocop:disable Rails/HelperInstanceVariable
+ @on_page_renderer ||= NotificationRenderer.new({ invert_link_colour: false, bold_all_text: false })
+ @on_page_markdown ||= Redcarpet::Markdown.new(@on_page_renderer, no_intra_emphasis: true)
+ @on_page_markdown.render(content)
+ # rubocop:enable Rails/HelperInstanceVariable
+ end
+end
+
+class NotificationRenderer < Redcarpet::Render::HTML
+ def initialize(options = {})
+ link_class = "govuk-link"
+ link_class += " govuk-link--inverse" if options[:invert_link_colour]
+ @bold = options[:bold_all_text] # rubocop:disable Rails/HelperInstanceVariable
+ base_options = { escape_html: true, safe_links_only: true, link_attributes: { class: link_class } }
+ super base_options
+ end
+
+ def header(text, header_level)
+ header_size = case header_level
+ when 1
+ "xl"
+ when 2
+ "l"
+ when 3
+ "m"
+ else
+ "s"
+ end
+
+ %()
+ end
+
+ def paragraph(text)
+ return %(
#{text}
) if @bold # rubocop:disable Rails/HelperInstanceVariable
+
+ %(#{text}
)
+ end
+
+ def list(contents, list_type)
+ return %(#{contents}
) if list_type == :ordered
+
+ %()
+ end
+
+ def hrule
+ %(
)
+ end
+
+ def block_quote(quote)
+ %(#{quote}
)
+ end
end
diff --git a/app/models/notification.rb b/app/models/notification.rb
index 86978ebea..cd7c9972a 100644
--- a/app/models/notification.rb
+++ b/app/models/notification.rb
@@ -1,7 +1,12 @@
class Notification < ApplicationRecord
acts_as_readable
- scope :active, -> { where("start_date <= ? AND end_date >= ?", Time.zone.now, Time.zone.now) }
+ has_paper_trail
+
+ validates :title, presence: { message: I18n.t("activerecord.errors.models.notification.attributes.title.blank") }
+ validate :validate_additional_page_information
+
+ scope :active, -> { where("start_date <= ? AND (end_date >= ? OR end_date is null)", Time.zone.now, Time.zone.now) }
scope :unauthenticated, -> { where(show_on_unauthenticated_pages: true) }
def self.active_unauthenticated_notifications
@@ -11,4 +16,18 @@ class Notification < ApplicationRecord
def self.newest_active_unauthenticated_notification
active_unauthenticated_notifications.last
end
+
+private
+
+ def validate_additional_page_information
+ return unless show_additional_page
+
+ if link_text.blank?
+ errors.add :link_text, I18n.t("activerecord.errors.models.notification.attributes.link_text.blank_when_additional_page_set")
+ end
+
+ if page_content.blank?
+ errors.add :page_content, I18n.t("activerecord.errors.models.notification.attributes.page_content.blank_when_additional_page_set")
+ end
+ end
end
diff --git a/app/presenters/homepage_presenter.rb b/app/presenters/homepage_presenter.rb
index 1cb784e3a..3b3314667 100644
--- a/app/presenters/homepage_presenter.rb
+++ b/app/presenters/homepage_presenter.rb
@@ -2,7 +2,7 @@ class HomepagePresenter
include Rails.application.routes.url_helpers
include CollectionTimeHelper
- attr_reader :current_year_in_progress_lettings_data, :current_year_completed_lettings_data, :current_year_in_progress_sales_data, :current_year_completed_sales_data, :last_year_in_progress_lettings_data, :last_year_completed_lettings_data, :last_year_in_progress_sales_data, :last_year_completed_sales_data, :incomplete_schemes_data
+ attr_reader :current_year_in_progress_lettings_data, :current_year_completed_lettings_data, :current_year_in_progress_sales_data, :current_year_completed_sales_data, :last_year_in_progress_lettings_data, :last_year_completed_lettings_data, :last_year_in_progress_sales_data, :last_year_completed_sales_data, :incomplete_schemes_data, :active_notifications
def initialize(user)
@user = user
@@ -25,6 +25,7 @@ class HomepagePresenter
path: schemes_path(status: [:incomplete], owning_organisation_select: "all"),
}
end
+ @active_notifications = Notification.active if @user.support?
end
def title_text_for_user
diff --git a/app/views/home/index.html.erb b/app/views/home/index.html.erb
index 6995c28e5..e55dc6c99 100644
--- a/app/views/home/index.html.erb
+++ b/app/views/home/index.html.erb
@@ -6,6 +6,10 @@
<%= @homepage_presenter.title_text_for_user %>
+ <% if @current_user.support? %>
+ <%= render partial: "notifications/notification_home_section", locals: { active_notifications: @homepage_presenter.active_notifications } %>
+ <% end %>
+
<% if @homepage_presenter.in_crossover_period? %>
diff --git a/app/views/notifications/_form.html.erb b/app/views/notifications/_form.html.erb
new file mode 100644
index 000000000..32af1adc0
--- /dev/null
+++ b/app/views/notifications/_form.html.erb
@@ -0,0 +1,33 @@
+
+
+ <%= f.govuk_error_summary %>
+
+ <% content_for :page_title, "Create a new notification" %>
+
+ <% content_for :before_content do %>
+ <%= govuk_back_link(href: :back) %>
+ <% end %>
+
+
+ <%= content_for(:page_title) %>
+
+
+ This notification will be visible to all users until you delete it
+
+ <%= f.govuk_text_field :title,
+ label: { text: "Title", size: "m" },
+ hint: { text: "Use markdown for links to existing pages" } %>
+
+ <%= f.govuk_check_boxes_fieldset :display_options, multiple: false, legend: { text: "Display Options" } do %>
+ <%= f.govuk_check_box :show_on_unauthenticated_pages, 1, 0, multiple: false, label: { text: "Show this notification on unauthenticated pages, for example the start page" } %>
+ <%= f.govuk_check_box :show_additional_page, 1, 0, multiple: false, label: { text: "Include a link to a separate page with additional information" } do %>
+ <%= f.govuk_text_field :link_text, label: { text: "Link text" }, hint: { text: "Use descriptive language and relevant terms. The link text should make sense out of context." } %>
+ <%= f.govuk_text_area :page_content, label: { text: "Page content" }, hint: { text: "Use markdown to format the page content. The page title will be the notification title by default. Use a heading level one if you want to override it." } %>
+ <% end %>
+ <% end %>
+
+ <%= govuk_link_to "Find out more about using Markdown at Markdown Guide", "https://www.markdownguide.org/basic-syntax/", new_tab: true %>
+
+ <%= f.govuk_submit "Continue" %>
+
+
diff --git a/app/views/notifications/_notification_banner.html.erb b/app/views/notifications/_notification_banner.html.erb
index cd7dfffac..a9cc8bdff 100644
--- a/app/views/notifications/_notification_banner.html.erb
+++ b/app/views/notifications/_notification_banner.html.erb
@@ -6,16 +6,16 @@
<% if notification_count > 1 && current_user.present? %>
Notification 1 of <%= notification_count %>
<% end %>
-
<%= notification.title.html_safe %>
- <% if notification.page_content.present? %>
+ <%== render_for_banner(notification.title) %>
+ <% if notification.show_additional_page %>
- <%= govuk_link_to notification.link_text, notifications_path, class: "govuk-link--inverse govuk-!-font-weight-bold" %>
+ <%= govuk_link_to notification.link_text, notification_path(notification), class: "govuk-link--inverse govuk-!-font-weight-bold" %>
<% end %>
<% if current_user.present? %>
- <%= govuk_link_to "Dismiss", dismiss_notifications_path, class: "govuk-link--inverse" %>
+ <%= govuk_link_to "Dismiss", notification_dismiss_path(notification), class: "govuk-link--inverse" %>
<% end %>
diff --git a/app/views/notifications/_notification_home_section.html.erb b/app/views/notifications/_notification_home_section.html.erb
new file mode 100644
index 000000000..522bc2840
--- /dev/null
+++ b/app/views/notifications/_notification_home_section.html.erb
@@ -0,0 +1,17 @@
+
+
<%== I18n.t("active_notifications", count: active_notifications.count) %>
+ <% active_notifications.each do |notification| %>
+
+
+ <%== render_for_home(notification) %>
+
+
+ <%= govuk_link_to("Delete notification", notification_delete_confirmation_path(notification), class: "app-!-colour-red") %>
+
+
+ <% end %>
+
+
+
+ <%= govuk_button_link_to "Create a new notification", new_notification_path %>
+
diff --git a/app/views/notifications/check_answers.html.erb b/app/views/notifications/check_answers.html.erb
new file mode 100644
index 000000000..8ddbc0abe
--- /dev/null
+++ b/app/views/notifications/check_answers.html.erb
@@ -0,0 +1,61 @@
+<% content_for :title, "Create a notification" %>
+
+
+
+ <% content_for :before_content do %>
+ <%= govuk_back_link(href: :back) %>
+ <% end %>
+
+
+ Create a notification
+ Check your answers
+
+
+
This notification will be visible to all users until you delete it
+
+ <%= form_for(@notification, method: :patch) do |f| %>
+ <%= f.govuk_error_summary %>
+
+
+
+ <%= govuk_summary_list do |summary_list| %>
+ <% summary_list.with_row do |row| %>
+ <% row.with_key { "Title" } %>
+ <% row.with_value do %>
+ <%== render_for_summary(@notification.title) %>
+ <% end %>
+ <% row.with_action(text: "Change", href: edit_notification_path(@notification)) %>
+ <% end %>
+ <% summary_list.with_row do |row| %>
+ <% row.with_key { "Show on unauthenticated pages?" } %>
+ <% row.with_value { @notification.show_on_unauthenticated_pages ? "Yes" : "No" } %>
+ <% row.with_action(text: "Change", href: edit_notification_path(@notification)) %>
+ <% end %>
+ <% summary_list.with_row do |row| %>
+ <% row.with_key { "Link to additional information?" } %>
+ <% row.with_value { @notification.show_additional_page ? "Yes" : "No" } %>
+ <% row.with_action(text: "Change", href: edit_notification_path(@notification)) %>
+ <% end %>
+ <% if @notification.show_additional_page %>
+ <% summary_list.with_row do |row| %>
+ <% row.with_key { "Link text" } %>
+ <% row.with_value { @notification.link_text } %>
+ <% row.with_action(text: "Change", href: edit_notification_path(@notification)) %>
+ <% end %>
+ <% summary_list.with_row do |row| %>
+ <% row.with_key { "Page content" } %>
+ <% row.with_value do %>
+ <%= govuk_link_to "View page preview", notification_path(@notification), new_tab: true %>
+ <% end %>
+ <% row.with_action(text: "Change", href: edit_notification_path(@notification)) %>
+ <% end %>
+ <% end %>
+ <% end %>
+
+
+
+ <%= f.hidden_field :start_now, value: true %>
+ <%= f.govuk_submit "Create notification" %>
+ <% end %>
+
+
diff --git a/app/views/notifications/delete_confirmation.html.erb b/app/views/notifications/delete_confirmation.html.erb
new file mode 100644
index 000000000..4107c3050
--- /dev/null
+++ b/app/views/notifications/delete_confirmation.html.erb
@@ -0,0 +1,27 @@
+<% content_for :before_content do %>
+ <% content_for :title, "Are you sure you want to delete this notification?" %>
+ <%= govuk_back_link(href: :back) %>
+<% end %>
+
+
+
+
+ <%= content_for(:title) %>
+
+
+
<%== render_for_summary("**Notification:** #{@notification.title}") %>
+
+
Users will no longer see this notification.
+
+ <%= govuk_warning_text(text: "You will not be able to undo this action.") %>
+
+
+ <%= govuk_button_to(
+ "Delete notification",
+ notification_delete_path(@notification),
+ method: :delete,
+ ) %>
+ <%= govuk_button_link_to "Cancel", root_path, html: { method: :get }, secondary: true %>
+
+
+
diff --git a/app/views/notifications/edit.html.erb b/app/views/notifications/edit.html.erb
new file mode 100644
index 000000000..373cff20d
--- /dev/null
+++ b/app/views/notifications/edit.html.erb
@@ -0,0 +1,3 @@
+<%= form_for(@notification, as: :notification, method: :patch) do |f| %>
+ <% render partial: "form", locals: { notification: @notification, f: } %>
+<% end %>
diff --git a/app/views/notifications/new.html.erb b/app/views/notifications/new.html.erb
new file mode 100644
index 000000000..d996b9624
--- /dev/null
+++ b/app/views/notifications/new.html.erb
@@ -0,0 +1,3 @@
+<%= form_for(@notification, as: :notification, method: :post) do |f| %>
+ <% render partial: "form", locals: { notification: @notification, f: } %>
+<% end %>
diff --git a/app/views/notifications/show.html.erb b/app/views/notifications/show.html.erb
index abdc77044..a3933db55 100644
--- a/app/views/notifications/show.html.erb
+++ b/app/views/notifications/show.html.erb
@@ -5,10 +5,7 @@
-
<%= @notification.title %>
-
- <%= sanitize @notification.page_content %>
-
+ <%== render_for_page(@notification) %>
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 42ef43be1..c8c5cffc4 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -41,6 +41,11 @@ en:
create_password: "Create a password to finish setting up your account"
reset_password: "Reset your password"
+ active_notifications:
+ zero: "There are no active notifications"
+ one: "There is one active notification:"
+ other: "There are %{count} active notifications:"
+
activemodel:
errors:
models:
@@ -180,11 +185,19 @@ en:
attributes:
absorbing_organisation_id:
blank: "Select the absorbing organisation"
- merge_date:
+ merge_date:
blank: "Enter a merge date"
invalid: "Enter a valid merge date"
existing_absorbing_organisation:
blank: "You must answer absorbing organisation already active?"
+ notification:
+ attributes:
+ title:
+ blank: "Enter a title"
+ link_text:
+ blank_when_additional_page_set: "Enter the link text"
+ page_content:
+ blank_when_additional_page_set: "Enter the page content"
notification:
logs_deleted:
diff --git a/config/routes.rb b/config/routes.rb
index f2c86e37c..77b862e5a 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -142,8 +142,11 @@ Rails.application.routes.draw do
end
end
- resource :notifications do
+ resources :notifications do
get "dismiss", to: "notifications#dismiss"
+ get "check-answers", to: "notifications#check_answers"
+ get "delete-confirmation", to: "notifications#delete_confirmation"
+ delete "delete", to: "notifications#delete"
end
resources :organisations do
diff --git a/db/migrate/20240904135306_add_show_additional_page_column_to_notifications.rb b/db/migrate/20240904135306_add_show_additional_page_column_to_notifications.rb
new file mode 100644
index 000000000..c0992bb62
--- /dev/null
+++ b/db/migrate/20240904135306_add_show_additional_page_column_to_notifications.rb
@@ -0,0 +1,5 @@
+class AddShowAdditionalPageColumnToNotifications < ActiveRecord::Migration[7.0]
+ def change
+ add_column :notifications, :show_additional_page, :boolean
+ end
+end
diff --git a/db/schema.rb b/db/schema.rb
index 2d6808e6f..80463eaad 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema[7.0].define(version: 2024_09_11_152702) do
+ActiveRecord::Schema[7.0].define(version: 2024_09_18_112702) do
# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
@@ -55,7 +55,7 @@ ActiveRecord::Schema[7.0].define(version: 2024_09_11_152702) do
t.datetime "last_accessed"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
- t.check_constraint "log_type::text = ANY (ARRAY['lettings'::character varying::text, 'sales'::character varying::text])", name: "log_type_check"
+ t.check_constraint "log_type::text = ANY (ARRAY['lettings'::character varying, 'sales'::character varying]::text[])", name: "log_type_check"
t.check_constraint "year >= 2000 AND year <= 2099", name: "year_check"
end
@@ -206,14 +206,14 @@ ActiveRecord::Schema[7.0].define(version: 2024_09_11_152702) do
t.integer "hb"
t.integer "hbrentshortfall"
t.integer "property_relet"
- t.datetime "mrcdate", precision: nil
+ t.datetime "mrcdate"
t.integer "incref"
- t.datetime "startdate", precision: nil
+ t.datetime "startdate"
t.integer "armedforces"
t.integer "first_time_property_let_as_social_housing"
t.integer "unitletas"
t.integer "builtype"
- t.datetime "voiddate", precision: nil
+ t.datetime "voiddate"
t.bigint "owning_organisation_id"
t.bigint "managing_organisation_id"
t.integer "renttype"
@@ -459,6 +459,7 @@ ActiveRecord::Schema[7.0].define(version: 2024_09_11_152702) do
t.boolean "show_on_unauthenticated_pages"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
+ t.boolean "show_additional_page"
end
create_table "organisation_relationships", force: :cascade do |t|
@@ -779,8 +780,8 @@ ActiveRecord::Schema[7.0].define(version: 2024_09_11_152702) do
t.string "name"
t.bigint "organisation_id"
t.integer "sign_in_count", default: 0, null: false
- t.datetime "current_sign_in_at", precision: nil
- t.datetime "last_sign_in_at", precision: nil
+ t.datetime "current_sign_in_at"
+ t.datetime "last_sign_in_at"
t.string "current_sign_in_ip"
t.string "last_sign_in_ip"
t.integer "role"
diff --git a/spec/factories/notification.rb b/spec/factories/notification.rb
index 05d4faa3f..92d4bf4c9 100644
--- a/spec/factories/notification.rb
+++ b/spec/factories/notification.rb
@@ -6,5 +6,6 @@ FactoryBot.define do
start_date { Time.zone.yesterday }
end_date { Time.zone.tomorrow }
show_on_unauthenticated_pages { false }
+ show_additional_page { true }
end
end
diff --git a/spec/features/notifications_page_spec.rb b/spec/features/notifications_spec.rb
similarity index 51%
rename from spec/features/notifications_page_spec.rb
rename to spec/features/notifications_spec.rb
index 97bbeb7eb..e2bd4b151 100644
--- a/spec/features/notifications_page_spec.rb
+++ b/spec/features/notifications_spec.rb
@@ -1,7 +1,7 @@
require "rails_helper"
require_relative "form/helpers"
-RSpec.describe "Notifications Page Features" do
+RSpec.describe "Notifications Features" do
include Helpers
context "when there are notifications" do
@@ -9,32 +9,30 @@ RSpec.describe "Notifications Page Features" do
context "when the notifications are currently active" do
before do
- create(:notification, title: "Notification title 1")
- create(:notification, title: "Notification title 2")
- create(:notification, title: "Notification title 3")
+ create(:notification, start_date: Time.zone.yesterday, title: "Notification title 1")
+ create(:notification, start_date: Time.zone.yesterday, end_date: Time.zone.tomorrow, title: "Notification title 2")
sign_in user
- visit(notifications_path)
+ visit(root_path)
end
- it "does not show the notification banner" do
- expect(page).not_to have_content("Notification 1 of")
- expect(page).not_to have_link("Dismiss")
- expect(page).not_to have_link("Link text")
+ it "shows the notification banner" do
+ expect(page).to have_content("Notification 1 of")
+ expect(page).to have_link("Dismiss")
end
end
context "when the notifications are not currently active" do
before do
- create(:notification, end_date: Time.zone.yesterday, title: "Notification title 1")
+ create(:notification, start_date: Time.zone.yesterday, end_date: Time.zone.yesterday, title: "Notification title 1")
create(:notification, start_date: Time.zone.tomorrow, title: "Notification title 2")
+ create(:notification, start_date: nil, title: "Notification title 3")
sign_in user
- visit(notifications_path)
+ visit(root_path)
end
it "does not show the notifications banner" do
expect(page).not_to have_content("Notification 1 of")
expect(page).not_to have_link("Dismiss")
- expect(page).not_to have_link("Link text")
end
end
end
diff --git a/spec/features/start_page_spec.rb b/spec/features/start_page_spec.rb
index d90a0c1f0..ab09fd446 100644
--- a/spec/features/start_page_spec.rb
+++ b/spec/features/start_page_spec.rb
@@ -30,14 +30,15 @@ RSpec.describe "Start Page Features" do
end
context "when the unauthenticated user clicks a notification link" do
+ let!(:notification) { create(:notification, title: "Notification title", link_text: "link", page_content: "Some html content", show_on_unauthenticated_pages: true) }
+
before do
- create(:notification, show_on_unauthenticated_pages: true)
visit(root_path)
- click_link("Link text")
+ click_link("link")
end
it "takes them to the notification details page" do
- expect(page).to have_current_path(notifications_path)
+ expect(page).to have_current_path(notification_path(notification))
expect(page).to have_content("Notification title")
expect(page).to have_content("Some html content")
expect(page).to have_link("Back to Start")
diff --git a/spec/models/lettings_log_derived_fields_spec.rb b/spec/models/lettings_log_derived_fields_spec.rb
index 54dc438bc..aae1396d7 100644
--- a/spec/models/lettings_log_derived_fields_spec.rb
+++ b/spec/models/lettings_log_derived_fields_spec.rb
@@ -981,9 +981,9 @@ RSpec.describe LettingsLog, type: :model do
end
describe "deriving voiddate from startdate" do
- let(:startdate) { Time.zone.now }
+ let(:startdate) { Time.zone.now.beginning_of_day }
- it "correctly derives voiddate if the letting is a renewal and clears it if it is not" do
+ it "correctly derives voiddate if the letting is a renewal" do
log.assign_attributes(renewal: 1, startdate:)
expect { log.set_derived_fields! }.to change(log, :voiddate).to startdate
diff --git a/spec/models/notification_spec.rb b/spec/models/notification_spec.rb
new file mode 100644
index 000000000..86c02476f
--- /dev/null
+++ b/spec/models/notification_spec.rb
@@ -0,0 +1,37 @@
+require "rails_helper"
+
+RSpec.describe Notification, type: :model do
+ describe "#valid?" do
+ context "when show additional page is true" do
+ context "and page_content is blank" do
+ let(:notification) { build(:notification, show_additional_page: true, page_content: "") }
+
+ it "adds an error to page_content" do
+ notification.valid?
+
+ expect(notification.errors[:page_content]).to include("Enter the page content")
+ end
+ end
+
+ context "and link_text is blank" do
+ let(:notification) { build(:notification, show_additional_page: true, link_text: nil) }
+
+ it "adds an error to link_text" do
+ notification.valid?
+
+ expect(notification.errors[:link_text]).to include("Enter the link text")
+ end
+ end
+ end
+
+ context "when show additional page is false" do
+ context "and page_content and link_text are blank" do
+ let(:notification) { build(:notification, show_additional_page: false, link_text: nil, page_content: nil) }
+
+ it "is valid" do
+ expect(notification).to be_valid
+ end
+ end
+ end
+ end
+end
diff --git a/spec/requests/notifications_controller_spec.rb b/spec/requests/notifications_controller_spec.rb
new file mode 100644
index 000000000..0982057ab
--- /dev/null
+++ b/spec/requests/notifications_controller_spec.rb
@@ -0,0 +1,163 @@
+require "rails_helper"
+
+RSpec.describe NotificationsController, type: :request do
+ context "when user is signed in as a support user" do
+ let(:support_user) { create(:user, :support) }
+
+ before do
+ allow(support_user).to receive(:need_two_factor_authentication?).and_return(false)
+ sign_in support_user
+ end
+
+ describe "#create" do
+ let(:request) { post notifications_path, params: params }
+
+ context "with valid parameters" do
+ let(:params) { { "notification": { title: "Test Create", show_on_unauthenticated_pages: "1", show_additional_page: "1", link_text: "link", page_content: "page" } } }
+
+ it "creates a new notification with no start date set" do
+ request
+ notification = Notification.find_by(title: "Test Create")
+ expect(notification.show_on_unauthenticated_pages).to be(true)
+ expect(notification.show_additional_page).to be(true)
+ expect(notification.link_text).to eq("link")
+ expect(notification.page_content).to eq("page")
+ expect(notification.start_date).to be_nil
+ end
+
+ it "redirects to check answers page" do
+ request
+ notification = Notification.find_by(title: "Test Create")
+ expect(response).to redirect_to(notification_check_answers_path(notification))
+ end
+ end
+
+ context "with invalid parameters" do
+ let(:params) { { "notification": { title: "", show_on_unauthenticated_pages: "1" } } }
+
+ it "gives an error response" do
+ request
+ expect(response).to have_http_status(:unprocessable_entity)
+ end
+ end
+
+ context "when show additional page is false" do
+ let(:params) { { "notification": { title: "No Additional Page", show_on_unauthenticated_pages: "1", show_additional_page: "0", link_text: "text", page_content: "content" } } }
+
+ it "ignores values for link_text and page_content" do
+ request
+ notification = Notification.find_by(title: "No Additional Page")
+ expect(notification.link_text).to be_nil
+ expect(notification.page_content).to be_nil
+ end
+ end
+ end
+
+ describe "#update" do
+ let(:notification) { create(:notification, title: "Initial Title", start_date: nil, end_date: nil) }
+ let(:request) { patch notification_path(notification), params: params }
+
+ context "when start_now is set to true" do
+ let(:params) { { "notification": { start_now: true } } }
+
+ it "sets the start date on the notification" do
+ request
+ notification.reload
+ expect(notification.start_date).not_to be_nil
+ expect(notification.start_date).to be < Time.zone.now
+ end
+
+ it "redirects to the home page" do
+ request
+ expect(response).to redirect_to(root_path)
+ end
+ end
+
+ context "when start_now is not set" do
+ let(:params) { { "notification": { title: "Updated Title", show_on_unauthenticated_pages: "1" } } }
+
+ it "sets the relevant values on the notification" do
+ request
+ notification.reload
+ expect(notification.title).to eql("Updated Title")
+ expect(notification.start_date).to be_nil
+ end
+
+ it "redirects to check answers" do
+ request
+ expect(response).to redirect_to(notification_check_answers_path(notification))
+ end
+ end
+
+ context "when show additional page is false" do
+ let(:notification) { create(:notification, show_additional_page: "0", link_text: "link", page_content: "page") }
+ let(:params) { { "notification": { show_additional_page: "0", link_text: "text", page_content: "content" } } }
+
+ it "removes values for link_text and page_content" do
+ request
+ notification.reload
+ expect(notification.link_text).to be_nil
+ expect(notification.page_content).to be_nil
+ end
+ end
+ end
+
+ describe "#delete" do
+ let(:notification) { create(:notification, end_date: nil) }
+ let(:request) { delete notification_delete_path(notification) }
+
+ it "sets end_date on the notification" do
+ request
+ notification.reload
+ expect(notification.end_date).to be < Time.zone.now
+ end
+ end
+ end
+
+ context "when user is signed in as a non-support user" do
+ let(:user) { create(:user, :data_coordinator) }
+
+ before do
+ sign_in user
+ end
+
+ describe "#create" do
+ let(:request) { post notifications_path, params: { "notification": { title: "Test Create" } } }
+
+ it "returns not found" do
+ request
+ expect(response).to have_http_status(:not_found)
+ end
+
+ it "does not create a notification" do
+ expect { request }.not_to change(Notification, :count)
+ end
+ end
+
+ describe "#update" do
+ let(:notification) { create(:notification) }
+ let(:request) { patch notification_path(notification), params: { "notification": { title: "Test Update" } } }
+
+ it "returns not found" do
+ request
+ expect(response).to have_http_status(:not_found)
+ end
+ end
+
+ describe "#delete" do
+ let(:notification) { create(:notification, end_date: nil) }
+ let(:request) { delete notification_delete_path(notification) }
+
+ it "returns not found" do
+ request
+ expect(response).to have_http_status(:not_found)
+ end
+
+ it "does not set end_date on the notification" do
+ request
+ notification.reload
+ expect(notification.end_date).to be_nil
+ end
+ end
+ end
+end