More use of bulk_upload.year_combo in request tests

spec/requests/bulk_upload_sales_results_controller_spec.rb

@@ -16,7 +16,7 @@ RSpec.describe BulkUploadSalesResultsController, type: :request do
       get "/sales-logs/bulk-upload-results/#{bulk_upload.id}"
 
       expect(response).to be_successful
-      expect(response.body).to include("Bulk Upload for sales (2023/24)")
+      expect(response.body).to include("Bulk Upload for sales (#{bulk_upload.year_combo})")
     end
 
     it "renders correct number of errors" do

spec/requests/bulk_upload_sales_soft_validations_check_controller_spec.rb

@@ -15,7 +15,7 @@ RSpec.describe BulkUploadSalesSoftValidationsCheckController, type: :request do
       get "/sales-logs/bulk-upload-soft-validations-check/#{bulk_upload.id}/confirm-soft-errors"
 
       expect(response.body).to include("Bulk upload for sales")
-      expect(response.body).to include("2023/24")
+      expect(response.body).to include(bulk_upload.year_combo)
       expect(response.body).to include("Check these 2 answers")
       expect(response.body).to include(bulk_upload.filename)
       expect(response.body).to include("Are these fields correct?")