Browse Source

CLDC-2670: Fix build errors

pull/2362/head
Robert Sullivan 2 years ago
parent
commit
6d8bf2bb5c
  1. 2
      app/helpers/form_page_helper.rb
  2. 2
      app/views/form/_check_answers_summary_list.html.erb
  3. 4
      spec/features/form/validations_spec.rb

2
app/helpers/form_page_helper.rb

@ -1,5 +1,5 @@
module FormPageHelper module FormPageHelper
def action_href(log, page_id, referrer) def action_href(log, page_id, referrer = "check_answers")
send("#{log.model_name.param_key}_#{page_id}_path", log, referrer:) send("#{log.model_name.param_key}_#{page_id}_path", log, referrer:)
end end

2
app/views/form/_check_answers_summary_list.html.erb

@ -28,7 +28,7 @@
<% if @log.collection_period_open_for_editing? %> <% if @log.collection_period_open_for_editing? %>
<% row.with_action( <% row.with_action(
text: question.action_text(@log), text: question.action_text(@log),
href: action_href(@log, question.page.id, (question.displayed_as_answered?(@log) || refer_unanswered) ? referrer : nil), href: action_href(@log, question.page.id, question.displayed_as_answered?(@log) || refer_unanswered ? referrer : nil),
visually_hidden_text: question.check_answer_label.to_s.downcase, visually_hidden_text: question.check_answer_label.to_s.downcase,
) %> ) %>
<% end %> <% end %>

4
spec/features/form/validations_spec.rb

@ -174,8 +174,8 @@ RSpec.describe "validations" do
it "returns the user back to the check_your_answers after fixing a validation from check_your_anwers" do it "returns the user back to the check_your_answers after fixing a validation from check_your_anwers" do
lettings_log.update!(earnings: income_over_soft_limit, incfreq: 1) lettings_log.update!(earnings: income_over_soft_limit, incfreq: 1)
visit("/lettings-logs/#{lettings_log.id}/income-and-benefits/check-answers") visit("/lettings-logs/#{lettings_log.id}/income-and-benefits/check-answers")
click_link("Answer", href: "/lettings-logs/#{lettings_log.id}/net-income-value-check?referrer=check_answers") click_link("Answer", href: "/lettings-logs/#{lettings_log.id}/net-income-value-check")
expect(page).to have_current_path("/lettings-logs/#{lettings_log.id}/net-income-value-check?referrer=check_answers") expect(page).to have_current_path("/lettings-logs/#{lettings_log.id}/net-income-value-check")
click_link("Change", href: "/lettings-logs/#{lettings_log.id}/net-income?referrer=interruption_screen", match: :first) click_link("Change", href: "/lettings-logs/#{lettings_log.id}/net-income?referrer=interruption_screen", match: :first)
expect(page).to have_current_path("/lettings-logs/#{lettings_log.id}/net-income?referrer=interruption_screen") expect(page).to have_current_path("/lettings-logs/#{lettings_log.id}/net-income?referrer=interruption_screen")
fill_in("lettings-log-earnings-field", with: income_under_soft_limit) fill_in("lettings-log-earnings-field", with: income_under_soft_limit)

Loading…
Cancel
Save