From 6ba550c7c7141e20272027f345138df7d5fd0ab2 Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Thu, 1 Feb 2024 14:00:25 +0000 Subject: [PATCH] refactor: lint --- .../form/sales/pages/buyer_live_spec.rb | 6 +++++ .../buyer2_ethnic_background_white_spec.rb | 23 ++++++++++++------- 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/spec/models/form/sales/pages/buyer_live_spec.rb b/spec/models/form/sales/pages/buyer_live_spec.rb index 685798f59..be75458b3 100644 --- a/spec/models/form/sales/pages/buyer_live_spec.rb +++ b/spec/models/form/sales/pages/buyer_live_spec.rb @@ -6,6 +6,12 @@ RSpec.describe Form::Sales::Pages::BuyerLive, type: :model do let(:page_id) { nil } let(:page_definition) { nil } let(:subsection) { instance_double(Form::Subsection) } + let(:form) { instance_double(Form) } + + before do + allow(form).to receive(:start_year_after_2024?).and_return(false) + allow(subsection).to receive(:form).and_return(form) + end it "has correct subsection" do expect(page.subsection).to eq(subsection) diff --git a/spec/models/form/sales/questions/buyer2_ethnic_background_white_spec.rb b/spec/models/form/sales/questions/buyer2_ethnic_background_white_spec.rb index dc7bec153..5884c51ef 100644 --- a/spec/models/form/sales/questions/buyer2_ethnic_background_white_spec.rb +++ b/spec/models/form/sales/questions/buyer2_ethnic_background_white_spec.rb @@ -44,8 +44,13 @@ RSpec.describe Form::Sales::Questions::Buyer2EthnicBackgroundWhite, type: :model end context "with 2023/24 form" do - it "has the correct header" do - expect(question.header).to eq("Will the buyers live in the property?") + it "has the correct answer_options" do + expect(question.answer_options).to eq({ + "1" => { "value" => "English, Welsh, Northern Irish, Scottish or British" }, + "2" => { "value" => "Irish" }, + "18" => { "value" => "Gypsy or Irish Traveller" }, + "3" => { "value" => "Any other White background" }, + }) end end @@ -53,13 +58,15 @@ RSpec.describe Form::Sales::Questions::Buyer2EthnicBackgroundWhite, type: :model before do allow(form).to receive(:start_year_after_2024?).and_return(true) end - - it "has the correct header" do - expect(question.header).to eq("Will any buyers live in the property?") - end end - it "has the correct check_answers_card_number" do - expect(question.check_answers_card_number).to eq(2) + it "has the correct answer_options" do + expect(question.answer_options).to eq({ + "1" => { "value" => "English, Welsh, Northern Irish, Scottish or British" }, + "2" => { "value" => "Irish" }, + "18" => { "value" => "Gypsy or Irish Traveller" }, + "20" => { "value" => "Roma" }, + "3" => { "value" => "Any other White background" }, + }) end end