From 688ed87ef433d733483ce0a527dca4297fb6fc48 Mon Sep 17 00:00:00 2001 From: Kat Date: Wed, 18 Oct 2023 15:39:27 +0100 Subject: [PATCH] Remove uprn validation for supported housing logs --- .../lettings/year2023/row_parser.rb | 2 +- .../lettings/year2023/row_parser_spec.rb | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/app/services/bulk_upload/lettings/year2023/row_parser.rb b/app/services/bulk_upload/lettings/year2023/row_parser.rb index 413e0b10f..84bf2481b 100644 --- a/app/services/bulk_upload/lettings/year2023/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2023/row_parser.rb @@ -402,7 +402,7 @@ class BulkUpload::Lettings::Year2023::RowParser validate :validate_nulls, on: :after_log - validate :validate_uprn_exists_if_any_key_address_fields_are_blank, on: :after_log + validate :validate_uprn_exists_if_any_key_address_fields_are_blank, on: :after_log, unless: -> { supported_housing? } validate :validate_incomplete_soft_validations, on: :after_log diff --git a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb index 6959dff29..d12d833f5 100644 --- a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb @@ -1455,6 +1455,24 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do end end + context "when neither UPRN nor address fields are given for a supported housing record" do + let(:bulk_upload) { create(:bulk_upload, :lettings, user:, needstype: 2) } + let(:attributes) do + { bulk_upload:, + field_15: scheme.old_visible_id, + field_4: "2", + field_5: "2", + field_16: location.old_visible_id, + field_1: "1" } + end + + it "does not add UPRN errors" do + expect(parser.errors[:field_18]).to be_empty + expect(parser.errors[:field_19]).to be_empty + expect(parser.errors[:field_21]).to be_empty + end + end + context "when UPRN is given but address fields are not" do let(:attributes) do {