Browse Source

refactor: linting

pull/1753/head
natdeanlewissoftwire 3 years ago
parent
commit
63e1b187d4
  1. 114
      spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

114
spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

@ -266,13 +266,13 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do
expect(questions.map(&:id)).to eql([]) expect(questions.map(&:id)).to eql([])
end end
context "when a general needs log already exists in the db" do context "when a general needs log already exists in the db" do
let(:attributes) { { bulk_upload:, field_4: "1" } } let(:attributes) { { bulk_upload:, field_4: "1" } }
before do before do
parser.log.save! parser.log.save!
parser.instance_variable_set(:@valid, nil) parser.instance_variable_set(:@valid, nil)
end end
it "is not a valid row" do it "is not a valid row" do
expect(parser).not_to be_valid expect(parser).not_to be_valid
@ -283,66 +283,66 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do
error_message = "This is a duplicate log" error_message = "This is a duplicate log"
[ [
:field_1, # owning_organisation :field_1, # owning_organisation
:field_7, # startdate :field_7, # startdate
:field_8, # startdate :field_8, # startdate
:field_9, # startdate :field_9, # startdate
:field_13, # tenancycode :field_13, # tenancycode
:field_14, # propcode :field_14, # propcode
:field_23, # postcode_full :field_23, # postcode_full
:field_24, # postcode_full :field_24, # postcode_full
:field_25, # postcode_full :field_25, # postcode_full
:field_46, # age1 :field_46, # age1
:field_47, # sex1 :field_47, # sex1
:field_50, # ecstat1 :field_50, # ecstat1
:field_132, # tcharge :field_132, # tcharge
].each do |field| ].each do |field|
expect(parser.errors[field]).to include(error_message) expect(parser.errors[field]).to include(error_message)
end end
expect(parser.errors[:field_17]).not_to include(error_message) expect(parser.errors[:field_17]).not_to include(error_message)
end
end end
end
context "when a supported housing log already exists in the db" do context "when a supported housing log already exists in the db" do
let(:attributes) { { bulk_upload:, field_4: "2" } } let(:attributes) { { bulk_upload:, field_4: "2" } }
before do before do
parser.log.save! parser.log.save!
parser.instance_variable_set(:@valid, nil) parser.instance_variable_set(:@valid, nil)
end end
it "is not a valid row" do it "is not a valid row" do
expect(parser).not_to be_valid expect(parser).not_to be_valid
end end
it "adds an error to all the fields used to determine duplicates" do it "adds an error to all the fields used to determine duplicates" do
parser.valid? parser.valid?
error_message = "This is a duplicate log" error_message = "This is a duplicate log"
[ [
:field_1, # owning_organisation :field_1, # owning_organisation
:field_7, # startdate :field_7, # startdate
:field_8, # startdate :field_8, # startdate
:field_9, # startdate :field_9, # startdate
:field_13, # tenancycode :field_13, # tenancycode
:field_14, # propcode :field_14, # propcode
:field_17, # location :field_17, # location
:field_46, # age1 :field_46, # age1
:field_47, # sex1 :field_47, # sex1
:field_50, # ecstat1 :field_50, # ecstat1
:field_132, # tcharge :field_132, # tcharge
].each do |field| ].each do |field|
expect(parser.errors[field]).to include(error_message) expect(parser.errors[field]).to include(error_message)
end end
expect(parser.errors[:field_23]).not_to include(error_message) expect(parser.errors[:field_23]).not_to include(error_message)
expect(parser.errors[:field_24]).not_to include(error_message) expect(parser.errors[:field_24]).not_to include(error_message)
expect(parser.errors[:field_25]).not_to include(error_message) expect(parser.errors[:field_25]).not_to include(error_message)
end
end end
end
context "when a hidden log already exists in db" do context "when a hidden log already exists in db" do
before do before do

Loading…
Cancel
Save