Browse Source

fix: ignore BU rows which contain whitespace only

pull/1587/head
Sam Seed 3 years ago
parent
commit
6254f118fe
  1. 1
      app/services/bulk_upload/lettings/year2022/row_parser.rb
  2. 1
      app/services/bulk_upload/lettings/year2023/row_parser.rb
  3. 12
      spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb
  4. 12
      spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

1
app/services/bulk_upload/lettings/year2022/row_parser.rb

@ -368,6 +368,7 @@ class BulkUpload::Lettings::Year2022::RowParser
.to_hash
.reject { |k, _| %w[bulk_upload block_log_creation].include?(k) }
.values
.reject(&:blank?)
.compact
.empty?
end

1
app/services/bulk_upload/lettings/year2023/row_parser.rb

@ -373,6 +373,7 @@ class BulkUpload::Lettings::Year2023::RowParser
.to_hash
.reject { |k, _| %w[bulk_upload block_log_creation field_blank].include?(k) }
.values
.reject(&:blank?)
.compact
.empty?
end

12
spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb

@ -165,7 +165,17 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do
end
end
context "when any field is populated" do
context "when the only populated fields are whitespace" do
before do
parser.field_18 = " "
end
it "returns true" do
expect(parser).to be_blank_row
end
end
context "when any field is populated with something other than whitespace" do
before do
parser.field_1 = "1"
end

12
spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

@ -48,7 +48,17 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do
end
end
context "when any field is populated" do
context "when the only populated fields are whitespace" do
before do
parser.field_18 = " "
end
it "returns true" do
expect(parser).to be_blank_row
end
end
context "when any field is populated with something other than whitespace" do
before do
parser.field_1 = "1"
end

Loading…
Cancel
Save