From 5daccf76796b3f8334bcbba56e3b6699ff5e3ee1 Mon Sep 17 00:00:00 2001 From: Kat Date: Thu, 20 Jul 2023 12:16:41 +0100 Subject: [PATCH] Fix a flaky test --- spec/requests/sales_logs_controller_spec.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/requests/sales_logs_controller_spec.rb b/spec/requests/sales_logs_controller_spec.rb index abe10af8e..0305690f8 100644 --- a/spec/requests/sales_logs_controller_spec.rb +++ b/spec/requests/sales_logs_controller_spec.rb @@ -354,8 +354,8 @@ RSpec.describe SalesLogsController, type: :request do let(:user) { create(:user, organisation:) } let(:bulk_upload) { create(:bulk_upload, :sales, user:) } - let!(:included_log) { create(:sales_log, :in_progress, bulk_upload:, owning_organisation: organisation) } - let!(:excluded_log) { create(:sales_log, :in_progress, owning_organisation: organisation) } + let!(:included_log) { create(:sales_log, :in_progress, purchid: "included_id", bulk_upload:, owning_organisation: organisation) } + let!(:excluded_log) { create(:sales_log, :in_progress, purchid: "excluded_id", owning_organisation: organisation) } before do create(:bulk_upload_error, bulk_upload:, col: "A", row: 1) @@ -364,8 +364,8 @@ RSpec.describe SalesLogsController, type: :request do it "returns logs only associated with the bulk upload" do get "/sales-logs?bulk_upload_id[]=#{bulk_upload.id}" - expect(page).to have_content(included_log.id) - expect(page).not_to have_content(excluded_log.id) + expect(page).to have_content(included_log.purchid) + expect(page).not_to have_content(excluded_log.purchid) end it "dislays bulk upload banner" do