From 5b2481e51ffd05ecfbec43eacd1ea7208f584382 Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Wed, 1 Nov 2023 16:43:55 +0000 Subject: [PATCH] refactor --- app/models/form/lettings/pages/address.rb | 3 +-- app/models/form/sales/pages/address.rb | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/app/models/form/lettings/pages/address.rb b/app/models/form/lettings/pages/address.rb index 3f9c81cac..389ce172a 100644 --- a/app/models/form/lettings/pages/address.rb +++ b/app/models/form/lettings/pages/address.rb @@ -16,9 +16,8 @@ class Form::Lettings::Pages::Address < ::Form::Page end def routed_to?(log, _current_user = nil) - return true if log.uprn_known.nil? return false if log.is_supported_housing? - log.uprn_known.zero? || log.uprn_confirmed&.zero? + log.uprn_known.nil? || log.uprn_known.zero? || log.uprn_confirmed&.zero? end end diff --git a/app/models/form/sales/pages/address.rb b/app/models/form/sales/pages/address.rb index c6c9b2f5c..134dcdccc 100644 --- a/app/models/form/sales/pages/address.rb +++ b/app/models/form/sales/pages/address.rb @@ -16,8 +16,6 @@ class Form::Sales::Pages::Address < ::Form::Page end def routed_to?(log, _current_user = nil) - return true if log.uprn_known.nil? - - log.uprn_known.zero? || log.uprn_confirmed&.zero? + log.uprn_known.nil? || log.uprn_known.zero? || log.uprn_confirmed&.zero? end end