CLDC-4307: update tests

spec/models/form/sales/questions/buyer1_income_known_spec.rb

@@ -1,11 +1,12 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::Buyer1IncomeKnown, type: :model do
+  include CollectionTimeHelper
   subject(:question) { described_class.new(question_id, question_definition, page) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: collection_start_date_for_year(current_collection_start_year)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)
@@ -39,4 +40,8 @@ RSpec.describe Form::Sales::Questions::Buyer1IncomeKnown, type: :model do
   it "has the correct check_answers_card_number" do
     expect(question.check_answers_card_number).to eq(1)
   end
+
+  it "has the correct hint_text" do
+    expect(question.hint_text).to eq("Provide the gross annual income (i.e. salary before tax) plus the annual amount of benefits, Universal Credit or pensions, and income from investments.")
+  end
 end

spec/models/form/sales/questions/buyer1_income_spec.rb

@@ -1,11 +1,12 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::Buyer1Income, type: :model do
+  include CollectionTimeHelper
   subject(:question) { described_class.new(question_id, question_definition, page) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: collection_start_date_for_year(current_collection_start_year)))) }
 
   it "has correct page" do
     expect(question.page).to eq(page)
@@ -46,4 +47,8 @@ RSpec.describe Form::Sales::Questions::Buyer1Income, type: :model do
   it "has correct max" do
     expect(question.max).to eq(999_999)
   end
+
+  it "has the correct hint_text" do
+    expect(question.hint_text).to eq("")
+  end
 end