From 5a8978798cf2960dc11f22fd0b599bb324b181ef Mon Sep 17 00:00:00 2001
From: Kat <katrina@kosiak.co.uk>
Date: Thu, 3 Aug 2023 14:40:02 +0100
Subject: [PATCH] Add absorbing org dates, fix copy

---
 .../questions/managing_organisation.rb         | 12 ++++++------
 .../questions/managing_organisation_spec.rb    | 18 +++++++++---------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/app/models/form/lettings/questions/managing_organisation.rb b/app/models/form/lettings/questions/managing_organisation.rb
index fba91fb60..e22bf0c3d 100644
--- a/app/models/form/lettings/questions/managing_organisation.rb
+++ b/app/models/form/lettings/questions/managing_organisation.rb
@@ -23,22 +23,22 @@ class Form::Lettings::Questions::ManagingOrganisation < ::Form::Question
       if log.owning_organisation.holds_own_stock?
         opts[log.owning_organisation.id] = "#{log.owning_organisation.name} (Owning organisation)"
       end
+    elsif user.organisation.absorbed_organisations.exists?
+      opts[user.organisation.id] = "#{user.organisation.name} (Your organisation, active as of #{user.organisation.created_at.to_fs(:govuk_date)})"
     else
       opts[user.organisation.id] = "#{user.organisation.name} (Your organisation)"
     end
 
     orgs = if user.support?
              log.owning_organisation.managing_agents
-           else
-            if user.organisation.absorbed_organisations.include?(log.owning_organisation)
+           elsif user.organisation.absorbed_organisations.include?(log.owning_organisation)
              user.organisation.managing_agents + log.owning_organisation.managing_agents
-            else
-              user.organisation.managing_agents
-            end
+           else
+             user.organisation.managing_agents
            end.pluck(:id, :name).to_h
 
     user.organisation.absorbed_organisations.each do |absorbed_org|
-      opts[absorbed_org.id] = "#{absorbed_org.name} (active until #{absorbed_org.merge_date.to_fs(:govuk_date)})"
+      opts[absorbed_org.id] = "#{absorbed_org.name} (inactive as of #{absorbed_org.merge_date.to_fs(:govuk_date)})"
     end
 
     opts.merge(orgs)
diff --git a/spec/models/form/lettings/questions/managing_organisation_spec.rb b/spec/models/form/lettings/questions/managing_organisation_spec.rb
index f6a346e2a..64bb84181 100644
--- a/spec/models/form/lettings/questions/managing_organisation_spec.rb
+++ b/spec/models/form/lettings/questions/managing_organisation_spec.rb
@@ -163,7 +163,7 @@ RSpec.describe Form::Lettings::Questions::ManagingOrganisation, type: :model do
     end
 
     context "when organisation has merged" do
-      let(:absorbing_org) { create(:organisation, name: "Absorbing org", holds_own_stock: true) }
+      let(:absorbing_org) { create(:organisation, name: "Absorbing org", holds_own_stock: true, created_at: Time.zone.local(2023, 8, 3)) }
       let!(:merged_org) { create(:organisation, name: "Merged org", holds_own_stock: false) }
       let(:user) { create(:user, :data_coordinator, organisation: absorbing_org) }
 
@@ -175,24 +175,24 @@ RSpec.describe Form::Lettings::Questions::ManagingOrganisation, type: :model do
       it "displays merged organisation on the list of choices" do
         options = {
           "" => "Select an option",
-          absorbing_org.id => "Absorbing org (Your organisation)",
-          merged_org.id => "Merged org (active until 2 August 2023)",
-          merged_org.id => "Merged org (active until 2 August 2023)",
+          absorbing_org.id => "Absorbing org (Your organisation, active as of 3 August 2023)",
+          merged_org.id => "Merged org (inactive as of 2 August 2023)",
+          merged_org.id => "Merged org (inactive as of 2 August 2023)",
         }
         expect(question.displayed_answer_options(log, user)).to eq(options)
       end
 
-      it "displays managing agents of merged organisation selected as owning org" do        
-        managing_agent = create(:organisation, name: "Managing org 1") 
+      it "displays managing agents of merged organisation selected as owning org" do
+        managing_agent = create(:organisation, name: "Managing org 1")
         create(:organisation_relationship, parent_organisation: merged_org, child_organisation: managing_agent)
 
         options = {
           "" => "Select an option",
-          merged_org.id => "Merged org (active until 2 August 2023)",
-          absorbing_org.id => "Absorbing org (Your organisation)",
+          merged_org.id => "Merged org (inactive as of 2 August 2023)",
+          absorbing_org.id => "Absorbing org (Your organisation, active as of 3 August 2023)",
           managing_agent.id => "Managing org 1",
         }
-        
+
         log.update!(owning_organisation: merged_org)
         expect(question.displayed_answer_options(log, user)).to eq(options)
       end