From 5873bef70aea21defed8fc8af16ea4e80f9498d0 Mon Sep 17 00:00:00 2001 From: samyou-softwire Date: Thu, 26 Feb 2026 17:24:45 +0000 Subject: [PATCH] fixup! CLDC-4164: Update tests add min tests for 25 and 26 --- .../sales/questions/purchase_price_spec.rb | 27 ++++++++++++++++--- .../models/form/sales/questions/value_spec.rb | 23 +++++++++++++--- 2 files changed, 44 insertions(+), 6 deletions(-) diff --git a/spec/models/form/sales/questions/purchase_price_spec.rb b/spec/models/form/sales/questions/purchase_price_spec.rb index 06cd8e95d..6790b4a35 100644 --- a/spec/models/form/sales/questions/purchase_price_spec.rb +++ b/spec/models/form/sales/questions/purchase_price_spec.rb @@ -1,11 +1,15 @@ require "rails_helper" RSpec.describe Form::Sales::Questions::PurchasePrice, type: :model do + include CollectionTimeHelper + subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) } let(:question_id) { nil } let(:question_definition) { nil } - let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1), start_year_2026_or_later?: false))) } + let(:start_year) { current_collection_start_year } + let(:start_year_2026_or_later?) { false } + let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: collection_start_date_for_year(start_year), start_year_2026_or_later?: start_year_2026_or_later?))) } it "has correct page" do expect(question.page).to eq(page) @@ -30,6 +34,8 @@ RSpec.describe Form::Sales::Questions::PurchasePrice, type: :model do context "when discounted ownership scheme" do subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 2) } + let(:start_year) { 2023 } + it "has the correct question_number" do expect(question.question_number).to eq(100) end @@ -38,6 +44,8 @@ RSpec.describe Form::Sales::Questions::PurchasePrice, type: :model do context "when outright sale" do subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 3) } + let(:start_year) { 2023 } + it "has the correct question_number" do expect(question.question_number).to eq(110) end @@ -51,7 +59,20 @@ RSpec.describe Form::Sales::Questions::PurchasePrice, type: :model do expect(question.prefix).to eq("£") end - it "has correct min" do - expect(question.min).to eq(0) + context "with year 2025", metadata: { year: 25 } do + let(:start_year) { 2025 } + + it "has correct min" do + expect(question.min).to eq(0) + end + end + + context "with year 2026", metadata: { year: 26 } do + let(:start_year) { 2026 } + let(:start_year_2026_or_later?) { true } + + it "has correct min" do + expect(question.min).to eq(15_000) + end end end diff --git a/spec/models/form/sales/questions/value_spec.rb b/spec/models/form/sales/questions/value_spec.rb index 6ed07e0c9..2ebbf6d89 100644 --- a/spec/models/form/sales/questions/value_spec.rb +++ b/spec/models/form/sales/questions/value_spec.rb @@ -1,11 +1,15 @@ require "rails_helper" RSpec.describe Form::Sales::Questions::Value, type: :model do + include CollectionTimeHelper + subject(:question) { described_class.new(question_id, question_definition, page) } let(:question_id) { nil } let(:question_definition) { nil } - let(:page) { instance_double(Form::Page, id: "value_shared_ownership", subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1), start_year_2026_or_later?: false), id: "shared_ownership")) } + let(:start_year) { current_collection_start_year } + let(:start_year_2026_or_later?) { false } + let(:page) { instance_double(Form::Page, id: "value_shared_ownership", subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: collection_start_date_for_year(start_year), start_year_2026_or_later?: start_year_2026_or_later?), id: "shared_ownership")) } before do allow(page.subsection.form).to receive(:start_year_2025_or_later?).and_return(false) @@ -35,7 +39,20 @@ RSpec.describe Form::Sales::Questions::Value, type: :model do expect(question.prefix).to eq("£") end - it "has correct min" do - expect(question.min).to eq(0) + context "with year 2025", metadata: { year: 25 } do + let(:start_year) { 2025 } + + it "has correct min" do + expect(question.min).to eq(0) + end + end + + context "with year 2026", metadata: { year: 26 } do + let(:start_year) { 2026 } + let(:start_year_2026_or_later?) { true } + + it "has correct min" do + expect(question.min).to eq(15_000) + end end end