Browse Source

feat: allow uprn known to be skipped, and set 0.4 min precision

pull/2278/head
natdeanlewissoftwire 2 years ago
parent
commit
575ef2ca21
  1. 1
      app/models/form/lettings/pages/address_matcher.rb
  2. 2
      app/models/form/lettings/pages/address_selection.rb
  3. 2
      app/services/address_client.rb

1
app/models/form/lettings/pages/address_matcher.rb

@ -4,6 +4,7 @@ class Form::Lettings::Pages::AddressMatcher < ::Form::Page
@id = "address_matcher" @id = "address_matcher"
@header = "Find an address" @header = "Find an address"
@depends_on = [ @depends_on = [
{ "is_supported_housing?" => false, "uprn_known" => nil },
{ "is_supported_housing?" => false, "uprn_known" => 0 }, { "is_supported_housing?" => false, "uprn_known" => 0 },
{ "is_supported_housing?" => false, "uprn_confirmed" => 0 }, { "is_supported_housing?" => false, "uprn_confirmed" => 0 },
] ]

2
app/models/form/lettings/pages/address_selection.rb

@ -13,7 +13,7 @@ class Form::Lettings::Pages::AddressSelection < ::Form::Page
end end
def routed_to?(log, _current_user = nil) def routed_to?(log, _current_user = nil)
log.uprn_known.present? && log.uprn_known.zero? && log.address_line1_input.present? && log.postcode_full_input.present? && (1..10).cover?(log.address_options&.count) (log.uprn_known.nil? || log.uprn_known.zero?) && log.address_line1_input.present? && log.postcode_full_input.present? && (1..10).cover?(log.address_options&.count)
end end
def skip_text def skip_text

2
app/services/address_client.rb

@ -40,7 +40,7 @@ private
query: address, query: address,
key: ENV["OS_DATA_KEY"], key: ENV["OS_DATA_KEY"],
maxresults: 10, maxresults: 10,
minmatch: 0.6, minmatch: 0.4,
} }
uri.query = URI.encode_www_form(params) uri.query = URI.encode_www_form(params)
uri.to_s uri.to_s

Loading…
Cancel
Save