diff --git a/app/models/form/common/questions/created_by_id.rb b/app/models/form/common/questions/created_by_id.rb index a67e33776..5b6631868 100644 --- a/app/models/form/common/questions/created_by_id.rb +++ b/app/models/form/common/questions/created_by_id.rb @@ -4,7 +4,6 @@ class Form::Common::Questions::CreatedById < ::Form::Question @id = "created_by_id" @check_answer_label = "User" @header = "Which user are you creating this log for?" - @hint_text = "" @type = "select" end diff --git a/app/models/form/common/questions/owning_organisation_id.rb b/app/models/form/common/questions/owning_organisation_id.rb index 624289797..c09968ef9 100644 --- a/app/models/form/common/questions/owning_organisation_id.rb +++ b/app/models/form/common/questions/owning_organisation_id.rb @@ -4,7 +4,6 @@ class Form::Common::Questions::OwningOrganisationId < ::Form::Question @id = "owning_organisation_id" @check_answer_label = "Owning organisation" @header = "Which organisation owns this log?" - @hint_text = "" @type = "select" end diff --git a/app/models/form/lettings/questions/created_by_id.rb b/app/models/form/lettings/questions/created_by_id.rb index 855a00891..d61be8882 100644 --- a/app/models/form/lettings/questions/created_by_id.rb +++ b/app/models/form/lettings/questions/created_by_id.rb @@ -4,7 +4,6 @@ class Form::Lettings::Questions::CreatedById < ::Form::Question @id = "created_by_id" @check_answer_label = "Log owner" @header = "Which user are you creating this log for?" - @hint_text = "" @type = "select" end diff --git a/app/models/form/lettings/questions/location_id.rb b/app/models/form/lettings/questions/location_id.rb index 84b37ec50..07ed61318 100644 --- a/app/models/form/lettings/questions/location_id.rb +++ b/app/models/form/lettings/questions/location_id.rb @@ -3,7 +3,6 @@ class Form::Lettings::Questions::LocationId < ::Form::Question super("location_id", hsh, page) @check_answer_label = "Location" @header = "Which location is this log for?" - @hint_text = "" @type = "radio" @answer_options = answer_options @inferred_answers = { diff --git a/app/models/form/lettings/questions/renewal.rb b/app/models/form/lettings/questions/renewal.rb index efab7117e..1282984cc 100644 --- a/app/models/form/lettings/questions/renewal.rb +++ b/app/models/form/lettings/questions/renewal.rb @@ -4,7 +4,6 @@ class Form::Lettings::Questions::Renewal < ::Form::Question @id = "renewal" @check_answer_label = "Property renewal" @header = "Is this letting a renewal?" - @hint_text = "" @type = "radio" @answer_options = ANSWER_OPTIONS end diff --git a/app/models/form/lettings/questions/rent_type.rb b/app/models/form/lettings/questions/rent_type.rb index 11ce46d17..64e2839e2 100644 --- a/app/models/form/lettings/questions/rent_type.rb +++ b/app/models/form/lettings/questions/rent_type.rb @@ -4,7 +4,6 @@ class Form::Lettings::Questions::RentType < ::Form::Question @id = "rent_type" @check_answer_label = "Rent type" @header = "What is the rent type?" - @hint_text = "" @type = "radio" @answer_options = ANSWER_OPTIONS @conditional_for = { "irproduct_other" => [5] } diff --git a/app/models/form/sales/questions/armed_forces_spouse.rb b/app/models/form/sales/questions/armed_forces_spouse.rb index e463dfb1c..cf38bd434 100644 --- a/app/models/form/sales/questions/armed_forces_spouse.rb +++ b/app/models/form/sales/questions/armed_forces_spouse.rb @@ -5,7 +5,6 @@ class Form::Sales::Questions::ArmedForcesSpouse < ::Form::Question @check_answer_label = "Are any of the buyers a spouse or civil partner of a UK armed forces regular who died in service within the last 2 years?" @header = "Are any of the buyers a spouse or civil partner of a UK armed forces regular who died in service within the last 2 years?" @type = "radio" - @hint_text = "" @answer_options = ANSWER_OPTIONS end diff --git a/app/models/form/sales/questions/buyer2_live_in_property.rb b/app/models/form/sales/questions/buyer2_live_in_property.rb index 6c570b977..162627905 100644 --- a/app/models/form/sales/questions/buyer2_live_in_property.rb +++ b/app/models/form/sales/questions/buyer2_live_in_property.rb @@ -5,7 +5,6 @@ class Form::Sales::Questions::Buyer2LiveInProperty < ::Form::Question @check_answer_label = "Will buyer 2 live in the property?" @header = "Will buyer 2 live in the property?" @type = "radio" - @hint_text = "" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 2 end diff --git a/app/models/form/sales/questions/buyer2_relationship_to_buyer1.rb b/app/models/form/sales/questions/buyer2_relationship_to_buyer1.rb index 129ece54a..a37605332 100644 --- a/app/models/form/sales/questions/buyer2_relationship_to_buyer1.rb +++ b/app/models/form/sales/questions/buyer2_relationship_to_buyer1.rb @@ -5,7 +5,6 @@ class Form::Sales::Questions::Buyer2RelationshipToBuyer1 < ::Form::Question @check_answer_label = "Buyer 2's relationship to buyer 1" @header = "What is buyer 2's relationship to buyer 1?" @type = "radio" - @hint_text = "" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 2 end diff --git a/app/models/form/sales/questions/buyer2_working_situation.rb b/app/models/form/sales/questions/buyer2_working_situation.rb index b898efa1e..cf1ca3940 100644 --- a/app/models/form/sales/questions/buyer2_working_situation.rb +++ b/app/models/form/sales/questions/buyer2_working_situation.rb @@ -5,7 +5,6 @@ class Form::Sales::Questions::Buyer2WorkingSituation < ::Form::Question @check_answer_label = "Buyer 2's working situation" @header = "Which of these best describes buyer 2's working situation?" @type = "radio" - @hint_text = "" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 2 end diff --git a/app/models/form/sales/questions/buyer_company.rb b/app/models/form/sales/questions/buyer_company.rb index 036e96577..1dac995b0 100644 --- a/app/models/form/sales/questions/buyer_company.rb +++ b/app/models/form/sales/questions/buyer_company.rb @@ -4,7 +4,6 @@ class Form::Sales::Questions::BuyerCompany < ::Form::Question @id = "companybuy" @check_answer_label = "Company buyer" @header = "Is the buyer a company?" - @hint_text = "" @type = "radio" @answer_options = ANSWER_OPTIONS end diff --git a/app/models/form/sales/questions/buyer_still_serving.rb b/app/models/form/sales/questions/buyer_still_serving.rb index eb6d5736a..04929fb42 100644 --- a/app/models/form/sales/questions/buyer_still_serving.rb +++ b/app/models/form/sales/questions/buyer_still_serving.rb @@ -5,7 +5,6 @@ class Form::Sales::Questions::BuyerStillServing < ::Form::Question @check_answer_label = "Are they still serving in the UK armed forces?" @header = "Is the buyer still serving in the UK armed forces?" @type = "radio" - @hint_text = "" @answer_options = ANSWER_OPTIONS end diff --git a/app/models/form/sales/questions/housing_benefits.rb b/app/models/form/sales/questions/housing_benefits.rb index 578578eb4..db3e14c88 100644 --- a/app/models/form/sales/questions/housing_benefits.rb +++ b/app/models/form/sales/questions/housing_benefits.rb @@ -5,7 +5,6 @@ class Form::Sales::Questions::HousingBenefits < ::Form::Question @check_answer_label = "Housing-related benefits buyer received before buying this property" @header = "Was the buyer receiving any of these housing-related benefits immediately before buying this property?" @type = "radio" - @hint_text = "" @answer_options = ANSWER_OPTIONS end diff --git a/app/models/form/sales/questions/joint_purchase.rb b/app/models/form/sales/questions/joint_purchase.rb index 76d04a852..e2bf0f754 100644 --- a/app/models/form/sales/questions/joint_purchase.rb +++ b/app/models/form/sales/questions/joint_purchase.rb @@ -4,7 +4,6 @@ class Form::Sales::Questions::JointPurchase < ::Form::Question @id = "jointpur" @check_answer_label = "Joint purchase" @header = "Is this a joint purchase?" - @hint_text = "" @type = "radio" @answer_options = ANSWER_OPTIONS end diff --git a/app/models/form/sales/questions/mortgage_amount.rb b/app/models/form/sales/questions/mortgage_amount.rb index 2cd03448f..5ad85bd31 100644 --- a/app/models/form/sales/questions/mortgage_amount.rb +++ b/app/models/form/sales/questions/mortgage_amount.rb @@ -8,6 +8,5 @@ class Form::Sales::Questions::MortgageAmount < ::Form::Question @min = 0 @width = 5 @prefix = "£" - @hint_text = "" end end diff --git a/app/models/form/sales/questions/mortgage_length.rb b/app/models/form/sales/questions/mortgage_length.rb index 7bc09ff8a..317489763 100644 --- a/app/models/form/sales/questions/mortgage_length.rb +++ b/app/models/form/sales/questions/mortgage_length.rb @@ -8,6 +8,5 @@ class Form::Sales::Questions::MortgageLength < ::Form::Question @min = 0 @width = 5 @suffix = " years" - @hint_text = "" end end diff --git a/app/models/form/sales/questions/mortgageused.rb b/app/models/form/sales/questions/mortgageused.rb index b55bd8817..8c75750d8 100644 --- a/app/models/form/sales/questions/mortgageused.rb +++ b/app/models/form/sales/questions/mortgageused.rb @@ -6,7 +6,6 @@ class Form::Sales::Questions::Mortgageused < ::Form::Question @header = "Was a mortgage used for the purchase of this property?" @type = "radio" @answer_options = ANSWER_OPTIONS - @hint_text = "" end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/person_age_known.rb b/app/models/form/sales/questions/person_age_known.rb index 26913955e..a7e145739 100644 --- a/app/models/form/sales/questions/person_age_known.rb +++ b/app/models/form/sales/questions/person_age_known.rb @@ -5,7 +5,6 @@ class Form::Sales::Questions::PersonAgeKnown < ::Form::Sales::Questions::Person @header = "Do you know person #{person_display_number}’s age?" @type = "radio" @answer_options = ANSWER_OPTIONS - @hint_text = "" @conditional_for = { field_for_person("age") => [0], } diff --git a/app/models/form/sales/questions/person_known.rb b/app/models/form/sales/questions/person_known.rb index 02c9a3aaf..d03456989 100644 --- a/app/models/form/sales/questions/person_known.rb +++ b/app/models/form/sales/questions/person_known.rb @@ -5,7 +5,6 @@ class Form::Sales::Questions::PersonKnown < Form::Sales::Questions::Person @header = "Do you know the details for person #{person_display_number}?" @type = "radio" @answer_options = ANSWER_OPTIONS - @hint_text = "" @hidden_in_check_answers = { "depends_on" => [ { diff --git a/app/models/form/sales/questions/person_relationship_to_buyer_1.rb b/app/models/form/sales/questions/person_relationship_to_buyer_1.rb index 7dba287f0..72ee945f5 100644 --- a/app/models/form/sales/questions/person_relationship_to_buyer_1.rb +++ b/app/models/form/sales/questions/person_relationship_to_buyer_1.rb @@ -4,7 +4,6 @@ class Form::Sales::Questions::PersonRelationshipToBuyer1 < ::Form::Sales::Questi @check_answer_label = "Person #{person_display_number}’s relationship to Buyer 1" @header = "What is Person #{person_display_number}’s relationship to Buyer 1?" @type = "radio" - @hint_text = "" @answer_options = ANSWER_OPTIONS @check_answers_card_number = person_index end diff --git a/app/models/form/sales/questions/previous_postcode.rb b/app/models/form/sales/questions/previous_postcode.rb index 8d06bfb2d..039450102 100644 --- a/app/models/form/sales/questions/previous_postcode.rb +++ b/app/models/form/sales/questions/previous_postcode.rb @@ -6,7 +6,6 @@ class Form::Sales::Questions::PreviousPostcode < ::Form::Question @header = "Postcode" @type = "text" @width = 5 - @hint_text = "" @inferred_check_answers_value = { "condition" => { "ppcodenk" => 1, diff --git a/app/models/form/sales/questions/prevloc.rb b/app/models/form/sales/questions/prevloc.rb index 495a855aa..53f5e5090 100644 --- a/app/models/form/sales/questions/prevloc.rb +++ b/app/models/form/sales/questions/prevloc.rb @@ -6,7 +6,6 @@ class Form::Sales::Questions::Prevloc < ::Form::Question @header = "Select a local authority" @type = "select" @answer_options = ANSWER_OPTIONS - @hint_text = "" @inferred_check_answers_value = { "condition" => { "previous_la_known" => 0, diff --git a/app/models/form/sales/questions/prevown.rb b/app/models/form/sales/questions/prevown.rb index 3220e735a..a9a3b086b 100644 --- a/app/models/form/sales/questions/prevown.rb +++ b/app/models/form/sales/questions/prevown.rb @@ -6,7 +6,6 @@ class Form::Sales::Questions::Prevown < ::Form::Question @header = "Has the buyer previously owned a property?" @type = "radio" @answer_options = ANSWER_OPTIONS - @hint_text = "" end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/privacy_notice.rb b/app/models/form/sales/questions/privacy_notice.rb index c7d456556..5bc84bce6 100644 --- a/app/models/form/sales/questions/privacy_notice.rb +++ b/app/models/form/sales/questions/privacy_notice.rb @@ -5,7 +5,6 @@ class Form::Sales::Questions::PrivacyNotice < ::Form::Question @check_answer_label = "Buyer has seen the privacy notice?" @header = "Declaration" @type = "checkbox" - @hint_text = "" @answer_options = ANSWER_OPTIONS @guidance_position = GuidancePosition::TOP @guidance_partial = "privacy_notice_buyer" diff --git a/app/models/form/sales/questions/property_building_type.rb b/app/models/form/sales/questions/property_building_type.rb index cbd0706b6..80102cc7a 100644 --- a/app/models/form/sales/questions/property_building_type.rb +++ b/app/models/form/sales/questions/property_building_type.rb @@ -6,7 +6,6 @@ class Form::Sales::Questions::PropertyBuildingType < ::Form::Question @header = "What type of building is the property?" @type = "radio" @answer_options = ANSWER_OPTIONS - @hint_text = "" end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/purchase_price.rb b/app/models/form/sales/questions/purchase_price.rb index 1cce4582b..af7e8afb9 100644 --- a/app/models/form/sales/questions/purchase_price.rb +++ b/app/models/form/sales/questions/purchase_price.rb @@ -8,6 +8,5 @@ class Form::Sales::Questions::PurchasePrice < ::Form::Question @min = 0 @width = 5 @prefix = "£" - @hint_text = "" end end diff --git a/app/models/form/sales/questions/savings_nk.rb b/app/models/form/sales/questions/savings_nk.rb index 649ebb86a..f68b45560 100644 --- a/app/models/form/sales/questions/savings_nk.rb +++ b/app/models/form/sales/questions/savings_nk.rb @@ -6,7 +6,6 @@ class Form::Sales::Questions::SavingsNk < ::Form::Question @header = "Do you know how much the buyer had in savings before they paid any deposit for the property?" @type = "radio" @answer_options = ANSWER_OPTIONS - @hint_text = "" @conditional_for = { "savings" => [0], } diff --git a/spec/models/form/common/questions/created_by_id_spec.rb b/spec/models/form/common/questions/created_by_id_spec.rb index b00e21f90..dde117f43 100644 --- a/spec/models/form/common/questions/created_by_id_spec.rb +++ b/spec/models/form/common/questions/created_by_id_spec.rb @@ -39,7 +39,7 @@ RSpec.describe Form::Common::Questions::CreatedById, type: :model do end it "has the correct hint_text" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer options" do diff --git a/spec/models/form/common/questions/owning_organisation_id_spec.rb b/spec/models/form/common/questions/owning_organisation_id_spec.rb index 9ee32e342..8b57bebe1 100644 --- a/spec/models/form/common/questions/owning_organisation_id_spec.rb +++ b/spec/models/form/common/questions/owning_organisation_id_spec.rb @@ -40,7 +40,7 @@ RSpec.describe Form::Common::Questions::OwningOrganisationId, type: :model do end it "has the correct hint_text" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer options" do diff --git a/spec/models/form/lettings/questions/created_by_id_spec.rb b/spec/models/form/lettings/questions/created_by_id_spec.rb index b1ee1de49..c82ec13e1 100644 --- a/spec/models/form/lettings/questions/created_by_id_spec.rb +++ b/spec/models/form/lettings/questions/created_by_id_spec.rb @@ -40,7 +40,7 @@ RSpec.describe Form::Lettings::Questions::CreatedById, type: :model do end it "has the correct hint_text" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer options" do diff --git a/spec/models/form/lettings/questions/renewal_spec.rb b/spec/models/form/lettings/questions/renewal_spec.rb index 961d65153..820ff7c98 100644 --- a/spec/models/form/lettings/questions/renewal_spec.rb +++ b/spec/models/form/lettings/questions/renewal_spec.rb @@ -28,7 +28,7 @@ RSpec.describe Form::Lettings::Questions::Renewal, type: :model do end it "has the correct hint_text" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer_options" do diff --git a/spec/models/form/lettings/questions/rent_type_spec.rb b/spec/models/form/lettings/questions/rent_type_spec.rb index 45906ec81..4609b0568 100644 --- a/spec/models/form/lettings/questions/rent_type_spec.rb +++ b/spec/models/form/lettings/questions/rent_type_spec.rb @@ -28,7 +28,7 @@ RSpec.describe Form::Lettings::Questions::RentType, type: :model do end it "has the correct hint_text" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct conditional_for" do diff --git a/spec/models/form/sales/questions/armed_forces_spouse_spec.rb b/spec/models/form/sales/questions/armed_forces_spouse_spec.rb index 67bf934ff..d3cc9bccc 100644 --- a/spec/models/form/sales/questions/armed_forces_spouse_spec.rb +++ b/spec/models/form/sales/questions/armed_forces_spouse_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::ArmedForcesSpouse, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer_options" do diff --git a/spec/models/form/sales/questions/buyer2_live_in_property_spec.rb b/spec/models/form/sales/questions/buyer2_live_in_property_spec.rb index 0a5ae3699..c2d276c44 100644 --- a/spec/models/form/sales/questions/buyer2_live_in_property_spec.rb +++ b/spec/models/form/sales/questions/buyer2_live_in_property_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::Buyer2LiveInProperty, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer_options" do diff --git a/spec/models/form/sales/questions/buyer2_relationship_to_buyer1_spec.rb b/spec/models/form/sales/questions/buyer2_relationship_to_buyer1_spec.rb index 742c12ac0..059e5c084 100644 --- a/spec/models/form/sales/questions/buyer2_relationship_to_buyer1_spec.rb +++ b/spec/models/form/sales/questions/buyer2_relationship_to_buyer1_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::Buyer2RelationshipToBuyer1, type: :model end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer_options" do diff --git a/spec/models/form/sales/questions/buyer2_working_situation_spec.rb b/spec/models/form/sales/questions/buyer2_working_situation_spec.rb index 02b7a76b0..75b6fd7cb 100644 --- a/spec/models/form/sales/questions/buyer2_working_situation_spec.rb +++ b/spec/models/form/sales/questions/buyer2_working_situation_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::Buyer2WorkingSituation, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer_options" do diff --git a/spec/models/form/sales/questions/buyer_company_spec.rb b/spec/models/form/sales/questions/buyer_company_spec.rb index 1d7d98940..714aa0986 100644 --- a/spec/models/form/sales/questions/buyer_company_spec.rb +++ b/spec/models/form/sales/questions/buyer_company_spec.rb @@ -28,7 +28,7 @@ RSpec.describe Form::Sales::Questions::BuyerCompany, type: :model do end it "has the correct hint_text" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer_options" do diff --git a/spec/models/form/sales/questions/buyer_still_serving_spec.rb b/spec/models/form/sales/questions/buyer_still_serving_spec.rb index e5d91572e..887944a89 100644 --- a/spec/models/form/sales/questions/buyer_still_serving_spec.rb +++ b/spec/models/form/sales/questions/buyer_still_serving_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::BuyerStillServing, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer_options" do diff --git a/spec/models/form/sales/questions/housing_benefits_spec.rb b/spec/models/form/sales/questions/housing_benefits_spec.rb index 5579f3b48..8c3ae57d3 100644 --- a/spec/models/form/sales/questions/housing_benefits_spec.rb +++ b/spec/models/form/sales/questions/housing_benefits_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::HousingBenefits, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer_options" do diff --git a/spec/models/form/sales/questions/joint_purchase_spec.rb b/spec/models/form/sales/questions/joint_purchase_spec.rb index c9f548071..5d738531c 100644 --- a/spec/models/form/sales/questions/joint_purchase_spec.rb +++ b/spec/models/form/sales/questions/joint_purchase_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::JointPurchase, type: :model do end it "has the correct hint_text" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer_options" do diff --git a/spec/models/form/sales/questions/mortgage_amount_spec.rb b/spec/models/form/sales/questions/mortgage_amount_spec.rb index ac1e5ad5e..eadec2876 100644 --- a/spec/models/form/sales/questions/mortgage_amount_spec.rb +++ b/spec/models/form/sales/questions/mortgage_amount_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::MortgageAmount, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has correct width" do diff --git a/spec/models/form/sales/questions/mortgage_length_spec.rb b/spec/models/form/sales/questions/mortgage_length_spec.rb index 273c13c7b..519289607 100644 --- a/spec/models/form/sales/questions/mortgage_length_spec.rb +++ b/spec/models/form/sales/questions/mortgage_length_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::MortgageLength, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has correct width" do diff --git a/spec/models/form/sales/questions/mortgageused_spec.rb b/spec/models/form/sales/questions/mortgageused_spec.rb index 19f41102d..e958de8ea 100644 --- a/spec/models/form/sales/questions/mortgageused_spec.rb +++ b/spec/models/form/sales/questions/mortgageused_spec.rb @@ -43,6 +43,6 @@ RSpec.describe Form::Sales::Questions::Mortgageused, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end end diff --git a/spec/models/form/sales/questions/person_age_known_spec.rb b/spec/models/form/sales/questions/person_age_known_spec.rb index 2cc760fc5..d61bccfc3 100644 --- a/spec/models/form/sales/questions/person_age_known_spec.rb +++ b/spec/models/form/sales/questions/person_age_known_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::PersonAgeKnown, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end context "with a non joint purchase" do diff --git a/spec/models/form/sales/questions/person_known_spec.rb b/spec/models/form/sales/questions/person_known_spec.rb index 551ac096e..9cb7ab578 100644 --- a/spec/models/form/sales/questions/person_known_spec.rb +++ b/spec/models/form/sales/questions/person_known_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::PersonKnown, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end context "with a non joint purchase" do diff --git a/spec/models/form/sales/questions/previous_postcode_spec.rb b/spec/models/form/sales/questions/previous_postcode_spec.rb index cb763dc81..eb55b7cf1 100644 --- a/spec/models/form/sales/questions/previous_postcode_spec.rb +++ b/spec/models/form/sales/questions/previous_postcode_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::PreviousPostcode, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct width" do diff --git a/spec/models/form/sales/questions/prevown_spec.rb b/spec/models/form/sales/questions/prevown_spec.rb index b98ba77ef..dda2b7c70 100644 --- a/spec/models/form/sales/questions/prevown_spec.rb +++ b/spec/models/form/sales/questions/prevown_spec.rb @@ -44,6 +44,6 @@ RSpec.describe Form::Sales::Questions::Prevown, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end end diff --git a/spec/models/form/sales/questions/privacy_notice_spec.rb b/spec/models/form/sales/questions/privacy_notice_spec.rb index f90daef1b..fc1df796c 100644 --- a/spec/models/form/sales/questions/privacy_notice_spec.rb +++ b/spec/models/form/sales/questions/privacy_notice_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::PrivacyNotice, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer_options" do diff --git a/spec/models/form/sales/questions/property_building_type_spec.rb b/spec/models/form/sales/questions/property_building_type_spec.rb index 1129bf792..9b8f94b5f 100644 --- a/spec/models/form/sales/questions/property_building_type_spec.rb +++ b/spec/models/form/sales/questions/property_building_type_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::PropertyBuildingType, type: :model do end it "has the correct hint_text" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct answer_options" do diff --git a/spec/models/form/sales/questions/purchase_price_spec.rb b/spec/models/form/sales/questions/purchase_price_spec.rb index 1ee30b9a5..8894a592f 100644 --- a/spec/models/form/sales/questions/purchase_price_spec.rb +++ b/spec/models/form/sales/questions/purchase_price_spec.rb @@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::PurchasePrice, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has correct width" do diff --git a/spec/models/form/sales/questions/savings_nk_spec.rb b/spec/models/form/sales/questions/savings_nk_spec.rb index 6847c4f5a..519bdd8d4 100644 --- a/spec/models/form/sales/questions/savings_nk_spec.rb +++ b/spec/models/form/sales/questions/savings_nk_spec.rb @@ -45,7 +45,7 @@ RSpec.describe Form::Sales::Questions::SavingsNk, type: :model do end it "has the correct hint" do - expect(question.hint_text).to eq("") + expect(question.hint_text).to be_nil end it "has the correct hidden_in_check_answers" do